Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <d23cd6c1-17c1-57a0-a1fb-2d3516e3ef88@intel.com>
Date:   Mon, 11 Sep 2023 16:05:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH v9 6/9] x86/resctrl: Move default group file creation to
 mount
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230907235128.19120-1-babu.moger@amd.com>
 <20230907235128.19120-7-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230907235128.19120-7-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnRuczVFRlNXY0ltSDAzRmRhdHJRbTg0amZlWlF0RkJ4UUk2S1dIOGxVZERK?=
 =?utf-8?B?dFhDeHdGN0t5WGhQa0RUcExqT2dLVHFocUpJTkpHWVU3TVJzNjZiWUhhU1RI?=
 =?utf-8?B?OGRZeWYzVWZVL2Z1M0s5c2V0V2QwVXM2bG5PVXRCdFRaYVR3ZXV2WGZUKzZa?=
 =?utf-8?B?Z1lSUFE3b2Q3K1BCUno0Nlo1THhOU3J0bzFxM1ZFVXlNSTdFdXZkYk5WR282?=
 =?utf-8?B?S1FDSitQSjBlVlRhNG91b1NXQldjemhuenpmYlVRSncybUp1MVhsK0EzamFq?=
 =?utf-8?B?VVRkeUlZWjJFQk8raWhGOXUvNDVjU2lzK2JqeWR5ODh6K01UcGV1WkxleEtM?=
 =?utf-8?B?MjJQaDRzdWF0cExHUHNibG1Zd3ZHRWdhaEpNSmZkS3dzSHNMeEF0TkdOQkdL?=
 =?utf-8?B?K2xEckhXMEJsYi9hRFV3TGR3cDAzUzF6TWFEWTN0dEhEalhZVk1oWVZmM2Rn?=
 =?utf-8?B?R3c3QTZSaXlRWHNuMTZ0L2t6SzhXWjFFYjdhZzgxS2crY2NSYjVvTlgxSXVm?=
 =?utf-8?B?RW91Wk5FNnFmQnRmNDhqeXBKR0pvdlNYUjhYYUc5c2N5NVorK1lpcWh5OHc2?=
 =?utf-8?B?dmdkdDhnbmdiNFMzU1FBMnFRMDlzdllLblBTZVBCc2xGUUJlRG9pSVFnWUVJ?=
 =?utf-8?B?SWRHaGRpZlBrWiswWGE1N0QrNkhvTlJUQlIyWGsyR3JUVzV0YURSVU02eUIz?=
 =?utf-8?B?MXcxaXJqbWs5cUh5bzZCeElVcU9tOUkwd0RlK01Ucmo1aGc0QldqQXFUSEdi?=
 =?utf-8?B?MTdSWkRycnhJSWl6Z1BXT2J4RFJQZUUrUEk2ZHZ1TEhRZU55SlZ5WE4rYUdX?=
 =?utf-8?B?UlZBdWk3RU9HWWVWRnc3WkJVYTh6Y3FlYzVqVC9wYUUwbHVjaVdaaE1PRzF6?=
 =?utf-8?B?a2lxbWczclJ1R0syMzI1UmVnTW1NbnlSQkNoVWNscndkZ3U5bHVRYldnNDNh?=
 =?utf-8?B?RE5IYUpCNU4xQXZ1UUtpRlFHNGE5WTdMbWprRWRvVDBGZWxvR1FBeXFRWjdL?=
 =?utf-8?B?YU53bDNFZ3lNdEpuNm8rMlY4NVJqdkVSelU5UXRNNjMzQnFRK1JFMUVMY0hT?=
 =?utf-8?B?SE9ncVJZUmkwVlo5T1BzWk1YVWgxTFllQlhvMnhWZVNuMVJrRHAxYUdJUFEx?=
 =?utf-8?B?ZE00R3J4VWJyZ1JvNGVLYXdxcENmbHc5QnJ2UVIvMUJIN1I3c3dkWUZmeGs1?=
 =?utf-8?B?TExCdUJXbnlKN0hjdktsK0Y2MW9jbk9Na29wcHpMWkl3cHc1d1VVN05sQlJi?=
 =?utf-8?B?RHZJeHovMFBJUG9Fb3VxZkhxbWZFTGJqZnI1Mmd3VFErMzA2WHR5Ui95T092?=
 =?utf-8?B?NE1ENlJ5aUpMaWcxR2JLY2RjVGVPNkN2L0N1aFhsUlA2K25tbytobWhFZkx6?=
 =?utf-8?B?eHlFOTJXaDBwNU9OTXEzVDhKV3hyOGZONjhPd1RzY1ArWWJrQjMyYktvN1lj?=
 =?utf-8?B?UStQV3hHbmlzT3ZhTnJPbFBiSVhRWmdnTlZRb0UzMDJva0l5dGFTSFJCRlhT?=
 =?utf-8?B?YmNoRHVvUk5Udk5XQ2hhenl4UnlCNFZkbU40bVMxUmJ1cmNXcUtWVmpOTG42?=
 =?utf-8?B?aHlqN2kwQUlIVXhZaGlkRjNLRjBFZk9EbzNJRkpPUk50UVBzZ0w4ai80T0hy?=
 =?utf-8?B?anJCYk90aWtuOFVJcDFPQkpFWUFkbjRCNDJTdmVNWWFlRGFuU05iTUVvZFNQ?=
 =?utf-8?B?d29VN1pSMzFoTk1yb2huODM1TS9KZHJWaHVSRnU1NXJlVFg1NXZIbFE2TEcx?=
 =?utf-8?B?YUdMVTErd2pDZ094R3E1TjhvVFdtT2NENnpmNTVHNzBUUHlRMGhuT0p0QnN0?=
 =?utf-8?B?ejB0emdIVHdmc0NDdUlyTVZFV29sSUdTc3RUTGszWE10MU9XWFU4eGhndEJK?=
 =?utf-8?B?bDl4RXRCTk1GakVkdkVmTit4NkNBMlk0L0NybWZvTGZibjdtRzZLaDdySHpj?=
 =?utf-8?B?MXVxaWtUaW9RZTBENEt3NFFaR09jTVpPWWlqOFlHcjNFMlR4UXVDV08vVnlw?=
 =?utf-8?B?SzhDYkJ5UjBxN2QxcTVaQmVhZGE2d2VyaVB1bGljSkV5SGFHSFJ1aGZEdkFT?=
 =?utf-8?B?V3lhckRmN3AvMG52KzlVQ3ZvZ1BsbUZVSTNsN3dnbTNhbWlHdVBlUFlZUVdP?=
 =?utf-8?B?RUkxNFR2MXZLNVFvTlF3Y3c4NVd5ZkNCbE5mODAxY2Zvd05jYzVTbWQrUjhs?=
 =?utf-8?B?VVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebb3855-155b-4fe3-9d1d-08dbb31b90c4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2023 23:05:17.8882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZA0QuQK3T00U5E1EmDuk5s0X0IUB3IWTZdi64gva+7DmCdYR5sfYeNP0kluQqPA9r59UKy+K6Rq7EVfD6tip8ktMKakORC68XvZ8ZLlwH3Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5516
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:48:10 -0700 (PDT)

Hi Babu,

On 9/7/2023 4:51 PM, Babu Moger wrote:
> The default resource group and its files are created during kernel
> init time. Upcoming changes will make some resctrl files optional
> based on a mount parameter. If optional files are to be added to the
> default group based on the mount option, then each new file needs to
> be created separately and call kernfs_activate() again.
> 
> Create all files of the default resource group during resctrl
> mount, destroyed during unmount, to avoid scattering resctrl
> file addition across two separate code flows.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette