Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2367714rdb; Mon, 11 Sep 2023 22:23:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmkjD5O3+6PJRI4Y7JY1Q4zcvPWN27JiVVx9hJBMHFPyt2ASxxHNCVWDunftG5oA0KYs6Q X-Received: by 2002:a17:902:d4cc:b0:1c3:c758:4311 with SMTP id o12-20020a170902d4cc00b001c3c7584311mr2970193plg.58.1694496183121; Mon, 11 Sep 2023 22:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694496183; cv=none; d=google.com; s=arc-20160816; b=OBZg1Wi3aLuqSXopZ5dZRCAIQwWBpDrzvPDWTwBwOqnhGXv0zkqs0ZEjSH2SFPSIvT oA4/bHOFYa2TfDbUuiNajC3AuidqSbG7H3hzHQV0458UvgIwbJVdXi9Dh/m9HtbyIIx7 7y2+WflBfp3hf7l6nphy2USyNBhRlyICgtuUiB7wGu8MjIyQc2nK1dINegs9HhrUU//U AxVXsTLHh5VuOowZZo+4BKi5ezYiZ9p9JwtTch3p8BiLsH4cjfIbFwFtfrtAanzKz2P+ lcIblTa8mfqjtLEMZ2MWrqAhBzo2glD0pEVzU3DefiLdzgFAfbtlj939jioMGNJtagPO i4rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=qoU8pawkfWz2jBab7H2Q6iih1Rp9zPJMYbuX/5SMDog=; fh=ixAnv2aYny+HNRUDDotTFfsLCSyAeSUS223lkgZftJc=; b=Ay6q6fogF5h8bZASV7/9fDuoP0KAVC9EndodwI2vim5soXMgfT6kGhfa5rU0WvAywv h10t4vJvayzfbMM+WeAe361R+rr1Go1ebw1FJFmt6yPRyAiQ2xXSE+B/8sJU91FWmsDG iUlMphaSu8CeQWxqMkj2r1TreBW85CFAA82NRoJ9XF/HjwPmzYGB9UrNyzfPMjjGT5Eg UbPhKMgrwH2WUWDOtcgcp8cYsikoHBtGR9aqHfx5kLkgs5uVoHOvUxT/CfrWy+8HzCZV U5WILgwM1yb2zYWKPyck0GN9EpdzJ7yiMhvWNaHNvQ8aFnjU0NqSLeYVs9QisYK6WaHP MCrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u13-20020a170903124d00b001b86671b3f1si7760857plh.190.2023.09.11.22.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 22:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 013D880248C0; Mon, 11 Sep 2023 21:29:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241392AbjILC7X (ORCPT + 99 others); Mon, 11 Sep 2023 22:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241222AbjILC7G (ORCPT ); Mon, 11 Sep 2023 22:59:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5B4A11E162; Mon, 11 Sep 2023 18:24:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27B1AC116AE; Tue, 12 Sep 2023 01:24:37 +0000 (UTC) Date: Mon, 11 Sep 2023 21:24:53 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Shuah Khan , Mark Brown , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment Message-ID: <20230911212453.58b9082a@gandalf.local.home> In-Reply-To: <169448103881.242465.4589561134225171701.stgit@devnote2> References: <169448103881.242465.4589561134225171701.stgit@devnote2> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:29:19 -0700 (PDT) On Tue, 12 Sep 2023 10:10:39 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Fix to unmount the tracefs if the ftracetest mounted it for recovering > system environment. If the tracefs is already mounted, this does nothing. > > Suggested-by: Mark Brown > Link: https://lore.kernel.org/all/29fce076-746c-4650-8358-b4e0fa215cf7@sirena.org.uk/ > Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel") > Signed-off-by: Masami Hiramatsu (Google) > --- > Changes in v2: > - use -n option explictly for testing the string is non-zero. > --- > tool Reviewed-by: Steven Rostedt (Google) -- Steve