Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2377893rdb; Mon, 11 Sep 2023 22:56:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuUL+3+Yj9Jbc4/SfUhUQ8rZRegiY0XsouVhtNaJK5UJRPtaqJ+7kzSLLwZhQs5foCFcsa X-Received: by 2002:a05:6870:a68c:b0:1be:f311:4a29 with SMTP id i12-20020a056870a68c00b001bef3114a29mr14428586oam.20.1694498173382; Mon, 11 Sep 2023 22:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694498173; cv=none; d=google.com; s=arc-20160816; b=nrF+n+kApkInWiTmncHWhXlFowLVPP3XRIaJ7PGTFK2MoQb1tdSftkWjozp8G5mxKY meBMHgqZWTjOWV+Hp9kc4hqR8x7ZGY07k/yyGhUrvhj0/BlopAGfK2fs4XS/wEH6c0o/ ey5aKC8urXYDy4FgsA3IzLxxiRJFn35mFyMmf7yqIOLaCPJGgxB05s24eI1+qKF7ueCa oc8rW3RKVCT/iqcV8HKAjYwG0fSAeKQd34MIPi05+/ttTD9i2g10IRizSiWpX70EWSO9 S6L9y7kjER68XTa6MDOQ5zsHatWDPZpRO0+3jXehvJE7dK7NMB6vmYcTcK3w95ladMCI Lo8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=lV6FBUAlgcm1rbH5Rgz1aKNU1axCNovLrgqi4LmnJ34=; fh=OF3ARR+5xO6WiUJQqaqEUeBC5yKHa1WNFEYzDffdDqA=; b=r7UG0j+qrujyCxWi/dfueDEan/9Xk/DnIfCZSG3MXs3Ecvuj0Drquqp/fiNDg2aaLb o30ij2RlJgf19JnmQg05P7Ynhycr+vUuAplKinrJl8qWhJgfizO/tZcLWf5h0ycaSkrv nNCC5TRSDuRxgEf0MZdrjvY66001YUcpr2jWmktzHF9c73gaxMuzK89KR53/WSiudOS0 F7pHpOnFJduh6ISXl4S9LZ8VyIRxgQWihzaTTuy2kyyKmQPU3M4to0Rr8bTWWl4Fm5JY nkeFwljtkVIhGXAsykiZoQgJOFEmdFfv/Rn3ibzSpxaSbhOXDoj42kOfmVPBFHjze4VU RwaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id a65-20020a639044000000b0057754fd6270si4531961pge.651.2023.09.11.22.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 22:56:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 39B5E828E8D8; Mon, 11 Sep 2023 21:31:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235682AbjILCJh (ORCPT + 99 others); Mon, 11 Sep 2023 22:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244006AbjILCGi (ORCPT ); Mon, 11 Sep 2023 22:06:38 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 687C134A5C; Mon, 11 Sep 2023 18:38:13 -0700 (PDT) Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 149016059CE35; Tue, 12 Sep 2023 09:37:50 +0800 (CST) X-MD-Sfrom: kunyu@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li kunyu To: john.johansen@canonical.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com Cc: apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Li kunyu Subject: [PATCH] apparmor/file: Removing unnecessary initial values for variable pointers Date: Thu, 14 Sep 2023 02:09:03 +0800 Message-Id: <20230913180903.3776-1-kunyu@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:31:47 -0700 (PDT) These variable pointers are assigned during use and do not need to be initialized for assignment. Signed-off-by: Li kunyu --- security/apparmor/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/apparmor/file.c b/security/apparmor/file.c index 698b124e649f..12eafdf18fc0 100644 --- a/security/apparmor/file.c +++ b/security/apparmor/file.c @@ -264,7 +264,7 @@ int aa_path_perm(const char *op, struct aa_label *label, { struct aa_perms perms = {}; struct aa_profile *profile; - char *buffer = NULL; + char *buffer; int error; flags |= PATH_DELEGATE_DELETED | (S_ISDIR(cond->mode) ? PATH_IS_DIR : @@ -412,7 +412,7 @@ int aa_path_link(struct aa_label *label, struct dentry *old_dentry, d_backing_inode(old_dentry)->i_uid, d_backing_inode(old_dentry)->i_mode }; - char *buffer = NULL, *buffer2 = NULL; + char *buffer, *buffer2; struct aa_profile *profile; int error; -- 2.18.2