Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20230911170559.4037734-1-irogers@google.com> <20230911170559.4037734-3-irogers@google.com>
In-Reply-To: <20230911170559.4037734-3-irogers@google.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 11 Sep 2023 23:00:05 -0700
Message-ID: <CAM9d7cgCufCz9ti+j562rf1oNDo3BD7Tdc2bsYijDxBmZBrqFQ@mail.gmail.com>
Subject: Re: [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        James Clark <james.clark@arm.com>,
        Gaosheng Cui <cuigaosheng1@huawei.com>,
        Rob Herring <robh@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> expr-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/util/expr.y | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 6c93b358cc2d..e364790babb5 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -1,6 +1,8 @@
>  /* Simple expression parser */
>  %{
> +#ifndef NDEBUG
>  #define YYDEBUG 1
> +#endif
>  #include <assert.h>
>  #include <math.h>
>  #include <stdlib.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>