Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <076b59c0-7585-ea98-014c-cd70f92df002@amlogic.com>
Date:   Tue, 12 Sep 2023 14:37:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings
 for Amlogic C3 Reset Controller
To:     neil.armstrong@linaro.org, Philipp Zabel <p.zabel@pengutronix.de>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Jerome Brunet <jbrunet@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, kelvin.zhang@amlogic.com
References: <20230719060954.14864-1-zelong.dong@amlogic.com>
 <20230719060954.14864-2-zelong.dong@amlogic.com>
 <f7b72ee90009f6749700a7bd79a3a63786a82a32.camel@pengutronix.de>
 <55cbdbba-39c6-7415-37db-97d2c35412cb@linaro.org>
From:   Zelong Dong <Zelong.Dong@amlogic.com>
In-Reply-To: <55cbdbba-39c6-7415-37db-97d2c35412cb@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1NkejNlNE0weE85TkV6Sm9Xdy9NeGZQTGk0cGl1L2FsR3E4M0tMTkEyZHNr?=
 =?utf-8?B?TlcvYzZPNnB3SDVkSzFyQWh2WGNlU1BrVDVwVEVqRmliMUJOWUx4Y2pXdEp3?=
 =?utf-8?B?Ykoxb2hPM0xEY1BBNlpQNWU2M0planVONzNURm5ISm1KSkxMRFF4eldVakU4?=
 =?utf-8?B?dStQM0ZadEtaUi9COWVFMUF2ZFRLVDBDUURIY3Q3eE9jSTMxYStKMmxKQ0RN?=
 =?utf-8?B?OGNXeTRlTDRhR2pEYkY4b1pucDMrM1o0bFpqZ3V2amdaSHh1LzJuWjROaU1B?=
 =?utf-8?B?MmxPOXNVRlF2ZXVtQm85dmRxVXZ0ZGxJYzUxR2ZKa1lDMVh6QVhZY25WeEFB?=
 =?utf-8?B?UXVpdDZjUzBGeUN2MTFDR2pIbDYxdzNxejZpVjhmeHRCVU9aQ2FzeWpta2ZC?=
 =?utf-8?B?a3dVU2VtYWRLOFg2aXZjZFRYUDc0cXhsN05LcFR0dmlEZ0FkRW5wbmJTeDMw?=
 =?utf-8?B?L3J4SGpKVm1yN1FxSFZ3VlVvRHl1L3V6aTVjQXlCdkJ2dzNuNzVDWXpEbWgv?=
 =?utf-8?B?K0UyTjlkcVhuUFZyeTVkR2JkN0x3MXpXcXhPWEdybUNYVFJxdncvME5HdWQr?=
 =?utf-8?B?cmlHc2VnaXh6Q1pwRXVpdFlNR1BvVUdvVElRVmYxd2FKNkpSZU1sQ2JQQkgv?=
 =?utf-8?B?YUpETlBCcFBLUGdWTUk2YUROYUJzblVzNWxnQXpXeDRCdGJsNFlwbXJ3R2h1?=
 =?utf-8?B?bldXaERBKzMrZ0FvNU9xQmR4dDZteVJhUDc0b1R1ZnVvcjlFMlF5NG10SHJ0?=
 =?utf-8?B?MS94MU9halpNZkFDbXpOcnUxb0NUS05Jd0diMlVSWDJHdlovcjY1WlE3aUVH?=
 =?utf-8?B?a3kvOGJoS3VvNC9xbHV0eFFBM3Q1M3k2SDRXTTBHbE52Zjd1YXUxY3RGMnRm?=
 =?utf-8?B?NnZSczFUN0RXREQ1MCs2QUNXdS9tdHQybXl5bG1YR2hYZ3YwTW03WkRKYVlJ?=
 =?utf-8?B?R2lHNWIvM3IxZC8zaWZ3UEhKMVl6V1pjR2JSZzVtTmpvdGpUdlkrQmFWT2Yr?=
 =?utf-8?B?ejhueW9uK2Z3VDNNZUNxcHlKMEloNjZoY3NaY1lpL1JsSis5WldmeC94Ly92?=
 =?utf-8?B?QjhpUVBMb0djMWo0QkVNcmNqUmo2V2dnOWRFNmkyQnhWNXcyd0ZPVElFVXR1?=
 =?utf-8?B?YmVqZEU2d3dSQkhjTDh5SjRCWWFVZlBjWTkrTzJmWmlWWFQ5Y2YyUG5PQUtk?=
 =?utf-8?B?bXM3U21CVVk2cEZTcFp5Lzl4Q2xZSmNIZXlERUliRGN4SjNFdTZWREQyc2Z5?=
 =?utf-8?B?OVpwdjI1dmx0UUV4citwQWVaYm5DWmNJYnFFZHdNcTdPSTFVckdRZFRTVkFH?=
 =?utf-8?B?SlJhWm9FU0g1U2thU0pBQUgrcnFBSjVzRWlQNkVnU0JweFVYdnRaTndxK1dh?=
 =?utf-8?B?L0lYbTBNV0o1MDRvdnpjbjNLZEtpUDF6b2RWbjY5OTFISlQwZU93dkN1dlIw?=
 =?utf-8?B?RmR2c1cvTzY4RFJHQVNlMGNJVUg1ZytLSDhHMU1oMGUrODdqZllVTXBlMjRh?=
 =?utf-8?B?a2lsWmkyQ2lDNVVrSVh1VC8ranppZXhnYTVtRXZuRTRNVitYUzIrTUJzaGNH?=
 =?utf-8?B?SE9Od2pWQ3BNVEZkQ0JKeUx6c0d3S0pmeEg0Y2xuOWhKNTU4Wjh6Lzk5cGlR?=
 =?utf-8?B?Yk1mOGs1YXhQMktyYkhjN0N6VnNXdW94RlRyZ1Y0Q05KYUVmeHVtN0xlQW12?=
 =?utf-8?B?N1MzYUFBNFFFWjVPT2g1WXpqeHY3OCthN25PaVUyUmk0ZlBRK2t3b3BGM21C?=
 =?utf-8?B?NDkxRUpMbHZjZlduMDdNYlIwam5jbXNqVVA5SEtvSUcxMWQ2L2loQnpWTDNi?=
 =?utf-8?B?dTVvUi95cnkzYXBIQWc0dHlRWlpPeTJHWEJNODlMV3BLcTAwb0U4ZVBYZk9D?=
 =?utf-8?B?N2h5d1UzZ2c5MGM0d1Q4NFZBcmFDc2NOM2l4RzlEUzM3SEsyMzdEVVBLWnpv?=
 =?utf-8?B?UHNYZXNUNnNmSi96ekcwYTBBaTVYNERUU3pmTUpMRzVLQzd1a1dlUlZGYXlo?=
 =?utf-8?B?RWVjKytheS9QNVpab0F6L3I2S1BNRnNwd0hHNjJuck1raDBIRTFjUWNEZ29r?=
 =?utf-8?B?dTFoLzVCeDlkc3ZpRXdONmx6ZWRYYkhQWjBGck5EcmszM242ckYxcVJneDFk?=
 =?utf-8?B?NHZMV2VneTlaTzg3N3p4U1NHLzd4dEdKSzRlS1lvY21HanRlTGU2K1o1cGV6?=
 =?utf-8?B?Nmc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27b98148-04a5-4c06-1afd-08dbb35ad03d
X-MS-Exchange-CrossTenant-AuthSource: TY0PR03MB7240.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 06:38:02.7232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RLYMbbH9STp+G7nm4lVvqtuzhzhFQcwlyVjjh6TsuMm3CTBEqAwLuGNbrcyf1BEzBncuVcF/2TsI7sO/83bikw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6773
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 11 Sep 2023 23:39:06 -0700 (PDT)
X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email

在 2023/7/31 17:17, Neil Armstrong 写道:
> On 28/07/2023 17:49, Philipp Zabel wrote:
>> On Mi, 2023-07-19 at 14:09 +0800, zelong dong wrote:
>>> From: Zelong Dong <zelong.dong@amlogic.com>
>>>
>>> Add new compatible and DT bindings for Amlogic C3 Reset Controller
>>>
>>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>>> ---
>>>   .../bindings/reset/amlogic,meson-reset.yaml   |   1 +
>>>   include/dt-bindings/reset/amlogic,c3-reset.h  | 119 ++++++++++++++++++
>>>   2 files changed, 120 insertions(+)
>>>   create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml 
>>> b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> index d3fdee89d4f8..f0c6c0df0ce3 100644
>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> @@ -18,6 +18,7 @@ properties:
>>>         - amlogic,meson-axg-reset # Reset Controller on AXG and 
>>> compatible SoCs
>>>         - amlogic,meson-a1-reset # Reset Controller on A1 and 
>>> compatible SoCs
>>>         - amlogic,meson-s4-reset # Reset Controller on S4 and 
>>> compatible SoCs
>>> +      - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>>
>>>     reg:
>>>       maxItems: 1
>>> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h 
>>> b/include/dt-bindings/reset/amlogic,c3-reset.h
>>> new file mode 100644
>>> index 000000000000..d9127863f603
>>> --- /dev/null
>>> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h
>>
>> Given that this is only included by
>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be
>> moved to arch/arm64/boot/dts/amlogic ?
> 
> Maybe I missed something, but since when should we move bindings headers 
> to arch/xxx/boot/dts/vendor ?
> 
> Neil
> 
>>
>> regards
>> Philipp
> 
Hi,
It's been a while, how will we deal with this patch ?
Should we let this patch apply first? If Amlogic reset bindings headers 
need to be moved to arch/xxx/boot/dts/vendor, could we apply it in a 
separate change?