Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <29739e31-a217-0fc2-fabf-30bd4f50c5b6@ti.com>
Date:   Tue, 12 Sep 2023 10:06:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
CC:     <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <r-gunasekaran@ti.com>,
        <srk@ti.com>, <s-vadapalli@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for
 overlay file
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
References: <20230911052158.89185-1-s-vadapalli@ti.com>
 <20230911165610.GA1362932-robh@kernel.org>
 <340bb897-d735-fabc-a031-8e4ebcfe79fa@ti.com>
From:   Siddharth Vadapalli <s-vadapalli@ti.com>
In-Reply-To: <340bb897-d735-fabc-a031-8e4ebcfe79fa@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/09/23 09:31, Siddharth Vadapalli wrote:
> Rob,
> 
> Thank you for reviewing the patch.
> 
> On 11/09/23 22:26, Rob Herring wrote:

...
>> Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.
> 
> Sure, I will place it above the k3-j721s2-evm.dtb line.
> 
>>
>>>  dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
>>
>> I think dropping these will cause them to not get installed (by 
>> dtbs_install). Presumably you want them.
> 
> I will undo the above deletions in the v2 patch.

I have addressed the feedback and have posted the v2 patch at:
https://lore.kernel.org/r/20230912043308.20629-1-s-vadapalli@ti.com/

> 
>>
>>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>>>  
>>>  # Boards with J784s4 SoC
>>>  dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
>>> -- 
>>> 2.34.1
>>>
> 

-- 
Regards,
Siddharth.