Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2404209rdb; Tue, 12 Sep 2023 00:07:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4eATn7Gsw0xtQNMdK0uzG+WRUv1Si7Z5zMsXY1vLBjtcVSKJm+YXRp0WO/ntcZoUOgCz7 X-Received: by 2002:a17:902:d484:b0:1bb:77a2:edda with SMTP id c4-20020a170902d48400b001bb77a2eddamr13804180plg.36.1694502472583; Tue, 12 Sep 2023 00:07:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694502472; cv=none; d=google.com; s=arc-20160816; b=gHq6UT4tyDtX8ZMVfa8EiQDvCaBTZq7Lfp1tmBGRcsrS4S4SFNu91dZXIl76xWZ270 F03Gw6Jq45jLGaU70UPujG1ex+pvPsImkN0hCyRpOok9mfgXRA5XshTJAZD+Kbitc0Fe SsvPUHLc2tf3d8vrcCEJjhSusgMn9kmHN9IxPfsHlelsOtykR/UzAWxdbu942l5/p0Tw FLX0470dpvg4cmo/wUxN3NOzzhjHXUlFTgTLLN5mITffXw5qamHq2L7xqYUP0aFmVL/b zMPG/HYwpvCOVGCtckt+AgystUZwOVslKSMvIcCTb+dmwCrctsD2LoSYzp/CLTmIgoo9 Ha4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=B30cQR4KsHwNvaeoC8Z4dw3bG2+oBb1t/+4IAjCtWX0=; fh=JreNpQ6u6z6wlntFlJN9hcKitVjcFOBEYws20WfOvI0=; b=Qn/K/1qktRMNn1xfw+uGgdv+E2n/+a5UCsqPUicbc46jW7JD0DE+O0wUpgEvLShIaH NFGpKo+UdpmJR7qRaFGvJzfkPCWfLFBrWvNBdrvh9sA7vQM3qpzalKey7UvjcHl/m9rw XibBRB3D3I/1PzTrJd3fd91R27AaFOvc+y5xox7C0twnUX+Sy8QyYN+DL7O2Bl5/rlhh U6E4AN/NYCdCBfumXMDOWpSDBGTd5VM4grF5e4JcEgOMnxhIwppae1TYQ6WxCQKEX7nP Fdie5mtE9NGBKlcKRslLdRLB3P2yCftPceOl26TU3Yap2Jt1SDZ8SpJECb5x5yL/Nmlh dhvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tWLPj6LH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ku8-20020a170903288800b001bf1d1d99b0si7466106plb.568.2023.09.12.00.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 00:07:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tWLPj6LH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B8B8A8142D95; Tue, 12 Sep 2023 00:04:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbjILHE1 (ORCPT + 99 others); Tue, 12 Sep 2023 03:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231313AbjILHEW (ORCPT ); Tue, 12 Sep 2023 03:04:22 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD4CE7C for ; Tue, 12 Sep 2023 00:04:19 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-d8020510203so3546598276.2 for ; Tue, 12 Sep 2023 00:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694502258; x=1695107058; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B30cQR4KsHwNvaeoC8Z4dw3bG2+oBb1t/+4IAjCtWX0=; b=tWLPj6LHrmRPWGbuAJ2yvYheVGZwEV+xDbPL8K6pIS7cU+Q6/E+jpXWslVMNvp03SJ SHCG8lxpWUAqy0l0BahLrABBWqmzguvSj5v5rkG35soQVYT72+OKuqlOyVFutpWit/c9 yOAVquJXeJnc41av9wdG3ZdiVsWAYaVseXqQ54bVDQFC4f7FwcFXn4yqNFm14b4/Cc7+ preWmxufPRZDjxl02HsTdBkE/MdYJgVKyyUsS9pztJXU83mwKwHw09Oq3NtAUeveKAxF 4Ci548eVA2qAmAtmRJYenNpt2Ki6eU2mgbFolbaA6K7GBnKLCxKklaEJVxr5Y1z1/8nc Uf+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694502258; x=1695107058; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B30cQR4KsHwNvaeoC8Z4dw3bG2+oBb1t/+4IAjCtWX0=; b=hqkPC7QOwa1GH09SNy+CP2VkUPmtlGDcWY0OcZvh3Vv75PHneZdlJc4E8wIFGzneE9 bq3MDWtru7mnIfmQ1DGY/MD5vftGc1pwSbtO+agcnGPzjTCrGl/tlh51L5Ou0TbEI3JV +7lI13Ot9Pm+pBERAKDM+B2XpNfqPWDJFkIflwmd8nEPN3ZmUq8g+Sx0+BBZsXQjWk1y /PxM3XH4rWldDGLcvHBThJCTFv1Mip0yYpY6PzaCauCu+Sb/GGmgnXBpweVJ8c3UIy/0 mcrCEBqtaOOi/2xoxkGlG+Bhxn401P/Vma7n/iYcjdS88uQ8g+aF9iFULBgxwW0u0dx7 kDmQ== X-Gm-Message-State: AOJu0YzDloLA/zCyHMeurdrbnaBwLnmXAvZD5R6+Q0o0KduJFeURWrRT AuCCFbkAYV8SZEZ3znY7pqQR8hmDmztBVqbA5b2fZw== X-Received: by 2002:a25:7343:0:b0:d3f:208:b8ea with SMTP id o64-20020a257343000000b00d3f0208b8eamr10648403ybc.11.1694502258238; Tue, 12 Sep 2023 00:04:18 -0700 (PDT) MIME-Version: 1.0 References: <20230825101532.6624-1-m.kobuk@ispras.ru> In-Reply-To: <20230825101532.6624-1-m.kobuk@ispras.ru> From: Linus Walleij Date: Tue, 12 Sep 2023 09:04:07 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write To: Mikhail Kobuk Cc: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Alexey Khoroshilov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:04:38 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email On Fri, Aug 25, 2023 at 12:15=E2=80=AFPM Mikhail Kobuk = wrote: > Write into 'pctrl->gpio_bank' happens before the check for GPIO index > validity, so out of bounds write may happen. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450") > Signed-off-by: Mikhail Kobuk > Reviewed-by: Alexey Khoroshilov Patch applied for fixes. Yours, Linus Walleij