Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <080318bb-4237-b320-b775-3abcc09cb2ae@intel.com>
Date:   Mon, 11 Sep 2023 16:08:55 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH v9 0/9] x86/resctrl: Miscellaneous resctrl features
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230907235128.19120-1-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230907235128.19120-1-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXNCKzFxWnAxL3lHSGdvRlN1YS80U2VxdDhnU0pzMEZheEJKZ05hSE1OdXpR?=
 =?utf-8?B?Y2NSRGtldU02bGtTUy9paElvWldiM3ZUMGsrVEErSFJFNzErYVk0U2V4Mld2?=
 =?utf-8?B?T2V1L0lIY1BEQUpIaXZhZExIbDZySCtESDUrVW12Njd4ajRxWjIvSy9FUXNU?=
 =?utf-8?B?cUVpa00zNVF6ZElZMXMveFREZWpiUkhIQ1JxVHlXaHMzRnphWjU0d3YxWW1p?=
 =?utf-8?B?Qkg0aG9XVElmT1UyK2c2TXl2OXdpTXYzcm9lVFZoN05KRmxibWRncTVsSTVX?=
 =?utf-8?B?L3lkTFJuVkhLckZCaEQ0Tk9zSENGRk9YcDVVQ1FUU3dQTmNQL2E1RXdXSTcz?=
 =?utf-8?B?VkVEdUdDemNXM0tiTVJBRCtHVWRzLzAwajR4YnJUL1cyQkU0V0RBRTNnWDhq?=
 =?utf-8?B?bmF2SS9mRjkyc3FMT3VkbDd3cHIvemh3SlpIOE4wekFUcjh1MEJFbjQxdlJl?=
 =?utf-8?B?UUVqdnJTK3ljZDllVzhiMUZ0c0EwNEhBZVNPM0NIRGRVUG1XNTVBd1o2YXkx?=
 =?utf-8?B?TVpuQmo0c0hDek5FRVNWckczNWtDSjV4ZUhwMFVhZG9YdlBKakdPclpVY3ox?=
 =?utf-8?B?SzB5cWhZWnZMUmJESmtnMExyeHFKbW5IUWQwelhoUndRb0R3NmF4QURCZ041?=
 =?utf-8?B?d1lxcWlORVo0OGVOVXVZSDFiQ3J3M0Q1VmRpa3JrdWZQczJNUXBRUW1mL0Jm?=
 =?utf-8?B?Mlpad0FkNDRwTTJMcjc0bmw5NXN3RnRKazMrcVhUQ1FYQzFBS0pnQlZOTmQ0?=
 =?utf-8?B?aGZBV1IxckdXRE45SmcvdFF5a0JTUmhkNnFraExadXJadmpTMmVDVktOUWNs?=
 =?utf-8?B?MUdxTnRVdTVmVG1lOGo0c1hQdTdGelZlNmlSOUdhbjRnUnpyQ1phYzNyS2Vl?=
 =?utf-8?B?VHBBdjhrWE1tQkU0ZjJ6MHU2TFFTd0JrMXpSeHNVckMrbk82eExqV09KaHVt?=
 =?utf-8?B?Y3dMMm42TE9JQkxMR0swOS82dzNjVk5BQ3p5SEY0MWE0eE13cUZRVEpPS3Ev?=
 =?utf-8?B?MnYzeWczRktxRlJnazRpZlFWYTNzenFpbGFlWHgwSlRSRDlRUHMvUWdVMSta?=
 =?utf-8?B?Y1NoeHdTbk5FdTh0dk1UcC92TmE1dXh3eEs2UW0xNEkrMnVvWDJZVWZDcmtK?=
 =?utf-8?B?U2lZZzh5b21MTEpPN21GQnAzczFMOHpxMXJ6WjBsemkwYXNMMGRDSFZQMzI0?=
 =?utf-8?B?bGZobDA2ZnhGS3luRVlOajl1cmFoYjArY2R2MFVlZjRacXJkNnZIa1lSMmgx?=
 =?utf-8?B?TERyQVZjNXlWVG1YaENjYmFnMlFRREJzUUptMXh4YVpSSGtxcC9Tc2kwNFA4?=
 =?utf-8?B?TW1NblgvL0wzc0ljV3JLVDRwU2xONjl3V3gwVWFFOTFCd1B0VDdLTnFtbThp?=
 =?utf-8?B?UVlkVWswb2tudU93b1NDT0xjQXZXNjdOaXBnb1VWdzI4TUxrWVpMVjR3SjI4?=
 =?utf-8?B?RXNMa2Z1REUyQ0NKdlorTWlCNjczb21wb3BnQ0RKRGEwNHdGTWpLOVFteWRl?=
 =?utf-8?B?R3dNMjJmbk8xd3IwaWNndEFyWXRKaU5aSjJ3Snd2RDdLWXNXWFJEZVh6L3lR?=
 =?utf-8?B?U05PL0g5dE12K2d5RGdVLzQ3MEF1VU8zVmVra2t0REhoRnBYZUNRSjd2NGM3?=
 =?utf-8?B?SlY5ZEJQakZhdzJxY0lVVTk5TDdEMlNwbkZ1MjNVTWU2RHc4TFFMeTViZXB2?=
 =?utf-8?B?TGt2eTdqbkdRelBWR0NqdEtlR3pTY1R2U011czNOandSVnZleVFLL1NHc0RR?=
 =?utf-8?B?a2F2bFRJUDZsZkpMcFY3YnNQNzliVTNqRmZNeG4rRU9ZWGVPWjdvTFp6eGdt?=
 =?utf-8?B?QzBsZEJpaFR3OCtSRmo1RGd5c0F0Q2g5eGtlNlhTdnI5SCtrUmNGWTlXUUJC?=
 =?utf-8?B?MXlvSFlvVGc0Mm5STi9yN09MU2ozSzNLcXBnVUlaZ25taGw2YnRJZ0lReVN1?=
 =?utf-8?B?d0NKaUpZc0ZTM24yazZrTXB1THFBeWdNQ0xheEpsVk05SHE4SmtJNVZCcmQ5?=
 =?utf-8?B?SWJseGxuUzVVTXdNOXJGeTdUUVFIOFM1MGNyT05JRm90d2hGczQ1UHpwcFdk?=
 =?utf-8?B?Yjl5UmljaG8zcWVZajdLcVNTcWRyWGlWdVVhR256UlN3eHgwYndxYndCZEhO?=
 =?utf-8?B?cnhqN2FWMW9iNEthTnJhdWhTTHVEREVNNWVxbUgwTTBlaFpDMUFwUFIzRXBF?=
 =?utf-8?B?WEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fffe6ea-6dc4-4b2d-d7c9-08dbb31c14b3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2023 23:08:59.2168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9HChwb0qyQjMj3BVwviPwBVweGD9aYE5151TBppwz3pLxE2/GIMR5sYzwodehCp2ErTUL9r6aqVu20j9TFiXSJhuBBT7s+7nud7noNutmlc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5516
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:23:47 -0700 (PDT)

Hi Babu,

On 9/7/2023 4:51 PM, Babu Moger wrote:
> These series adds support few minor features.
> 1. Support assigning multiple tasks to control/mon groups in one command.
> 2. Add debug mount option for resctrl interface.
> 3. Add RMID and CLOSID in resctrl interface when mounted with debug option.
> 4. Moves the default control group creation during the mount instead of during init.
> 5. While doing these above changes, found that rftype flags needed some cleanup.
>    They were named inconsistently. Re-arranged them much more cleanly now and added
>    few comments. Hope it can help future additions.
> ---
> v9:
>    Changes since v8:
>    Split the RMID display in a separate patch. RMID is a special case here as it
>    should be printed only if monitoring is enabled.
>    Made rdtgroup_setup_root and rdtgroup_destroy_root as static functions.
>    Added code to print pid_str in case of task parse error.

fyi ... I found this version difficult to review. The cover letter contained this
high level list of changes while some patches were changed without getting a mention
here nor in patch-specific list of changes. I ended up needing to do a diff with the
previous version to get an idea of what actually changed.

Reinette