Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2454604rdb; Tue, 12 Sep 2023 02:18:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyWBa8XeNznUeSfAnAo6MZczFkYPG3fOj6qD1siq5hygxd7uLVoObqdrk+xHWXF0kx16yC X-Received: by 2002:a17:90b:a53:b0:26d:15dd:6702 with SMTP id gw19-20020a17090b0a5300b0026d15dd6702mr9837472pjb.5.1694510313381; Tue, 12 Sep 2023 02:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694510313; cv=none; d=google.com; s=arc-20160816; b=NjOG0ryOo8YC0U0TMi7VcBC7Ea0BaKL8ouwSDF0DtDJQbzTG16GlVECv85URZMYbu5 lz6vRLHIcKkF+YWxoN2y2cLxRrpriE7ku32Aw/Gxpd4TNtU+VzU9vVkq8HOZQXt93K2X w8goxGZmyoCH/CMXCYegoE7PhWEl0zq3tKXVz/BzqQBmwyjXyFOE5gEH7MpdRDiYM6xX gb7yufN05zwdprIMNaX1lS0vfgrUC8Z/0xs9h4NPKKmcTkGvqkTsrhLPiuD1QI6yfUXf e5GXzxowJwzeFBD0M7CSh/XmnDPb2fiBjhwv+OYN57EM6JHLWoGCBxCuS5rvM0rIEQVa n+Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=tghVFyIVhGX7gYPr6Xj0nI/BEuj6kidnkTNQDfpOQPI=; fh=2IG6/LU94i1r7FDgSC68QaeuPS5S0mC1UoGZe16CLik=; b=RaDuOuEiQZtWKPCUPoMFL04b6Jzc+xYmFhyo3Mc/4oB1BcC8O0YqytcOmSqeZTJ1m6 7TjxLkhAkIMhKB3hrXq6Cp5a1eEMGZ/jf90GF+EpBG/lEA/cQWUmYM38Jt6rmMczJ1mH F8Ji59Dhc8i3+EXBJUpNrYApjC0+TQuE24M0QCP4Lgkrk/HDVkU2aVcY3Zg1jKEJmJBr MoRNUM/iZ7kli3+VdMPEzrXwiJ/vcOo98uZto5Gysmh1DHUSSqbxFNkjA4CrICKDkHaW emY8Nz+TPlbBJcQUdk7jMJQO+6GzDImk/70+lYwtNejpOacJV1yYuI24LxD7IfAi1905 OuRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U9nCW5Zb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id qe9-20020a17090b4f8900b002680b23aff7si7973689pjb.161.2023.09.12.02.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 02:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U9nCW5Zb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 208698028F9D; Tue, 12 Sep 2023 01:16:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbjILIP5 (ORCPT + 99 others); Tue, 12 Sep 2023 04:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232578AbjILIPr (ORCPT ); Tue, 12 Sep 2023 04:15:47 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88B2B10C3 for ; Tue, 12 Sep 2023 01:15:43 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d78328bc2abso5008355276.2 for ; Tue, 12 Sep 2023 01:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694506542; x=1695111342; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tghVFyIVhGX7gYPr6Xj0nI/BEuj6kidnkTNQDfpOQPI=; b=U9nCW5ZbT8ShIHJFZi93YCEvs2CdMeYP2+a1cL715L/re+nSH1CO43I6hK0h5Y5d/e h9VO/B0dct4DrXiD6xvkg7MGCYQWNmHcfck9dqtnAWLctv3ACZfwdRo1vLxKm1voC+aJ w/hFIMpp47OW4w6XNZ8ErKG/bUE8tGgy5J/I5C4pcjVeTdRwkuDP81lHvqwkatisOTfU PzV2i4UI3q2W1J55oUABuhwraycdKejnPTIVmUMuy1TuTQEX4ZkaWphG+Xylcw+Oywik 4aj56Y02olVCRG0TolnLnlRBZ9MNPndwhqMTxW3MNzBplge/6QSvEuf15i1BI8kV2N/M jS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694506542; x=1695111342; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tghVFyIVhGX7gYPr6Xj0nI/BEuj6kidnkTNQDfpOQPI=; b=J+Aja/B8LD2zhwcA5FOzAkDGlx+j7eL1Lb2VYaE3eITCNbJlrSbTV6G5JT+m16c9wD YmbHMHrVguGeHwDS9eCAy1+cpBYpkmtE5xYI3w8CL88p2mDldatS6vMnybl0wKrOaCQy FXEt6JLmCSDLHt4mJW7llRgSlden1yWJWd5EcKqHaty+qAdfRJn4GLEduWP6MPf+y9ic yM+HidfIXoTOeMRlQ6Wf4BkihwBNSbw3iXg45tr1VdFxZAMdAJxjA+IcMC6chPYmlw6Z V5zDBFqe62hgzxal3rgD5dzQkQiJ8Ne3PukzHaK2Bs0tE8S2zpkEqnL2WKubkzSKNORE bDhA== X-Gm-Message-State: AOJu0Yy7LnfJxkMxhPW5l0saatSHTorhx1RzTq9/d1S379NV+1eDveQ7 XJCx8PMA+hwuEyzYBbNaJ2POGKRaS7BAA1uxEioX6Q== X-Received: by 2002:a25:aa69:0:b0:d7a:e0f6:54cc with SMTP id s96-20020a25aa69000000b00d7ae0f654ccmr11152715ybi.26.1694506542714; Tue, 12 Sep 2023 01:15:42 -0700 (PDT) MIME-Version: 1.0 References: <20230909063613.2867-1-jernej.skrabec@gmail.com> <20230909063613.2867-3-jernej.skrabec@gmail.com> In-Reply-To: <20230909063613.2867-3-jernej.skrabec@gmail.com> From: Linus Walleij Date: Tue, 12 Sep 2023 10:15:31 +0200 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request() To: Jernej Skrabec Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Sep 2023 01:16:15 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Hi Jenej, thanks for your patch! On Sat, Sep 9, 2023 at 8:36=E2=80=AFAM Jernej Skrabec wrote: > Use dev_err_probe() when printing error message in pin_request() since > it may fail with -EPROBE_DEFER. > > Signed-off-by: Jernej Skrabec (...) > if (status) > - dev_err(pctldev->dev, "pin-%d (%s) status %d\n", > - pin, owner, status); > + dev_err_probe(pctldev->dev, "pin-%d (%s) status %d\n", > + pin, owner, status); > > return status; That's not how you use dev_err_probe() Just replace all of the lines above with return dev_err_probe(...) Yours, Linus Walleij