Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Tue, 12 Sep 2023 13:35:27 +0300
From:   Andy Shevchenko <andy@kernel.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for
 &pdev->dev
Message-ID: <ZQA+716X8EVmIRAt@smile.fi.intel.com>
References: <20230912094519.22769-1-brgl@bgdev.pl>
 <20230912094519.22769-2-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230912094519.22769-2-brgl@bgdev.pl>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Sep 12, 2023 at 11:45:18AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Instead of dereferencing pdev everywhere, just store the address of the
> underlying struct device in a local variable.

...

> -	return devm_add_action_or_reset(&pdev->dev,
> -					sprd_eic_unregister_notifier,
> +	return devm_add_action_or_reset(dev, sprd_eic_unregister_notifier,
>  					&sprd_eic->irq_nb);

Ping-pong style detected: Lines added / modified by previous patch in the same
series got modified again.

If you look at how I do that, I introduce the temporary variable with my new
code and then reuse it later on.

OTOH, I see that the first one is supposed to be backported (?) in such case
perhaps it's fine.

-- 
With Best Regards,
Andy Shevchenko