Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 12 Sep 2023 13:42:00 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>
Cc:     "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Mpuaudiosw <Mpuaudiosw@nxp.com>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        LnxRevLi <LnxRevLi@nxp.com>, linux-imx <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Message-ID: <20230912114200.y626dyefwynbeytv@pengutronix.de>
References: <20230911224452.15739-1-iuliana.prodan@oss.nxp.com>
 <20230911224452.15739-3-iuliana.prodan@oss.nxp.com>
 <20230912113056.iyckw2j4sbg2brwr@pengutronix.de>
 <2d5f1ca5-0d09-399e-aa41-e43fcf444b8b@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2d5f1ca5-0d09-399e-aa41-e43fcf444b8b@nxp.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 23-09-12, Iuliana Prodan wrote:
> On 9/12/2023 2:30 PM, Marco Felsch wrote:
> > Hi Iuliana,
> > 
> > On 23-09-12, Iuliana Prodan (OSS) wrote:
> > > From: Iuliana Prodan <iuliana.prodan@nxp.com>
> > > 
> > > Add the reserve-memory nodes used by DSP when the rpmsg
> > > feature is enabled.
> > > These can be later used in a dsp node, like:
> > > dsp: dsp@3b6e8000 {
> > > 	compatible = "fsl,imx8mp-dsp";
> > > 	reg = <0x3b6e8000 0x88000>;
> > > 	mbox-names = "tx0", "rx0", "rxdb0";
> > > 	mboxes = <&mu2 2 0>, <&mu2 2 1>,
> > > 		<&mu2 3 0>, <&mu2 3 1>;
> > > 	memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> > > 		<&dsp_vdev0vring1>, <&dsp_reserved>;
> > > 	status = "okay";
> > > };
> > > 
> > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> > > ---
> > >   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
> > >   1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > index cc406bb338fe..eedc1921af62 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > @@ -210,6 +210,18 @@
> > >   		dsp_reserved: dsp@92400000 {
> > >   			reg = <0 0x92400000 0 0x2000000>;
> > >   			no-map;
> > This seems broken.
> 
> 
> You're right.
> Already answered to this here:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html

Sorry, saw it to late..

Regards,
  Marco