Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2531762rdb; Tue, 12 Sep 2023 05:07:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELoHnhOyD4prEeYDx+ndWPfRmdBwWijM38xrIt2dNisQlk/yLmNuT3VrBG6Lcj+bHJCbVj X-Received: by 2002:a05:6a00:80dc:b0:68f:c6f8:13f4 with SMTP id ei28-20020a056a0080dc00b0068fc6f813f4mr4131231pfb.3.1694520440634; Tue, 12 Sep 2023 05:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694520440; cv=none; d=google.com; s=arc-20160816; b=iq9e9jBNmv/nuUjin2WKLSlv0DZ89S9adU3uswz4AzhVk0qkHZUsPaAY2RbV70Urut GQoUsVR0gWRZCg5qcFPKX07fFRZawATUEjTjVojZL6wROFGwIIz5KzrJLosKDBY+5ytX UrUg9bzQoke9WrcpctnnC5nekDaOdQbbaCmuzYJR/8BMfr7PRTzdNaNrJiq07jijK2iV FOIas6I93T2h5eTaE6py+848pP2qI75IpgkgnKBWnN1BdUy68b3Qyy2WrgPtz/fVoNIM FJvUTYwf5lteuWhVB+4vm1H2mHu5DuylFvvkGQz+Fkbzq6yL4xCBXoIYCzUgpCnxiXQY bohw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=KwMsafzv2/ww22a5ZtZVea4KGSTzvTtFjtAmf8FNFHA=; fh=Z5F9RrhsFqTHabvV7u3l3nBgJD2kOck3l/ZvKFDFQcM=; b=ZKZ2rzFPA1C+yoHdUQh7rgBZogR9w1GMqwKNAmmbsdeaoKFfL6+sO1G/1ZJVQ51+uc c8GZovHNeDIa38BRUgXLJR9yibkHdkGcMaZ91vG2uQQv2k80GmTpymVg+HOF0c0XuTfQ 5PGg8YQ9I9gqDnEC4D6zZofuFGDC7bMWZorKHFshL4ngwmxPzFJs/r0xSLL74w8pyANz hlsNLHoRa8FkqSSaZPVNKgPyxy5lOTbOcT45rbNOkoS90h5j4++FowNCS4DPOagP49Of +GjJYAWQuI2/uZTAPWADR9xGrZ4YkcuXbFR0/20WbmFya3LkuhpFYZH2BjVjAy134eG1 inkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=MGtoudqr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id m1-20020a632601000000b0056417c8a310si7619216pgm.204.2023.09.12.05.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:07:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=MGtoudqr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C3B5280E6FD6; Tue, 12 Sep 2023 03:19:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234028AbjILKTt (ORCPT + 99 others); Tue, 12 Sep 2023 06:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234093AbjILKTh (ORCPT ); Tue, 12 Sep 2023 06:19:37 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA51910F5; Tue, 12 Sep 2023 03:19:12 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38C6Nr0J003422; Tue, 12 Sep 2023 10:18:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=KwMsafzv2/ww22a5ZtZVea4KGSTzvTtFjtAmf8FNFHA=; b=MGtoudqr2HnB7oYx1aHbaiURfOeUA+fyOy4OVpbRvAQuZG8g6oUWFH9W1r21Xy8TGWUR sFOKW6Dp7jieOXy+dZmxrXdfmkOwG6dQQsUr2VdG6wgLgIpj1D0sGaKzrj7q5rADWMGu REV4w4SlsnsLKHQh3PuU6VoY78DQjJJGbJsjKfNSa90vr6UlgLYTPi1PXZSXADz+vvvB yXDcM0xWH/jNUVkTS7FslN58nENwN61eTygOlZ+tW9OxjVISLt47VqecapoHeTizmcN6 st5xB9SyFq5j3ikzsbcG27NwECVEjqiGO82kAfO1AbZsuvckkV6LrY5vMB1ua8MVYTYo qA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t2c4c13s7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 10:18:58 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38CAIvxp017838 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 10:18:57 GMT Received: from hyd-lablnx450.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 12 Sep 2023 03:18:50 -0700 From: Bibek Kumar Patro To: , , , CC: , , , , , , , Bibek Kumar Patro Subject: [PATCH v3] mtd: rawnand: qcom: unmap dma address during probe failure Date: Tue, 12 Sep 2023 15:48:14 +0530 Message-ID: <20230912101814.7748-1-quic_bibekkum@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 0AINW3rV-Pxeyj1GY22MGfOhVn2BTYd8 X-Proofpoint-ORIG-GUID: 0AINW3rV-Pxeyj1GY22MGfOhVn2BTYd8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_07,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309120087 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 03:19:57 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Fix address argument of nand controller currently being passed to dma_unmap_resource() in probe error path. This address argument should be the dma address returned by dma_map_resource() instead of the physical address of nand controller. Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()") Signed-off-by: Bibek Kumar Patro --- v3: Incorporated comments from Miquel - Modified the commit message and title as per suggestions. v2: Incorporated comments from Pavan/Mani. https://lore.kernel.org/all/20230911133026.29868-1-quic_bibekkum@quicinc.com/ v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/ drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 64499c1b3603..b079605c84d3 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev) err_aon_clk: clk_disable_unprepare(nandc->core_clk); err_core_clk: - dma_unmap_resource(dev, res->start, resource_size(res), + dma_unmap_resource(dev, nandc->base_dma, resource_size(res), DMA_BIDIRECTIONAL, 0); return ret; } -- 2.17.1