Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 12 Sep 2023 13:41:50 +0100
Message-ID: <87jzsv4l81.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Magnus Damm <magnus.damm@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property
In-Reply-To: <CAMuHMdW_d5isU5Y2p6ne6_9j1-uqWnRY=Qw34SqR5EC0CndG+Q@mail.gmail.com>
References: <20220722151155.21100-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
        <20220722151155.21100-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
        <8735eqdbav.wl-maz@kernel.org>
        <CAMuHMdVj7J442iMr0PN5jxMhLv1U22+G9jNXLWFzLYkS0JTf5A@mail.gmail.com>
        <CAMuHMdW_d5isU5Y2p6ne6_9j1-uqWnRY=Qw34SqR5EC0CndG+Q@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 08 Sep 2023 10:31:35 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>=20
> Hi Marc,
>=20
> On Thu, Aug 11, 2022 at 4:50=E2=80=AFPM Geert Uytterhoeven <geert@linux-m=
68k.org> wrote:
> > On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <maz@kernel.org> wrote:
> > > On Fri, 22 Jul 2022 16:11:54 +0100,
> > > Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > >
> > > > Update description for '#interrupt-cells' property to utilize the
> > > > RZG2L_{NMI,IRQX} for the first cell defined in the
> > > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.c=
om>
> > > > ---
> > > > v3:
> > > > * New patch
> >
> > > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesa=
s,rzg2l-irqc.yaml
> > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesa=
s,rzg2l-irqc.yaml
> > > > @@ -31,8 +31,9 @@ properties:
> > > >        - const: renesas,rzg2l-irqc
> > > >
> > > >    '#interrupt-cells':
> > > > -    description: The first cell should contain external interrupt =
number (IRQ0-7) and the
> > > > -                 second cell is used to specify the flag.
> > > > +    description: The first cell should contain a macro RZG2L_{NMI,=
IRQX} included in the
> > > > +                 include/dt-bindings/interrupt-controller/irqc-rzg=
2l.h and the second
> > > > +                 cell is used to specify the flag.
> > >
> > > I think a binding should be self describing, and not rely on an opaque
> > > macro. Mentioning that there is a macro that encodes it is fine, but
> > > the values are what matter, specially when considering that other OSs
> > > could (and should be able to) write their own DTs from scratch without
> > > depending on something that is very much Linux-specific.
> >
> > The macros are not Linux-specific, and are part of the bindings.
> > But the only hard dependency on <dt-bindings/interrupt-controller/irqc-=
rzg2l.h>
> > is the DT source file describing the board.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>=20
> Looks like this fell through the cracks?
> The two other patches from this series were applied in v6.1.
>=20
> Note that the current DT bindings are incorrect, as they do not take into
> account that the value of zero is used to represent the NMI.
>=20
> Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add
> Renesas RZ/G2L Interrupt Controller")
>=20
> Should we resend instead?

It applied cleanly to v6.6-rc1, so there should be no need.

Thanks,

	M.

--=20
Without deviation from the norm, progress is not possible.