Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <2d5f1ca5-0d09-399e-aa41-e43fcf444b8b@nxp.com>
Date:   Tue, 12 Sep 2023 14:33:54 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Content-Language: en-US
To:     Marco Felsch <m.felsch@pengutronix.de>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Mpuaudiosw <Mpuaudiosw@nxp.com>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        LnxRevLi <LnxRevLi@nxp.com>, linux-imx <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org
References: <20230911224452.15739-1-iuliana.prodan@oss.nxp.com>
 <20230911224452.15739-3-iuliana.prodan@oss.nxp.com>
 <20230912113056.iyckw2j4sbg2brwr@pengutronix.de>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20230912113056.iyckw2j4sbg2brwr@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWpOUW82SEdHeVYzcnd1L3ljSFFJQXI5VFR1T1U2K1o3NndBZGd4SVRyQ2tq?=
 =?utf-8?B?RlNjLzY1dXdGUHdKQjA3SEc3dmdnd0N2TktxcFNSZmNRTmwvOHRpeFRLL1Ni?=
 =?utf-8?B?eFJuTFpjNGJnMEpXNWdHT294M2dxa29lVi9qcUdzVkNhM2FBTmVQdlZKSnJu?=
 =?utf-8?B?MzZzRGlYdnRsOHFiUTFlOEhLOWg3NmpmbHk5QVE2NmJaNDgyOUMyd09uYjVr?=
 =?utf-8?B?ejlHVnpjMlJ3RDFCYzAraXp1eGtGbHcwMVdzNjRacDN1bzhrWXljSjJTMk1o?=
 =?utf-8?B?V1JjNEVXSjE1QWNYeGtKZ3EzZ3JlZjhFRGxwMjVJSkZzQzRmQWdUdWhpbHI1?=
 =?utf-8?B?cWxRV0RaYkRqZER1TXVTeCtzUVJNb1huTko1WUtaSmNZcmkxT25IUCtSNkNk?=
 =?utf-8?B?c3VURlNCTC96Z1RPSndnTFJqbEd4YU4vaXkyQVZ1ZnNkN0svcWtkY2hwN0tI?=
 =?utf-8?B?MllCSk1TMUtjdVhTM2dLcU9zdUFOTU45eVFEVTJFYnNFVlduaHlMc2pNR3Z3?=
 =?utf-8?B?eGVzWHh2b0JQcTVlZ1VBNEYxVlBiVnhsTkNHMExpNTVYMjlwVldxVHE2OGUv?=
 =?utf-8?B?WXNlZkpkVnhQN1B5dG5Ga0tkRE9GbTlkeE1wdmtoc21KQlY1U3F6cnRwZkhR?=
 =?utf-8?B?NGJkVlZ6MUhyN284bzNPZXZGRndTTmVxNkhjR1VKWnROUkx4UXQ4eEx0ek1v?=
 =?utf-8?B?T3JaQlY1SDkwN2JPZTV5dUVvdUtBNHhwMFluZFhjZEpISzRYbWQxN2V0a2J5?=
 =?utf-8?B?azlOdmJVQktKd1JxRlF0SGJDOE5rZ2xqTjNMbHFsMWE4WmYyTTJFUVF1RDBu?=
 =?utf-8?B?aUczVVIzbHd2Y3ZNMVhBbGU1VWpZYXpDZTNpKzl5M0VKMnJWUmc1WTFtU2tZ?=
 =?utf-8?B?UE5zcStsYU1ScnRWQWMyQ2ZGN2pHTHN0Y21CdzEvazlJTjlQN2ZMU2Rva2RL?=
 =?utf-8?B?U2oySTBGWElqR2E3S2pCQzV3Yk1WZnRnUUhIWGpjWmp4MTZsRWlIc2gvcS9L?=
 =?utf-8?B?dzhJYktGdVllZXNwM0ZqMnN3bldwd29zbnUraVRWang5VmZCMitmbVhMTmtN?=
 =?utf-8?B?SUsvOUQ0S1NTSFVKd3BlbEtjTnJaV1FkU3cyeDhnWGUwTXJVUEx3UjlFU3c2?=
 =?utf-8?B?Q2FIaDAwY3dzeFd1OFgrSUFCQUk0RFlKcXNFM2hDT1laZXdIWUtnYzZZY2d6?=
 =?utf-8?B?cEZXMldmbDAyV2REM1EyV2diVWl0RUVjSzNkc1FKR0FYcVMwL1JoWGo5TE8w?=
 =?utf-8?B?TWxEQnVvYStHNnd3YlVHeDI5VFpHbzRYSWh3YXBVZldGY3g5V2R0RnFzV0JR?=
 =?utf-8?B?LzJtektYTnZuZUlweDRCUG9YRzZwM0w5Y0FFUytTZHloNndqUDUzOEZMRXdI?=
 =?utf-8?B?TitvUVJnd3JpeTl6VjdYL20vOC9rYnhva21PMG9HN01BOU11SkN5V0wxL2d1?=
 =?utf-8?B?eVVZRnJRSFpUS3JoZnVEbDA2ZkdMSE1pVkZwb0RnTUx3TFVMb0ptYUk5eERC?=
 =?utf-8?B?ZkVIWkM3RkEzbzYwSzZrekRYQ1lZQndKN1RJeS9Ib3JuUWQ5Q2hYRjhkNzds?=
 =?utf-8?B?YnhJajZmbUdqRmlYT2dXWEtQY0hTby9sU293RmZpQ1hUbHdqbXR2S0VZOEpC?=
 =?utf-8?B?VU12dnErZGIveThydkx5b2Z1cDF4OVV2UFdLeGdGSFJuV0FhVGhYM0tnYUhI?=
 =?utf-8?B?U1k2M2NwVXYwUlVldkFKUGJuOGNhNUhiYStSS1lxVEcxMWxJV1lVcXpUam5F?=
 =?utf-8?B?anhzcDhCQ0pRVTBqeTJkNG1VU0hORlhHSkFqTVYva0NQRGEvMUFyaHl5RWFa?=
 =?utf-8?B?VGJ1bG5Semtpd05RYmd4ckozV0svOG5qVzNPdG90UWF4VVZoUFFGcjBFRU9k?=
 =?utf-8?B?TlBQUXFUR0c5UHZvakMrci9jcnd6N3hwNXdxK2tGREtkb3ZRSFBUOVRVc1ZU?=
 =?utf-8?B?R0xnamNvNWJVaHlJU0RNZHJOM1hTcCt0WmgxbTNrOUdqaHNZeCswV2ZLalNP?=
 =?utf-8?B?M0NaYVJHcWl1ckJvMmJCdmJIVmREY2RKaktUQkFmUUtnVFlaYVRIWXQ4MXl0?=
 =?utf-8?B?eHgyQlhJaDFPUGFkTFN4VWgwRXZ2MnJnb2ZlQ0lYMnRobktmQUxKNHU2elJR?=
 =?utf-8?B?cExXTWdXQmpiVUxRZjZ0Mm8wL09VSk1aM25aMDExYW5IK1lwVEE2ZksyRm5j?=
 =?utf-8?B?anc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05869b06-5d3a-47af-9fff-08dbb38426cb
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 11:33:57.2376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RcfAuoTB4ogWYaEuuDll9i3HYfJdG4zloKxnfV1mArJeI63+ZhHDCaYmBCdtcyRiOGZr4Z4imwDKl6Jd2RQNHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9811
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 04:35:05 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

On 9/12/2023 2:30 PM, Marco Felsch wrote:
> Hi Iuliana,
>
> On 23-09-12, Iuliana Prodan (OSS) wrote:
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> Add the reserve-memory nodes used by DSP when the rpmsg
>> feature is enabled.
>> These can be later used in a dsp node, like:
>> dsp: dsp@3b6e8000 {
>> 	compatible = "fsl,imx8mp-dsp";
>> 	reg = <0x3b6e8000 0x88000>;
>> 	mbox-names = "tx0", "rx0", "rxdb0";
>> 	mboxes = <&mu2 2 0>, <&mu2 2 1>,
>> 		<&mu2 3 0>, <&mu2 3 1>;
>> 	memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
>> 		<&dsp_vdev0vring1>, <&dsp_reserved>;
>> 	status = "okay";
>> };
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> index cc406bb338fe..eedc1921af62 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> @@ -210,6 +210,18 @@
>>   		dsp_reserved: dsp@92400000 {
>>   			reg = <0 0x92400000 0 0x2000000>;
>>   			no-map;
> This seems broken.


You're right.
Already answered to this here: 
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html

Thanks,
Iulia

> Regards,
>    Marco
>
>> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
>> +			reg = <0 0x942f0000 0 0x8000>;
>> +			no-map;
>> +		};
>> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
>> +			reg = <0 0x942f8000 0 0x8000>;
>> +			no-map;
>> +		};
>> +		dsp_vdev0buffer: vdev0buffer@94300000 {
>> +			compatible = "shared-dma-pool";
>> +			reg = <0 0x94300000 0 0x100000>;
>> +			no-map;
>>   		};
>>   	};
>>   
>> -- 
>> 2.17.1
>>
>>
>>