Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756137AbXKFI5Y (ORCPT ); Tue, 6 Nov 2007 03:57:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753465AbXKFI5Q (ORCPT ); Tue, 6 Nov 2007 03:57:16 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:33324 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751929AbXKFI5P (ORCPT ); Tue, 6 Nov 2007 03:57:15 -0500 Date: Tue, 6 Nov 2007 09:56:51 +0100 From: Adrian Bunk To: Kyle Moffett Cc: "Ahmed S. Darwish" , Casey Schaufler , akpm@osdl.org, torvalds@osdl.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser Message-ID: <20071106085651.GC26163@stusta.de> References: <472B8DAF.9080706@schaufler-ca.com> <20071103164303.GA26707@ubuntu> <20071106063305.GA26163@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 41 On Tue, Nov 06, 2007 at 03:26:12AM -0500, Kyle Moffett wrote: > On Nov 06, 2007, at 01:33:05, Adrian Bunk wrote: >> Can you limit this to 7bit ASCII and use isascii() somewhere? >> >> Otherwise I'd expect funny things to happen when you e.g. use isspace() on >> the UTF-8 encoded character à. > > Actually, you don't need to. You tell them it expects UTF-8 encoded > strings and be done with it. All US-ASCII characters from 0 through 127 > (IE: high bit clear) are exactly the same in UTF-8, and UTF-8 special > characters have the high bit set in all bytes. Therefore you just assume > that anything with the high bit set is part of a word and you can handle > basic UTF-8. (It doesn't work on special UTF-8 space characters like > nonbreaking space and similar, but handling those is significantly more > complicated). The documentations says: "Smack labels cannot contain unprintable characters or the "/" (slash) character." What you propose might contain unprintable characters, and it might even be invalid UTF-8. > Cheers, > Kyle Moffett cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/