Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20230830134241.506464-1-keguang.zhang@gmail.com>
 <20230830134241.506464-4-keguang.zhang@gmail.com> <c94138d2-1bfa-2815-a766-b7904e35a86f@linaro.org>
In-Reply-To: <c94138d2-1bfa-2815-a766-b7904e35a86f@linaro.org>
From:   Keguang Zhang <keguang.zhang@gmail.com>
Date:   Tue, 12 Sep 2023 10:01:29 +0800
Message-ID: <CAJhJPsV6BomVsZRYHNwvVzWJCWzssfcHzWBwGdYZ5Csh2oaoow@mail.gmail.com>
Subject: Re: [PATCH v4 3/4] net: stmmac: Add glue layer for Loongson-1 SoC
To:     =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@linaro.org>
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 11, 2023 at 6:48=E2=80=AFPM Philippe Mathieu-Daud=C3=A9
<philmd@linaro.org> wrote:
>
> On 30/8/23 15:42, Keguang Zhang wrote:
> > This glue driver is created based on the arch-code
> > implemented earlier with the platform-specific settings.
> >
> > Use syscon for SYSCON register access.
> >
> > Partially based on the previous work by Serge Semin.
> >
> > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> > ---
> > V3 -> V4: Drop ls1x_dwmac_syscon definition and its instances
> >            Drop three redundant fields from the ls1x_dwmac structure
> >            Drop the ls1x_dwmac_init() method.
> >            Some minor improvements
> > V2 -> V3: Determine the device ID by physical
> >            base address(suggested by Serge Semin)
> >            Use regmap instead of regmap fields
> >            Use syscon_regmap_lookup_by_phandle()
> >            Some minor fixes
> > V1 -> V2: Fix the build errors due to CONFIG_OF being unset
> >            Change struct reg_field definitions to const
> >            Rename the syscon property to "loongson,dwmac-syscon"
> >            Add MII PHY mode for LS1C
> >
> >   drivers/net/ethernet/stmicro/stmmac/Kconfig   |  11 +
> >   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
> >   .../ethernet/stmicro/stmmac/dwmac-loongson1.c | 219 +++++++++++++++++=
+
> >   3 files changed, 231 insertions(+)
> >   create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson=
1.c
>
> Squash:
>
> -- >8 --
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ff1f273b4f36..2519d06b5aab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14344,9 +14344,12 @@ MIPS/LOONGSON1 ARCHITECTURE
>   M:    Keguang Zhang <keguang.zhang@gmail.com>
>   L:    linux-mips@vger.kernel.org
>   S:    Maintained
>   F:    Documentation/devicetree/bindings/*/loongson,ls1x-*.yaml
>   F:    Documentation/devicetree/bindings/net/loongson,ls1*.yaml
>   F:    arch/mips/include/asm/mach-loongson32/
>   F:    arch/mips/loongson32/
>   F:    drivers/*/*loongson1*
> +F:     drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
> ---

Will do.
Thanks!

--=20
Best regards,

Keguang Zhang