Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <453bd95c-932d-c60a-bd7b-96f87bc7779a@amd.com>
Date:   Tue, 12 Sep 2023 14:41:56 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v8 0/6] perf record: Track sideband events for all CPUs
 when tracing selected CPUs
To:     Yang Jihong <yangjihong1@huawei.com>, acme@kernel.org
References: <20230904023340.12707-1-yangjihong1@huawei.com>
Content-Language: en-US
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        kan.liang@linux.intel.com, james.clark@arm.com,
        tmricht@linux.ibm.com, ak@linux.intel.com,
        anshuman.khandual@arm.com, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230904023340.12707-1-yangjihong1@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDdpK29kRkloUkR2blk2M3QxamNqMDcwZDlmeWVtVkJHRCtGdjN0V3luTjFh?=
 =?utf-8?B?THVyYk5PNnVaZWpjRlVUQlNQNVE3U2MzSnM0aXpDY1FZYVN4TTM4SUZ0N1N2?=
 =?utf-8?B?SGNmQmRnRHF1SHlGTlFTYjIrV3pjY0V3UXo0Njd0Nmo3bzNsa2xwcjVQVm9V?=
 =?utf-8?B?YjlKZ2U2aHJjSGFzMjRta3FmVjQzbHRIMWQ1WlpqN0RzUkhNdnFSK1YxRnN1?=
 =?utf-8?B?cUt6bXRDMFh1aHJ0bGNHZU9JY0hUdWdIVkhxTEJtaTVPdW5KWk1TY0lNdXk1?=
 =?utf-8?B?Z1EwSHArQ2N3UGNpcVAwVlZQSGxJbTVqNGxIRUErUU93M3Y1ZWpobU9BTlZC?=
 =?utf-8?B?NTJIUWlUMlBBVTdSNEhuV05DY1pqMUQ3eksrQkZ2MWxKcDhsTTNnNjlmcloy?=
 =?utf-8?B?Yi9DSkhiMk9yUSt1TUdVL21OMlBkQzZRY01HbUJUMy9WWDBwRWNVd21uYm5K?=
 =?utf-8?B?cXB1elhyUWV6OXQ4bXdzV3NZSVZLaDN0TVJKeDBYMVR1M1c0aDM2N2VUUDRw?=
 =?utf-8?B?Z01zMjhoTEJsdWUxeVFYSngwZGxZOG1RYWxOYjkrTmRXRlZwT0RLS1YxN01m?=
 =?utf-8?B?dG41bUx1S2pVaDc1aXVYSkdGQ1NMMDBZWEJQOG1HVzRtUFduUzFKRVM1MjNG?=
 =?utf-8?B?QUlmQU1sb2MvRUtQQjhqOVpJbGhpTUdqdWJON1JBeWxQVmpkU3FQV2UrNlox?=
 =?utf-8?B?MHFLckZxQUtJenhZRXN4aFBaYXJJem9yNmV6bG4zVklML2p3TzBmYWVoNzIz?=
 =?utf-8?B?dWR1R2JPa2FxODQ0aTZXclgvWjZqakxDSTI2bXNjQk10cVBMaTRqalVuaVhR?=
 =?utf-8?B?MzZUTkJFYm5SR2s3b2JQeHpFWW8xWElzWjNjalhrVW1RQ3pjYU9ncTJwWUJn?=
 =?utf-8?B?a2loaXBkR3VOSU1XWE1LZHVHblgxaE1EOGhqME1GU3djNFZOWlB0dDk4bzEx?=
 =?utf-8?B?U211cE9SVlBWNTVTczdacE4yQ3N2eTkzbXFvcTYzQmNSV3lmb0lyWWVIRWE2?=
 =?utf-8?B?UFY2K1dFNnNWYlF1cVMxbXg5bUxSRzZJTi9NZkhERkdMbTNUVzFRaGJLNHdW?=
 =?utf-8?B?MnRyd0tLRlFWOURNMmljUy9IVytpVE9uTXJvNHR1by9ZUG1GQ2h6d1NSejFE?=
 =?utf-8?B?T0RoOXcycjNGSXQxbzYxcmNTdjBoSDFxaW4ycE1rVUdqbnl2dmtWSnFLbk44?=
 =?utf-8?B?Mm81TSs0NUlteFM4UGNEMkRKZ3dKbmlHbVRyVnRwZkhwdW5ELy9tQzV6L0Nz?=
 =?utf-8?B?dTZiL20wSHM2aFpiTXQxRFJySTc0aHNScGptV05nS3ZQNzJWT24rL3E3Ui81?=
 =?utf-8?B?WWp4TDZ1YWpxRk1pZU9URVNzNjV3UHNHbmJCcCtOUTlhR0hhNUZxVmd3bXZH?=
 =?utf-8?B?QVgyVXUzUDlCQk5YR3NBeVplQURIcWIxV2xBaEZ3bkVCNFJRaDdQWEtGTGEr?=
 =?utf-8?B?VTBVNEVlUGJQQ012R3JPVmlRZGVzK1Q3NFJxajZrT1Y2ZkZMaytvNXp6cC9y?=
 =?utf-8?B?SmtoUGRzRW5QSktEWm9Va0E4YVo2aHB5Y0dUM0RPNEgwbk9UN3hySU1WRE5M?=
 =?utf-8?B?VXg1RG5tbHVMa083ZU1mT1VrOXVRODBKRWVvdGpoNVVXVExIL1hoc0pNeVdQ?=
 =?utf-8?B?QW05OE1mTTNaN2pZSGNlZ1I1S3prVkgydVU1NzAwbmp1cnZqRXhtU0pHNFBw?=
 =?utf-8?B?aW1QOHlBeHdjWHBNSklCdE9hbk9kQ1JMOUY0WFE5a1NscTlaQ0U5czQ5aWZv?=
 =?utf-8?B?YXlVV0IydnJ2bnpVN3RSVGtpZGFtaFBwTjZ6elZGeER3SjM5YVdFSDR6bEJj?=
 =?utf-8?B?WXFTUmxkenlVU1BIWkIxOWEwOFA1a3psMXpibkFldUowRG10WHdCS1dYWmxt?=
 =?utf-8?B?bzFhby8rQW1SNFh6dTFkZEZyY0FXUFFmbk5TV2UrVVdvUzUxQjQ5Myt3WUVu?=
 =?utf-8?B?K2N2TUwzUUtBcTIwaVArbzBtck1MOElGRGFxZnpuVS9LY09sdHQ2alJmVGJi?=
 =?utf-8?B?czV6NVQ1b1BUUE9UcWR2bnBia1VQZzlocHYzS0dmMitmV3NkQnRFeDRLOVJn?=
 =?utf-8?B?TDA4NkVCbHlKbkxXRXhtNTJRRmVqdjFJeVVoWjdCcHFBMWhxRUFwQXhLTlg1?=
 =?utf-8?Q?ty2RPVKFz4h+lEF9i4AwwCFDn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30642c5e-42f5-4750-e9bd-08dbb3705a72
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 09:12:14.2116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MgzjKlA6dEbtxt9pAisVuncnl/Z+Gq9bycc4Ps5RWVCAcJUM4050QuO6COt86jD3UZCrMtWP6GBR+qChL0HTUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8532
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 02:12:28 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

On 04-Sep-23 8:03 AM, Yang Jihong wrote:
> User space tasks can migrate between CPUs, track sideband events for all
> CPUs.
> 
> The specific scenarios are as follows:
> 
>          CPU0                                 CPU1
>   perf record -C 0 start
>                               taskA starts to be created and executed
>                                 -> PERF_RECORD_COMM and PERF_RECORD_MMAP
>                                    events only deliver to CPU1
>                               ......
>                                 |
>                           migrate to CPU0
>                                 |
>   Running on CPU0    <----------/
>   ...
> 
>   perf record -C 0 stop
> 
> Now perf samples the PC of taskA. However, perf does not record the
> PERF_RECORD_COMM and PERF_RECORD_COMM events of taskA.
> Therefore, the comm and symbols of taskA cannot be parsed.
> 
> The sys_perf_event_open invoked is as follows:
> 
>   # perf --debug verbose=3 record -e cpu-clock -C 1 true
>   <SNIP>
>   Opening: cpu-clock
>   ------------------------------------------------------------
>   perf_event_attr:
>     type                             1 (PERF_TYPE_SOFTWARE)
>     size                             136
>     config                           0 (PERF_COUNT_SW_CPU_CLOCK)
>     { sample_period, sample_freq }   4000
>     sample_type                      IP|TID|TIME|CPU|PERIOD|IDENTIFIER
>     read_format                      ID|LOST
>     disabled                         1
>     inherit                          1
>     freq                             1
>     sample_id_all                    1
>     exclude_guest                    1
>   ------------------------------------------------------------
>   sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0x8 = 5
>   Opening: dummy:u
>   ------------------------------------------------------------
>   perf_event_attr:
>     type                             1 (PERF_TYPE_SOFTWARE)
>     size                             136
>     config                           0x9 (PERF_COUNT_SW_DUMMY)
>     { sample_period, sample_freq }   1
>     sample_type                      IP|TID|TIME|CPU|IDENTIFIER
>     read_format                      ID|LOST
>     inherit                          1
>     exclude_kernel                   1
>     exclude_hv                       1
>     mmap                             1
>     comm                             1
>     task                             1
>     sample_id_all                    1
>     exclude_guest                    1
>     mmap2                            1
>     comm_exec                        1
>     ksymbol                          1
>     bpf_event                        1
>   ------------------------------------------------------------
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 6
>   sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0x8 = 7
>   sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0x8 = 9
>   sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0x8 = 10
>   sys_perf_event_open: pid -1  cpu 4  group_fd -1  flags 0x8 = 11
>   sys_perf_event_open: pid -1  cpu 5  group_fd -1  flags 0x8 = 12
>   sys_perf_event_open: pid -1  cpu 6  group_fd -1  flags 0x8 = 13
>   sys_perf_event_open: pid -1  cpu 7  group_fd -1  flags 0x8 = 14
>   <SNIP>
> 
> Changes since_v7:
>  - The condition for requiring system_wide sideband is changed to
>    "as long as a non-dummy event exists" (patch4).
>  - Modify the corresponding test case to record only dummy event (patch6).
>  - Thanks to tested-by tag from Ravi, but because the solution is modified,
>    the tested-by tag of Ravi is not added to this version.

I've re-tested v8 with my simple test.

Tested-by: Ravi Bangoria <ravi.bangoria@amd.com>