Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Oliver Sang <oliver.sang@intel.com>
CC:     "oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
        kernel test robot <lkp@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        "ying.huang@intel.com" <ying.huang@intel.com>,
        "feng.tang@intel.com" <feng.tang@intel.com>,
        "fengwei.yin@intel.com" <fengwei.yin@intel.com>
Subject: Re: [linus:master] [shmem]  a2e459555c:  aim9.disk_src.ops_per_sec
 -19.0% regression
Thread-Topic: [linus:master] [shmem]  a2e459555c:  aim9.disk_src.ops_per_sec
 -19.0% regression
Thread-Index: AQHZ4hUlovnTGopJRkWINRJx8jG2QrARAWsAgAVqhYCAAMJWAA==
Date:   Tue, 12 Sep 2023 13:01:29 +0000
Message-ID: <84984801-F885-4739-B4B3-DE8DE4ABE378@oracle.com>
References: <202309081306.3ecb3734-oliver.sang@intel.com>
 <C85F44FD-BC7D-421B-9585-C5FDFAEA9400@oracle.com>
 <ZP++GV9WURg1GhoY@xsang-OptiPlex-9020>
In-Reply-To: <ZP++GV9WURg1GhoY@xsang-OptiPlex-9020>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YpGIIwJLJ2m7qlq3ZfE3QAnMcL5Njy5q/06VHp7AqM19BT/REZhSS0+Uar8e?=
 =?us-ascii?Q?kiiDHZpOu67qr+zYQqIQOdx9PcFSgEpBn0svTre/lYYiNm707b+SKCxI39mw?=
 =?us-ascii?Q?L8MuXX2dSN40y6aISyPXQaej6YUzGe+/OusV/U2xKRLppo85KL77MSk/EbPI?=
 =?us-ascii?Q?3kYXtb5gU9CtvIkQa0ZA1Sfc+gpflDoboJlCpOVvsNUzjMsSkcxv5LLf6Zzo?=
 =?us-ascii?Q?lYnkBoe9EV3Gkh41aWPIoKHn5qOpyyd49fTVjqDYAEKfzP97c92pKvgFalEs?=
 =?us-ascii?Q?3yaWgQ7E8kur4NvP0SpzLU+fxFtI4TuD5O+wjQpUoGydfEiEJkdPoq7x6YnF?=
 =?us-ascii?Q?fwqy/qBoN5O5hEVs+DxUnR1Vo/LBFTSseHWX7Sz05TgAxzEQ/zYzSA2jDM6D?=
 =?us-ascii?Q?AssiQhMXLgEh5HcJFL1AjyT8Zi9pTrMqfMgp/Paxa3JtGyfFZoJrvIpeqVjZ?=
 =?us-ascii?Q?XJlexg8nid0GXHMpm+AlqWmf+335AZeVSiDNwHsOVseYf5GXQ0O9rRa6dy2A?=
 =?us-ascii?Q?oN4UVKcsJxmUhVax9GN/zU1bOpobjjbARnaeRjLXPxTVjaBiidlFwGKChWrb?=
 =?us-ascii?Q?n5zhv/Xo7KQGXhjIKDC29RtxXuVXKXvYQApG1ws0KAjkqpxUSZI6H4ttGp76?=
 =?us-ascii?Q?ihivuQLkE23nudYldeZiMxPkiCz1WaGBr10UB4pP3mB8Oe7Amj8YS7z54jla?=
 =?us-ascii?Q?BaCoBOJScfA6W5YyzIUOIdVmKFyC4cTdgaIZIL70J2z7x+F17YaF/5vbIFJm?=
 =?us-ascii?Q?Scugznp/ezWZqpcogO3MSUnlFrHht+GO5YQPZdlY31obg1CL869SMfOKwl6S?=
 =?us-ascii?Q?0E1StlFp0cqGFJ/1X8p5EA7IUVLpfpQm8oYEG57QGg7XqAPv4ESm+tkmlwQg?=
 =?us-ascii?Q?wsK95I/aB6RqS3+LH8+FMJo7agneXmJrBb4A2GHyxOe1VCBwRXbvgy1tpM0p?=
 =?us-ascii?Q?S/2yUV2mkDja7GeUMrT4ba9KzbvhooTIACM/c0WtnBf0Q7UkdideLO400mEn?=
 =?us-ascii?Q?OwJBqMBPpg6s9uyetv+ihWgwo+thYuPen1jPDyYVTTEzctGlFern2TnRhD/U?=
 =?us-ascii?Q?TAbV26EltdmWnOny4xkhBJAjdwX9pGmy5Ud/VNNv4O4PgyaenouTwOPZIIA9?=
 =?us-ascii?Q?Ds2Heyn0CWmj4KhBsgzCdZrZ+9jh6IpLrtkQ8sE1r47wAqBrUB1+ztUPXTCZ?=
 =?us-ascii?Q?WhWyE4dn7akpeMxzM6Ggu3DvB4ULox74qnwEDRxbU9U0UDcLZ0No8kRDnd10?=
 =?us-ascii?Q?xg3NSKN1Pv72U/C+8vGZ7ShUusHle9avhIxNcXkKOnsYDzlgEjVnRjR4INrc?=
 =?us-ascii?Q?7XbnesFfxWFlsdnqTlyBqVNyub+D1I0ObTOt/RwZ15n+gQ6vcRH0FiSo/M8h?=
 =?us-ascii?Q?b2VoNBJDkPfSSbYEpWsMVm6JmCGyG0JpgMAI0R9/vYFhYj++Otb5zHvHTpnr?=
 =?us-ascii?Q?r4q0ZBFH2ITlSYAY+icihcv+Facql+BmMmB5XW/0exKHSt3MciE56KuhTlUI?=
 =?us-ascii?Q?9L+IbMG5XzUUNTnXx8f34ScgadQIH3l1SNpnFhaDZZjMv5nY0bmdiVmXh66C?=
 =?us-ascii?Q?dogNGNupImG92BxC2TPiRz0MWK+zjG6ULD5TfwFtvSc6Dxn4+Y5cnj49EMRf?=
 =?us-ascii?Q?tg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87A60FE27CA00643B1D77E323CEE66D7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hmvMY3prel5FvLzCx7PqeR80E1yY/wwesCp/iqH5YG8+h5zusDIeDJp+UCGYZ5d8QLGQLAADTm6Z0xvSm6c4iKrlqUA1I8X/DvCoVNUsT5d/f42udMAGN3uJAUKHQGz6b1o2z+UWOb+vi0nUiz1YXzpAiu+zud0y0wtkw0jVcAOVO87jP4kQ3b0CGNKX8OBlGp+dDTb77uI2B5w375iDFqRCXdZjX++N+WT+DS40P8p4ge5ZZqUVW26NncIFF4FGGdFVuEFbyRWgvDaGX4qbb0TCsEIYST0FuIe8S80lPp466ldl5fWLBO3jd0Z5Bw04bHZLoHE7E/YlOo9MStNbO/RYS7HvdXe4Dak4lOSuw9yNAVJoplyxEAu/ajY/F65YTJU0ZKJG1iZBRfLopHSwNWfWCWkK9bwB+yiD55hqmbfuIHbueYtQLTVH95a0VfDgDHJgPavd7dKlf992hGoiQ7LaU0s24FfMcy+3Ndx+hsHkF/VrfYgm5Ew8JjVnxiVxjLOBGQuE0sk7ioBj3UItPLQBD9LKJ4UfFA9QBcdxRPpzExFzOwHlYzr/hfW8mNQgyTX2XgGlYtCBzbMoFTjxh8SaEbcsx1OLwB1dY5JQ1Y3OR/IMfUXIG9vqx8ga7aec23EYmQT/3DZ1iQHt8jVG1xpn/cXS7q7T6yUq73yTV21x/V9Bq7aQ/1WhluXFBxb6iIPYXRopiIDX0FEbwyyFtV7NhihwdMw3BoiWL46WDmLJY/LiL97Mdqi2XRwWrHx+iUCr1BU5a+p12PGR63vgFQetWUTxMrqG9aftQarQw71w3Nm/Xm5TWPeUGH3gkvb+MSbj5GcdQH5K6KlOGlv+QX5MdsNBcj4Y2R4EbVm3cx3NEihWy36ABdSsJGg71BSb
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bf98335-2c1c-49eb-ce4e-08dbb390616f
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2023 13:01:29.4184
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6bIgSY6Oa59gxoZzkVbKIqEQuBxs44OPQoZhe9ul2FDpwoCQFuuEqQfCHcex3MI4zXZqV5bfuyhNeN5J+XiqEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5890
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-12_10,2023-09-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2308100000 definitions=main-2309120107
X-Proofpoint-GUID: MyyeJh935eDPp0z0pNAWp_f4lbzY4KZz
X-Proofpoint-ORIG-GUID: MyyeJh935eDPp0z0pNAWp_f4lbzY4KZz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 06:02:09 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email


> On Sep 11, 2023, at 9:25 PM, Oliver Sang <oliver.sang@intel.com> wrote:
>=20
> hi, Chuck Lever,
>=20
> On Fri, Sep 08, 2023 at 02:43:22PM +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Sep 8, 2023, at 1:26 AM, kernel test robot <oliver.sang@intel.com> w=
rote:
>>>=20
>>>=20
>>>=20
>>> Hello,
>>>=20
>>> kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_=
sec on:
>>>=20
>>>=20
>>> commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable direct=
ory offsets")
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>>=20
>>> testcase: aim9
>>> test machine: 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.=
70GHz (Ivy Bridge-EP) with 112G memory
>>> parameters:
>>>=20
>>> testtime: 300s
>>> test: disk_src
>>> cpufreq_governor: performance
>>>=20
>>>=20
>>> In addition to that, the commit also has significant impact on the foll=
owing tests:
>>>=20
>>> +------------------+---------------------------------------------------=
----------------------------------------------+
>>> | testcase: change | aim9: aim9.disk_src.ops_per_sec -14.6% regression =
                                              |
>>> | test machine     | 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 =
v2 @ 2.70GHz (Ivy Bridge-EP) with 112G memory |
>>> | test parameters  | cpufreq_governor=3Dperformance                    =
                                                |
>>> |                  | test=3Dall                                        =
                                                |
>>> |                  | testtime=3D5s                                     =
                                                |
>>> +------------------+---------------------------------------------------=
----------------------------------------------+
>>>=20
>>>=20
>>> If you fix the issue in a separate patch/commit (i.e. not just a new ve=
rsion of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <oliver.sang@intel.com>
>>> | Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.s=
ang@intel.com
>>=20
>> Hi, several weeks ago we requested that these tests be run
>> again by the robot because they can't be run in environments
>> I have available to me (the tests do not run on Fedora, and
>> I don't have any big iron).
>>=20
>> We wanted the tests rerun before the patch was committed.
>> There was a deafening silence. So I assumed the work I did
>> then to address the regression was successful, and the
>> patches are now in upstream Linux.
>>=20
>> This new report is disappointing.
>=20
> I'm so sorry that I missed the test request for
> https://lore.kernel.org/all/169030957098.157536.9938425508695693348.stgit=
@manet.1015granger.net/
>=20
> just FYI, when this auto-bisect done,
> head commit of linus/master: [65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4] w=
as
> tested, it already includes
> 2be4f05af71bb libfs: Remove parent dentry locking in offset_iterate_dir()
>=20
> in our tests, the regression still exists.

Thanks for clarifying. I wondered about that, of course only just
after clicking "Send".


>> But, I'm still in a position where I can't run this test,
>> and the results don't really indicate where the problem
>> is. So I can't possibly address this issue.
>>=20
>> Any suggestions, advice, or help would be appreciated.
>=20
> if you have further fix patch, could you let us know? I will test it.

Well that's the problem. Since I can't run the reproducer, there's
nothing I can do to troubleshoot the problem myself.

Is there any hope in getting this reproducer to run on Fedora?


--
Chuck Lever