Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2696891rdb; Tue, 12 Sep 2023 09:21:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdYYqrXhVqFsEoQyPsWLzA4JV5Nttc/pdYxKiO0Ns09cJJo2d2/wlNnRMOn8gcWi2Glq72 X-Received: by 2002:a17:90b:1b0e:b0:268:29cf:3231 with SMTP id nu14-20020a17090b1b0e00b0026829cf3231mr12054777pjb.3.1694535686031; Tue, 12 Sep 2023 09:21:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694535686; cv=none; d=google.com; s=arc-20160816; b=sY/qGdAd9XRAvouyQ6QjQ64A8lg1nVApvHBblDLgK72ISbJf8xghGQxXIjc03/Gd75 QDiHWLd+IsJP7iImyJ7Rp5oeQ/BviJwvCikv533RJ1AEFMxi9YUQnigNhJ1BbnuwaBU+ 3EvE8yOUAPcymsixIYBj+4pG7erNB+/xGguw/+R0Ksf/FtvJrh+eEAeEXLQS9d8My8Y+ 9YjPPv4ypNgOiuKMAot7nFxKKtMGqDjGOqi96BbB78LI4uhXiFcahKBJBSGWahX4Llve G8RlpIP8IpKYrLFdlP7nwhPvjxTbgGXFkLoCivg5bvebsPdSJnIMA2rRXbCFXHR/P864 xDDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SjWTgNYQykSl5vqwrk7e1u9J/HugCNEPohbX17PekV0=; fh=ElCAztf148ZfJ6SJzgMY/0MXxa+8CHgIvebKTS6Ved4=; b=mgo8w2+Ed3f+CMjaISoKhpOGFhImAor+1+adjXuAKekUnY6w/vfr7xdiNhsMy5unbr aItlyMa8IHAEIP6dAyJV430XlnchHexuRASv8LnzUOexxARV8SiBbXxSaWnpS5sDrr/S FDIUC+oFskv7mhQYWZEksRfVPHeMy96jCOt3Nx1rYfjPFIeY1RtkjNf59y+lRDErMuD8 VH9DZp6Px46LPa8MCny3WQLC4tPSs/VIPvU39AjylPcEUZd+PD2eu7sG45/pNGjkOXLq J4Zc+AAK2BQZzb9fLSDIFhcANWKMAWSJ/oVwTzBukzxiudppnJRYNHs3SPPQkjptqIb4 v9Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="u/t6axSq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id hk2-20020a17090b224200b0026829e2a84bsi10604779pjb.97.2023.09.12.09.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 09:21:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="u/t6axSq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4837F80FCE25; Tue, 12 Sep 2023 09:12:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236704AbjILQLv (ORCPT + 99 others); Tue, 12 Sep 2023 12:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236609AbjILQLR (ORCPT ); Tue, 12 Sep 2023 12:11:17 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2353E10E7 for ; Tue, 12 Sep 2023 09:11:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84930C433C7; Tue, 12 Sep 2023 16:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694535073; bh=SjWTgNYQykSl5vqwrk7e1u9J/HugCNEPohbX17PekV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u/t6axSqrjJvcM/XxM4caXNi9Togbc/FQxSEboDlZ8tz2UJPV/oXsxZNuJRn7c7KB 5BWFl//ZDgLOmIpokerKhmEhs4xdfIo8cuurG4bY1bX+sfbFqK9FEHuBS9lgqNcJIE uiNHXuxIwvLRUI4BL1yZmvbfzEhuoUOCsf+Cvd0jlZ5WfpJVqG3S7bJnummRscNSZQ ZoRoh3tiT7o7ot4fDTEgFAn8rl7xSBCh92xJ4MyiS+HiJd3O+Wl6bcYVxyVg61cMN5 R0OVOpiy9x4danWKk5sel0AnfQAxIj/flEmFoEiNYb+aKZwWwy5DVrHGQCdhCdGz3I 71/8jnKufMlsQ== Date: Tue, 12 Sep 2023 09:11:11 -0700 From: Keith Busch To: Pratyush Yadav Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nvme-pci: do not set the NUMA node of device if it has none Message-ID: References: <20230912155249.113009-1-ptyadav@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912155249.113009-1-ptyadav@amazon.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Sep 2023 09:12:10 -0700 (PDT) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email On Tue, Sep 12, 2023 at 05:52:49PM +0200, Pratyush Yadav wrote: > If a device has no NUMA node information associated with it, the driver > puts the device in node first_memory_node (say node 0). Not having a > NUMA node and being associated with node 0 are completely different > things and it makes little sense to mix the two. Applied for nvme-6.6. This overall makes sense, though I hope the patch isn't just to work around xen's incompatibility with managed irqs :)