Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <fbf1f7e5-1a82-303c-3802-2f246505c8a4@intel.com>
Date:   Mon, 11 Sep 2023 16:08:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH v9 9/9] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230907235128.19120-1-babu.moger@amd.com>
 <20230907235128.19120-10-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230907235128.19120-10-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUgyUnRiRGUyNkVGcEdBOXdScVhpdHg2M0Rjb3kvMkpVRzVaREhEQVRyZmZP?=
 =?utf-8?B?TXp2c3ZDdll3WlNCVW1LZVg5UDhsWkNWbzYvSlRxelpLcjZsdER5QlJSR2l2?=
 =?utf-8?B?ZnBWWVpmTzZHdHhleitYNk9xN2JneEx3Rk41Yk5kZWZXU29yZ3hpM1pxMVVU?=
 =?utf-8?B?dEk5cjhkS1NWb0tTQ1JHL3p3RGxxOFZxV1RmOVViaGxTYjJST1FRL1k5TE9T?=
 =?utf-8?B?QWp2c01RZlpQenN2MzZvSDNEWTlKZE5ySVRrZlM2UWVFTStDckk1Sko3Q3c5?=
 =?utf-8?B?djhmM0l4NnVxWXFvNWhRalZzcGZSQ0ZWa21ndEV0d2xOZFR6NCtwdWdXRHZr?=
 =?utf-8?B?S1JhMGdmT0FYRFdvalEwdEpSaG5wak1mMUVEcm8yMkRmSC9SSEF1cFIyejZ6?=
 =?utf-8?B?L2NkMFZVMXNpcDRRT0NuQ3FHOTg3clBvcEtQZGM3TWJCcHNIN2U3YkZUOUdF?=
 =?utf-8?B?eEJ5V21oNmMvMnc3eWZHMk53ZjNualFHRStqZk1IZWMySDd3b042WnFyOWVV?=
 =?utf-8?B?emU2Vmozdkx3c3dOZWlwTGhxTDkvY2VNUldJdTJoVW5RN01MTVRYOGhwTWdx?=
 =?utf-8?B?WWFWeklPL3QvVDFhaEF2QXdIeVlkYU9kd0hQcHlDOEJ1MlRGSE16QnNxSWdB?=
 =?utf-8?B?MmJFb1Z0alBCY3lrZU5JOUtrQXFFc3NjWWJvTThwaGpIZFI2WDV6MXl6WGxX?=
 =?utf-8?B?RUZEbmdPQWZvakRJbE82U0E2bWpXK1ltYkpCY1ZHZmFXOHRPTzNRUCs5WWVW?=
 =?utf-8?B?Y29QeVFBM1R0VVN4VHB0bXdMMjJDdm04eHljVHBMT1dRSnAyTUZ2TEUvNXYy?=
 =?utf-8?B?elExV0VBSjJNWTdYdGYvSGxyVDNPQlpLYzk0eXhYSkVNT3I2Nk11emRQV0NM?=
 =?utf-8?B?VTM2TWRXbnBiMUp2YkZIejhQQkxkY3FtK1ROSWZLNEg3UDFvemVnL2RLcy90?=
 =?utf-8?B?WmF0NC9ZUkovMHVVWnhMYmpoWHphUFdCYldKWE9Va1NjS2xERGV2QXpOR2s3?=
 =?utf-8?B?R2g2UGpweW9WTkVmaGFza3Bnc3BnQVR5UVoreHJsWmIza293QXB0azAwM29w?=
 =?utf-8?B?SExncTRJb012WHRVVG5pdnZBRm5mejRKSjFQamhmeDVmem9Rck9lODVHSmUy?=
 =?utf-8?B?K3lFRE5meWxWbVpPYkdUZmVUNkZOODNtV3VqZkxaSE5nYzdYVnpqZU5PSHRu?=
 =?utf-8?B?TEh2eU01ZVJQWVoxVXdWMHYwNG5Ib016djR2UXh6K0VXUlRIUDc2VWhITGEz?=
 =?utf-8?B?UFhqc1F3cTMyQzdnNFlNNVduQUE0M1cxUnpaUmp2ZG9PVC9kUExnc1RQQ1Z0?=
 =?utf-8?B?SW1aQUdMbDh5anNGUHRFZDF0d000Q1gwcnJZTUY5Qm5xTHhmWU5IRldoWlVC?=
 =?utf-8?B?dlZUekJRWm1hZWthSkx4Q1BQMTdxOGk0TllFbHB2bC9UcmxRaW1FMWxDcXl5?=
 =?utf-8?B?R1pxY1ZyTnl6T1VZSllYVWVCL0dUUGZjcHZqSFh6TklueElvUUdiY0JHOVRs?=
 =?utf-8?B?VkpLS21GMyszMndNbXJRRFJRK0dsbU91dzZ2VG5DWEFpVU1GUmprZFM2NXlq?=
 =?utf-8?B?MWk2VXlDNEJRZjhTMXRvaGluZzlpeDh5RllyMjJUVHFrL0ZmWThxVWJFaEVp?=
 =?utf-8?B?c09KSGJOSlJEenVUK09OVWJBVnJtb0hoUXJXUUtnVjJ0YVpNU1FmZUJWM20x?=
 =?utf-8?B?TThWQzBOUVg1VTNqSHFoWlYvN2I2aDcrREMwZzJYYXBieFRxb3RiNjhtZ0tq?=
 =?utf-8?B?aUcydjNVc3Q0dituOUplOTN3OTlEbmtORXM0bUxQeU5WVUd5STJianY5K2dC?=
 =?utf-8?B?R0IrdEN2eUVEU2RaK0QxNUlWOWZRbG9pa01ncUxBNytDMTJVdE5jWFI5ekJr?=
 =?utf-8?B?c0lUNnhiMkk5ckdVay9xcXB4L2o3MS8rSjJLZVdic2gwMUYvWlVGV0h4Tm5C?=
 =?utf-8?B?dW1FLy80YUk1VDBVMm4vb0pjSVp5c3VKWEFUREV5OUl6NHFCRUZzbzlObmJa?=
 =?utf-8?B?VUV2cUx0MmhLRHhPb0pLMExPTFNieTFkSXM0SzRzb09jTlhwK0xpYlJyNUp6?=
 =?utf-8?B?T2o5SlA5bWxGcDkxMy9qMEM0S3NVcFgzVlBwMkpsaHdIZG5FdGwydGRaaDFE?=
 =?utf-8?B?dlAyQVgwN3BON2RNaVJoREVyWFFUM0dzdzJQQkZmOWoxa0VTNzhWc21YZjNm?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b181fef-af2e-434d-f942-08dbb31bf875
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2023 23:08:11.8534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HF9CYAhIFDAHKxTprlBYq0WzwfIOVR2wD84+3Rlam7/qbS7oHRoUlupZR3WrNRNI0DtjTwUPFa+KzAv9l0dYqeIqCNxfi+m2wGrXw0X2EOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5516
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:36:48 -0700 (PDT)

Hi Babu,

On 9/7/2023 4:51 PM, Babu Moger wrote:
> In x86, hardware uses RMID to identify a a monitoring group. When a
> user creates a monitor group these details are not visible. These details
> can help resctrl debugging.
> 
> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
> Users can see these details when resctrl is mounted with "-o debug" option.
> 
> Other architectures do not use "RMID". Use the name mon_hw_id to refer
> to "RMID" in an effort to keep the naming generic.
> 
> Add the flag RFTYPE_MON_BASE, which contains the files required only
> for the MON group.

As I mentioned in [1] I believe adding support for files with RFTYPE_MON flag
to resctrl needs to be in a separate patch. With the core support added a file
with this flag can be introduced separately. 

Reinette

[1] https://lore.kernel.org/lkml/2feb3e01-96c7-fdde-a0d2-509fa1527243@intel.com/