Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 12 Sep 2023 11:21:22 -0500
From:   Rob Herring <robh@kernel.org>
To:     wangweidong.a@awinic.com
Cc:     lgirdwood@gmail.com, broonie@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        perex@perex.cz, tiwai@suse.com, rf@opensource.cirrus.com,
        shumingf@realtek.com, ckeepax@opensource.cirrus.com,
        herve.codina@bootlin.com, 13916275206@139.com,
        ryans.lee@analog.com, linus.walleij@linaro.org,
        sebastian.reichel@collabora.com, fido_max@inbox.ru,
        povik+lin@cutebit.org, arnd@arndb.de,
        harshit.m.mogalapalli@oracle.com, liweilei@awinic.com,
        yijiangtao@awinic.com, colin.i.king@gmail.com, trix@redhat.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/5] ASoC: dt-bindings: Adds properties to
 "awinic,aw88395"
Message-ID: <20230912162122.GA880119-robh@kernel.org>
References: <20230912065852.347000-1-wangweidong.a@awinic.com>
 <20230912065852.347000-2-wangweidong.a@awinic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230912065852.347000-2-wangweidong.a@awinic.com>
Precedence: bulk

On Tue, Sep 12, 2023 at 02:58:48PM +0800, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>

The subject is still pretty generic. Ideally, we'd never have the same 
subject twice. I'd do something like this:

ASoC: dt-bindings: awinic,aw88395: Add properties for multiple PA support

> 
> Adds properties to "awinic,aw88395" to make files more complete

Complete in what way? multiple PAs, right. It's not really clear 
to me though how these properties enable support for multiple PAs.

> 
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
>  .../bindings/sound/awinic,aw88395.yaml        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> index 4051c2538caf..4965aa4a5370 100644
> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> @@ -32,11 +32,28 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> +  awinic,audio-channel:
> +    description:
> +      It is used to distinguish multiple PA devices, so that different
> +      configurations can be loaded to different PA devices
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 7
> +
> +  awinic,sync-flag:
> +    description:
> +      Flag bit used to keep the phase synchronized in the case of multiple PA
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1
> +
>  required:
>    - compatible
>    - reg
>    - '#sound-dai-cells'
>    - reset-gpios
> +  - awinic,audio-channel
> +  - awinic,sync-flag
>  
>  unevaluatedProperties: false
>  
> @@ -51,5 +68,7 @@ examples:
>              reg = <0x34>;
>              #sound-dai-cells = <0>;
>              reset-gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> +            awinic,audio-channel = <0>;
> +            awinic,sync-flag = <0>;
>          };
>      };
> -- 
> 2.41.0
>