Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <e95c3a61-45bf-40f7-1f5a-67e1b7e64db4@redhat.com>
Date:   Tue, 12 Sep 2023 15:37:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly
To:     "Huang, Kai" <kai.huang@intel.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     "Hansen, Dave" <dave.hansen@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "n.borisov.lkml@gmail.com" <n.borisov.lkml@gmail.com>
References: <cover.1692096753.git.kai.huang@intel.com>
 <a64122a6-0be1-8263-4629-8cae0c013305@redhat.com>
 <f94aa81502421f169806c1349efb28c74878ea46.camel@intel.com>
 <BL1PR11MB5978F08618A3E2389618F33CF7F1A@BL1PR11MB5978.namprd11.prod.outlook.com>
Content-Language: en-US
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <BL1PR11MB5978F08618A3E2389618F33CF7F1A@BL1PR11MB5978.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/12/23 02:57, Huang, Kai wrote:
>>> +#include <asm/tdx.h>
>>> 
>>> #include <asm-generic/asm-prototypes.h>
>>> 
>> Thanks Paolo!
>> 
>> I never met this issue, not even from LKP.  Do you happen to know
>> which Kconfig option can trigger this?  Or would you mind sharing
>> your .config?
> (replying via outlook due to some networking issue of my home
> network)
> 
> After digging, this is due to exporting __seamcall*() assembly
> functions while MODVERSIONS is enabled.
> 
> This series itself doesn't cause this warning.
> 
> I didn't export them in this series because I would like to leave to
> KVM patches when we are sure we need to export them.
> 
> E.g., I have seamcall*() wrappers to retry running out of entropy,
> and we may have concern exporting __seamcall*() low level functions
> directly and may wish to export higher level wrappers.
> 
> So I think the fix should be with the patch that truly exports those
> __seamcall*().  I'll talk to Isaku on this to get his idea.

Ah indeed it's not caused by your patches, but rather by the Isaku's KVM 
TDX support ("KVM: TDX: Add C wrapper functions for SEAMCALLs to the TDX 
module").  The fix is just to squash the #include into his patch.

Paolo