Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2741424rdb; Tue, 12 Sep 2023 10:34:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHy4AQJdKlKB02KsG54Go6LW/GeNi552OmehDZoYoqzi+vKpOl8RfDDyG0OtpRNskSKXP2B X-Received: by 2002:a17:90a:4ec5:b0:26d:4421:854d with SMTP id v5-20020a17090a4ec500b0026d4421854dmr10846214pjl.37.1694540091718; Tue, 12 Sep 2023 10:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694540091; cv=none; d=google.com; s=arc-20160816; b=GoyIkJGTOX8aszCtJkPf4KkkCxbuABXSnZ/1FwIxBdvI6J0S7FbpMcvzZvhXL22ujj aAGKBARZYqsFL0uV8RKVaa+vPNCnzjLGYa8wAfmzdSpCmecKlOjUk50lIo0VDzSLdnQV kGitaWiZSO97tnkkcZTfcSaw0+dKlhAo18y5ZETncv/mpsyVxJZY+8JdKfgq+5MSAuTN EGRo7c/CDqba3ZdxxBAryAt/4f32AHxAe/mld/akqW+ft2cnZEoImJJVwETDdls5Tml0 vX/yQvbkHshtXXzOaeWijx9xsoMCKiSvb4SlyRhdyMx5N4EZN82Xlj9Z2FSP0S5G/YQv 8Tzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:to:from:subject:cc :message-id:date:content-transfer-encoding:mime-version :dkim-signature; bh=blCRopuCyEg9SliGQhKt1BWA/HnbQhK90Yp287oF06A=; fh=nKAep/XDSMl8dj3CYRaqsln016/c4yXm8P0CkNLe6Pk=; b=ppUMyZHaNDp9Ss3o9suHKjQJSjyEYognCMZGt7rWM5EpVxFENrWEM47BalNj3brlXm zuFEmaZ3vO0/cH7iNSSynRQyf1yLGOZhAZY+kdTYPhVibhsky3AMTUfKbbnLYDNdiHnY Jxh8VPDSurIfu2eALRywNPCHh4mO9pI/gCz3cm3pw8C5stXdT7aD6DXH/KOWFM3Fo1Qi iPyxVM/lJ7CSlmwUkb4QmoWks2i81YfkZtYIH/BXiJeQTXO8WAwG4vzoEX9Vo+wlZeod u9Ym3AQBBfoWayHfPEaSXAN13qp71WDkCHneUboyptOw+CexANwGF9UtUxgfVVo2piQt 8J9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ue7JlDqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id ay9-20020a17090b030900b00271ae22eea7si10112039pjb.117.2023.09.12.10.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 10:34:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ue7JlDqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 469F68246E2C; Tue, 12 Sep 2023 10:34:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236731AbjILRek (ORCPT + 99 others); Tue, 12 Sep 2023 13:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbjILRek (ORCPT ); Tue, 12 Sep 2023 13:34:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366B110E9; Tue, 12 Sep 2023 10:34:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9138C433C8; Tue, 12 Sep 2023 17:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694540075; bh=9GHvDYyDgQ1uQgwUbBG3T6n5VLCoxKnTwH+ebGupVVQ=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=Ue7JlDqOAGqimu3Kkt4LS/bVe302496Rc3b4FBkHFyp80FDSRPk6O5d8jr84wRCfZ iq9xmx0t/GMvCZfny0AAaTfzwpfXsruoUJcqu7ZpagXcyOwon2t6Wjv76YlFnY4E9k pBdjONPwb/Gd3Gjst5vn/JIiYshbbnlZo+dfFV/IOAgQ6MLC8CG5rua0EPfSwikja9 DCjVoD0gbRHUI0p9pn2jrXjlqPEmIQuk7gWw0PWRBx0ifHeEn1KGNywEab2rD2bMyr Jx2GQTaUMFhGMPN/QHRn9nGFXY8m6hIp2yGvJMWR4/v1nkfaOCplAjoQdmd8pMaDRX Ti6LrS8+QAA8w== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Sep 2023 20:34:27 +0300 Message-Id: Cc: "Shawn Guo" , "Jonathan Corbet" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Ahmad Fatoum" , "sigma star Kernel Team" , "David Howells" , "Li Yang" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" , "Paul E. McKenney" , "Randy Dunlap" , "Catalin Marinas" , "Rafael J. Wysocki" , "Tejun Heo" , "Steven Rostedt (Google)" , , , , , , , , , "Richard Weinberger" , "David Oberhollenzer" Subject: Re: [PATCH v2 1/3] crypto: mxs-dcp: Add support for hardware provided keys From: "Jarkko Sakkinen" To: "David Gstir" , "Mimi Zohar" , "James Bottomley" , "Herbert Xu" , "David S. Miller" X-Mailer: aerc 0.14.0 References: <20230912111115.24274-1-david@sigma-star.at> <20230912111115.24274-2-david@sigma-star.at> In-Reply-To: <20230912111115.24274-2-david@sigma-star.at> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 10:34:49 -0700 (PDT) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email On Tue Sep 12, 2023 at 2:11 PM EEST, David Gstir wrote: > @@ -101,6 +102,7 @@ struct dcp_async_ctx { > struct crypto_skcipher *fallback; > unsigned int key_len; > uint8_t key[AES_KEYSIZE_128]; > + bool refkey; > }; s/refkey/key_referenced/ No reason to obfuscate it, especially since there is no supporting documentation. BR, Jarkko