Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <1a1278715076b92ae73ac97950cd70e9.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230912112951.2330497-1-cyndis@kapsi.fi>
References: <20230912112951.2330497-1-cyndis@kapsi.fi>
Subject: Re: [PATCH] clk: tegra: fix error return case for recalc_rate
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Timo Alho <talho@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Jonathan Hunter <jonathanh@nvidia.com>,
        Mikko Perttunen <cyndis@kapsi.fi>,
        Thierry Reding <thierry.reding@gmail.com>
Date:   Tue, 12 Sep 2023 10:58:33 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Mikko Perttunen (2023-09-12 04:29:50)
> From: Timo Alho <talho@nvidia.com>
>=20
> tegra-bpmp clocks driver makes implicit conversion of signed error
> code to unsigned value in recalc_rate operation. The behavior for
> recalc_rate, according to it's specification, should be that "If the
> driver cannot figure out a rate for this clock, it must return 0."
>=20
> Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
> Signed-off-by: Timo Alho <talho@nvidia.com>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---

Applied to clk-fixes