Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2781808rdb; Tue, 12 Sep 2023 11:53:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVTgoJvKogUru/OCisLRO5eeYMUqJZu7VN0WZeNgZHVsAiQqENLStgIopfbSIW4hSSneA/ X-Received: by 2002:a05:6870:f5a3:b0:1be:c586:31ae with SMTP id eh35-20020a056870f5a300b001bec58631aemr374581oab.40.1694544805713; Tue, 12 Sep 2023 11:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694544805; cv=none; d=google.com; s=arc-20160816; b=zJraEQM7Q3kWdWf/OqJbYol6evXoO5IE/4Uzw5qHXfe/TAYlSAhmAfQ0SXdVjLqTEH hZpmNQAuECHnz44iC9BMfW1dvvJNescCJl8mRossecD1I4PsOgvMHaQScCs75z2X747f krf2bWb6cxXiswSQh8GjUuN5SySDLI12ZhylOWYVx0s0kmGT0ye6nWDV3No8oubM6MEe Et3e3YNyBlDFWH53AKPyrj1vy2lnNSQ3cs4XFmXqkwrp0GjdMIkQ5HA+xVoiFaXniLTD zJJ/SH7d5JenluUY1S6VwQGBA79ilBzrKQFypQ/kYpiWEjQTeaHNIAV1CQvIt8vb2IEK eq7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yryjvzR9NzNgk6BCUoTtHwzBXt7G8S/d1x5J4L9Bd38=; fh=ZYtQOaPQ3bv/nEoeNBBJi+8gjEgXnsUn5nizHK4ZU74=; b=bysYNVNmMzHb4D21JhMhL5wPNadff0wKOKIwZWuX3Oc4ZphhIkB5PDSMRNNC6soeqe 12li2TLeuwrfSl7ATAYe/UNJ6Wmu50UD6HREew7HgcpvYM8OTaXVu71u74K+9Dnou204 LskxgWaKryFfFnSND9EegwzznJ/NFzDTGZv6dX9ftJ3c3gwEbYasKGr+z2nei60ziyr6 v2veHiHR9MNMEDWuZnVG6p0BFOGPU6hRh0mM6zhO+oCiRPq12i0RQRHROdFmsm5826aS i3rDNpwi3yGcamq2e4RaaWQKjOb576KnFMQFBY8J7g9LZYnG7Hm2Wd7t98Y3C5qAgQ+U x/4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Jjklqaqk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id y21-20020a634b15000000b0056aca1f1d5csi2286009pga.777.2023.09.12.11.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 11:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Jjklqaqk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id DDC70802F94F; Tue, 12 Sep 2023 10:50:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbjILRuX (ORCPT + 99 others); Tue, 12 Sep 2023 13:50:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230231AbjILRuW (ORCPT ); Tue, 12 Sep 2023 13:50:22 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99436E59 for ; Tue, 12 Sep 2023 10:50:18 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c0d5b16aacso49080295ad.1 for ; Tue, 12 Sep 2023 10:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1694541018; x=1695145818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yryjvzR9NzNgk6BCUoTtHwzBXt7G8S/d1x5J4L9Bd38=; b=JjklqaqkPpnTVcgPqtO/BQWf3HXqa/EGl6bOnWHgLnFo6X1dLpv+QzIZM3n2AWoexm P3U7dqymCmX17PVkaB+8tlcuCYTznep9qUGZ/aGT3+eb6M2GXczvuhTfB4Lqs+afcMfA bvmLDuXfN/YjLtY7lsdOYZTQNTrbGecJCCGz3eABXwXXBOGQwdpdoYHpnEOxEB0cMUez kPnW43yYDYrw1xLYwP5tGha2p7HS4+OFDTpCgPPNAk43ZBidsJ3tXhYueWqefn4NoZ00 zMz8PFuyd8GICWFGgEYnLsSHO4wTzEWQHyG/z/WcxOy1ucVBYKhd9ao9WQDp+UQ/p3i7 nCqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694541018; x=1695145818; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yryjvzR9NzNgk6BCUoTtHwzBXt7G8S/d1x5J4L9Bd38=; b=qF1dNe2gylKgIAROrobjw/7NtITOFLvA/CzCaQI/lwLdd68xpsetcddz6iYGdHuY6L bmKPvpqE92KYcwGJ89Wpl7+na8muOkFktfXld0EkhFbTTC6+e/xdwuJW9knLNffYaz0v nIxprvOI7p0aEmMowPGhSx6dqlfr3gStEJd1iCWSTrPiO8I1kzbKnh4WpTDhg10HIemx zql0rYZ+v8OSjhDE7yhO1Ipo+hrZxJfnwUgqmr/d8kOk7FJZkKO+lcdq1xolPtwTILwc IqHSPwwqciIl32MfEw5EgDQ9zlg54K9UnCQVoS+WQOcKjCOvlwOduBpJZWm3qr21XlFD a5Gg== X-Gm-Message-State: AOJu0YzfTxG/8RwIUW7fw6NGMYw6RIcfyxw2etm5hkOjMy+Q4PnxLGq6 Bqy8BTI37Q6l0bEqYDUiSN/9Hw== X-Received: by 2002:a17:903:32d0:b0:1c3:6667:5ff1 with SMTP id i16-20020a17090332d000b001c366675ff1mr455370plr.27.1694541017844; Tue, 12 Sep 2023 10:50:17 -0700 (PDT) Received: from localhost.localdomain ([171.76.81.83]) by smtp.gmail.com with ESMTPSA id p12-20020a170902a40c00b001b891259eddsm8691440plq.197.2023.09.12.10.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 10:50:17 -0700 (PDT) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley Cc: Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: [PATCH v8 00/16] Linux RISC-V AIA Support Date: Tue, 12 Sep 2023 23:19:12 +0530 Message-Id: <20230912174928.528414-1-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 10:50:37 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email The RISC-V AIA specification is now frozen as-per the RISC-V international process. The latest frozen specifcation can be found at: https://github.com/riscv/riscv-aia/releases/download/1.0/riscv-interrupts-1.0.pdf At a high-level, the AIA specification adds three things: 1) AIA CSRs - Improved local interrupt support 2) Incoming Message Signaled Interrupt Controller (IMSIC) - Per-HART MSI controller - Support MSI virtualization - Support IPI along with virtualization 3) Advanced Platform-Level Interrupt Controller (APLIC) - Wired interrupt controller - In MSI-mode, converts wired interrupt into MSIs (i.e. MSI generator) - In Direct-mode, injects external interrupts directly into HARTs For an overview of the AIA specification, refer the AIA virtualization talk at KVM Forum 2022: https://static.sched.com/hosted_files/kvmforum2022/a1/AIA_Virtualization_in_KVM_RISCV_final.pdf https://www.youtube.com/watch?v=r071dL8Z0yo To test this series, use QEMU v7.2 (or higher) and OpenSBI v1.2 (or higher). These patches can also be found in the riscv_aia_v8 branch at: https://github.com/avpatel/linux.git Changes since v7: - Rebased on Linux-6.6-rc1 - Addressed comments on PATCH1 of v7 series and split it into two PATCHes - Use DEFINE_SIMPLE_PROP() in PATCH2 of v7 series Changes since v6: - Rebased on Linux-6.5-rc4 - Updated PATCH2 to use IS_ENABLED(CONFIG_SPARC) instead of !IS_ENABLED(CONFIG_OF_IRQ) - Added new PATCH4 to fix syscore registration in PLIC driver - Update PATCH5 to convert PLIC driver into full-blown platform driver with a re-written probe function. Changes since v5: - Rebased on Linux-6.5-rc2 - Updated the overall series to ensure that only IPI, timer, and INTC drivers are probed very early whereas rest of the interrupt controllers (such as PLIC, APLIC, and IMISC) are probed as regular platform drivers. - Renamed riscv_fw_parent_hartid() to riscv_get_intc_hartid() - New PATCH1 to add fw_devlink support for msi-parent DT property - New PATCH2 to ensure all INTC suppliers are initialized which in-turn fixes the probing issue for PLIC, APLIC and IMSIC as platform driver - New PATCH3 to use platform driver probing for PLIC - Re-structured the IMSIC driver into two separate drivers: early and platform. The IMSIC early driver (PATCH7) only initialized IMSIC state and provides IPIs whereas the IMSIC platform driver (PATCH8) is probed provides MSI domain for platform devices. - Re-structure the APLIC platform driver into three separe sources: main, direct mode, and MSI mode. Changes since v4: - Rebased on Linux-6.5-rc1 - Added "Dependencies" in the APLIC bindings (PATCH6 in v4) - Dropped the PATCH6 which was changing the IOMMU DMA domain APIs - Dropped use of IOMMU DMA APIs in the IMSIC driver (PATCH4) Changes since v3: - Rebased on Linux-6.4-rc6 - Droped PATCH2 of v3 series instead we now set FWNODE_FLAG_BEST_EFFORT via IRQCHIP_DECLARE() - Extend riscv_fw_parent_hartid() to support both DT and ACPI in PATCH1 - Extend iommu_dma_compose_msi_msg() instead of adding iommu_dma_select_msi() in PATCH6 - Addressed Conor's comments in PATCH3 - Addressed Conor's and Rob's comments in PATCH7 Changes since v2: - Rebased on Linux-6.4-rc1 - Addressed Rob's comments on DT bindings patches 4 and 8. - Addessed Marc's comments on IMSIC driver PATCH5 - Replaced use of OF apis in APLIC and IMSIC drivers with FWNODE apis this makes both drivers easily portable for ACPI support. This also removes unnecessary indirection from the APLIC and IMSIC drivers. - PATCH1 is a new patch for portability with ACPI support - PATCH2 is a new patch to fix probing in APLIC drivers for APLIC-only systems. - PATCH7 is a new patch which addresses the IOMMU DMA domain issues pointed out by SiFive Changes since v1: - Rebased on Linux-6.2-rc2 - Addressed comments on IMSIC DT bindings for PATCH4 - Use raw_spin_lock_irqsave() on ids_lock for PATCH5 - Improved MMIO alignment checks in PATCH5 to allow MMIO regions with holes. - Addressed comments on APLIC DT bindings for PATCH6 - Fixed warning splat in aplic_msi_write_msg() caused by zeroed MSI message in PATCH7 - Dropped DT property riscv,slow-ipi instead will have module parameter in future. Anup Patel (16): RISC-V: Don't fail in riscv_of_parent_hartid() for disabled HARTs RISC-V: Add riscv_get_intc_hartid() function of: property: Add fw_devlink support for msi-parent drivers: irqchip/riscv-intc: Mark all INTC nodes as initialized irqchip/sifive-plic: Fix syscore registration for multi-socket systems irqchip/sifive-plic: Convert PLIC driver into a platform driver irqchip/riscv-intc: Add support for RISC-V AIA dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller irqchip: Add RISC-V incoming MSI controller early driver irqchip/riscv-imsic: Add support for platform MSI irqdomain irqchip/riscv-imsic: Add support for PCI MSI irqdomain dt-bindings: interrupt-controller: Add RISC-V advanced PLIC irqchip: Add RISC-V advanced PLIC driver for direct-mode irqchip/riscv-aplic: Add support for MSI-mode RISC-V: Select APLIC and IMSIC drivers MAINTAINERS: Add entry for RISC-V AIA drivers .../interrupt-controller/riscv,aplic.yaml | 172 ++++++ .../interrupt-controller/riscv,imsics.yaml | 172 ++++++ MAINTAINERS | 14 + arch/riscv/Kconfig | 2 + arch/riscv/include/asm/processor.h | 4 +- arch/riscv/kernel/cpu.c | 24 +- drivers/irqchip/Kconfig | 25 +- drivers/irqchip/Makefile | 3 + drivers/irqchip/irq-riscv-aplic-direct.c | 326 +++++++++++ drivers/irqchip/irq-riscv-aplic-main.c | 240 ++++++++ drivers/irqchip/irq-riscv-aplic-main.h | 53 ++ drivers/irqchip/irq-riscv-aplic-msi.c | 285 ++++++++++ drivers/irqchip/irq-riscv-imsic-early.c | 258 +++++++++ drivers/irqchip/irq-riscv-imsic-platform.c | 328 +++++++++++ drivers/irqchip/irq-riscv-imsic-state.c | 523 ++++++++++++++++++ drivers/irqchip/irq-riscv-imsic-state.h | 67 +++ drivers/irqchip/irq-riscv-intc.c | 46 +- drivers/irqchip/irq-sifive-plic.c | 200 ++++--- drivers/of/property.c | 2 + include/linux/irqchip/riscv-aplic.h | 119 ++++ include/linux/irqchip/riscv-imsic.h | 86 +++ 21 files changed, 2847 insertions(+), 102 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,aplic.yaml create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,imsics.yaml create mode 100644 drivers/irqchip/irq-riscv-aplic-direct.c create mode 100644 drivers/irqchip/irq-riscv-aplic-main.c create mode 100644 drivers/irqchip/irq-riscv-aplic-main.h create mode 100644 drivers/irqchip/irq-riscv-aplic-msi.c create mode 100644 drivers/irqchip/irq-riscv-imsic-early.c create mode 100644 drivers/irqchip/irq-riscv-imsic-platform.c create mode 100644 drivers/irqchip/irq-riscv-imsic-state.c create mode 100644 drivers/irqchip/irq-riscv-imsic-state.h create mode 100644 include/linux/irqchip/riscv-aplic.h create mode 100644 include/linux/irqchip/riscv-imsic.h -- 2.34.1