Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2782758rdb; Tue, 12 Sep 2023 11:55:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5SWGZMsEaqKeyx4LEd5cgGnt2DaSODZoYHoUpbDC/ZsPSmmjqe2xXzPLw7aoqiUDh7v/i X-Received: by 2002:a17:90a:bf0a:b0:263:9816:fe0f with SMTP id c10-20020a17090abf0a00b002639816fe0fmr134963pjs.15.1694544934099; Tue, 12 Sep 2023 11:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694544934; cv=none; d=google.com; s=arc-20160816; b=PYQ2fEyGbgPkHDLzPqQO10zvlqvMOfBBrJNWCmRL6HIzbN3TWg9yNKXAlW4djhLhRt sLOHI+/qtYhl7h+ex5poKbhTyrXaBAQde6PCdaG1TcuAIlz2o0Fk4fRkb9IRGLwWFsxD +fuyLecDtnaiu8M2Y8gREyj2r7iJnOCQfbpNul+chsL1uk/m/P7CL9qVTDUJHbooQqRU iSN89K7ea98uChOXc4HfHfzYqc506XWatrCVEGmCrdCLD1C6EDZI+ean+BRXSdmdKsod 8YZtISV2BXb8cumUTKoYjUtvVTDTb8jw4Twk5Cewg5yiQOTMYfVoyXZpP/rJRMnNJj+8 oltA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8SVEaXl6seBdw5lXAfYjpnfIky9vuZwXvZJhUk0v854=; fh=G5bjPqTETrZgjQhg8334UwiqNk/mw421zZgVZK+S+tg=; b=jIjK2u1dnMAJ2vqspX/lxH8Hu1nKZMoL9cB7/T3xm0sBQAjo/iZYH6o5+I2XG53jz3 oYj0OmPnDZcS37Kdb670C2NXvgaBreHVwPXyzur7Og8lcZS0DwYcei5dbR41qomepN+k dUK4GEJ0QgZsr0eOUq2olye7QxeFA4bN5RgmXn3PPDdPslTRegnkh1Mkt/+kF7lDnmkE BhTKhoReDIKOCworXTZFiNZ/OhLFVYG3JD9UQ/eG1RTcnwmuwntlST/wcMJ0ai8u/L14 H51LyoxgTvs/8kNEZm98UQ+fGtqYXwcOx6csmie7HwOEQIgQuDuIYHbB0NDAOQJfYVux jNVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=cVTwKjUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id x1-20020a17090aca0100b002681dc4472esi10108475pjt.134.2023.09.12.11.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 11:55:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=cVTwKjUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AB68D80BE2D6; Tue, 12 Sep 2023 08:07:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236190AbjILPG7 (ORCPT + 99 others); Tue, 12 Sep 2023 11:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236139AbjILPG6 (ORCPT ); Tue, 12 Sep 2023 11:06:58 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 146EC12E; Tue, 12 Sep 2023 08:06:54 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99de884ad25so751668466b.3; Tue, 12 Sep 2023 08:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694531212; x=1695136012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8SVEaXl6seBdw5lXAfYjpnfIky9vuZwXvZJhUk0v854=; b=cVTwKjUP91g7peGOFwKHi7hqYgdn0xOnQha6lNRMgS5qk4JuN6PNXD7PcqYyIHq+0a hCUk1uI70o+rRIDyBK+KEJft9/CmYG045LUEZ3jTCjvxLJWYiRRtEmMX+zYDedIJu4TZ GzXiNUcLAXiPpCa4ZNd6mactY61PsOpZDCHBca6JdZ+k73XJV7fYilg/xxjLlnX0BlMp f2EuveSPcN+hQiKRdnt5Ry54K23ECSFyPm86t9ESM4z/iCT31axMpyY1dzIj1TUfmsRA 3MCmwho7LtttmY2jCp8JaSJWw+iRp0zcZU1UoHXVLFzirrYT9AqT42kXbnPyk7rQ6giH 1wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694531212; x=1695136012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8SVEaXl6seBdw5lXAfYjpnfIky9vuZwXvZJhUk0v854=; b=Mdk6X8Qf3hMZxS07E/SkbqrlkW115NlrxmpArwM6l5cUZDJYUPaYe/DOfowAAbI/4L JeVhmGrqG/ye/A4Ry5hOHM8LTgr/aBfUJrAYGNkR5ezx7GtgSmwjcNkEvRQZtJGLpq6T CAivPAkVgl3KUFKsGtQzoZWhdvQ+6RtB6w/ce9ZVdAOZ1Biv8K3C9JmpTHkmJqX9mOjG G110YsllUsfLe1z8BhjAi5D47816T0sUKJledCeVU/p9ICAc3JXx7II39CY7GXvkwixU pMkFy+w9tOjTukJqbhhrs8anuo0YHR5FKKSuR9DqK7qCd4/VdntMjhdvWh64Be8f22dd jXZA== X-Gm-Message-State: AOJu0YxV6W1uyMgCnVtaMZTBz/nfBCxYu9jmi3bZl0dampSIwU4KRjzy 6owHkPzSuFloGHD6Wnty2A== X-Received: by 2002:a17:906:9e:b0:9a1:ddb9:6547 with SMTP id 30-20020a170906009e00b009a1ddb96547mr11268179ejc.57.1694531212074; Tue, 12 Sep 2023 08:06:52 -0700 (PDT) Received: from p183 ([46.53.254.179]) by smtp.gmail.com with ESMTPSA id s3-20020a170906060300b0099ce188be7fsm6962955ejb.3.2023.09.12.08.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 08:06:51 -0700 (PDT) Date: Tue, 12 Sep 2023 18:06:49 +0300 From: Alexey Dobriyan To: David Laight Cc: 'Kees Cook' , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "linux-hardening@vger.kernel.org" Subject: Re: [PATCH v2] uapi: fix __DECLARE_FLEX_ARRAY for C++ Message-ID: <683d7b5f-48b5-492d-8577-0be85bff8d89@p183> References: <930c3ee5-1282-40f4-93e0-8ff894aabf3a@p183> <202309080848.60319AF@keescook> <202309080910.44BB7CEF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Sep 2023 08:07:07 -0700 (PDT) X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email On Mon, Sep 11, 2023 at 08:19:20AM +0000, David Laight wrote: > ... > > Okay, can you please split the patch so they can be backported > > separately? Then I'll get them landed, etc. > > Since the header with just the extra #endif is badly broken on C++ > isn't it best to ensure they get back-ported together? > So one patch is probably better. Header guard misplacement is not a bug, file ends with: #ifndef __counted_by #define __counted_by(m) #endif it is just looks confusing in the diff.