Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <902ae38f-fbd5-2686-0467-ca440e9a7a50@intel.com>
Date:   Tue, 12 Sep 2023 10:57:50 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH v9 9/9] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230907235128.19120-1-babu.moger@amd.com>
 <20230907235128.19120-10-babu.moger@amd.com>
 <fbf1f7e5-1a82-303c-3802-2f246505c8a4@intel.com>
 <1b6d1121-00a8-5f30-26fd-d5137fe9d9c1@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <1b6d1121-00a8-5f30-26fd-d5137fe9d9c1@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjFLZjhiYkpOd0FSdENNY3Y4WHlHdjR5c29JdTJDcGkyYlFFMmdQazVPN0ts?=
 =?utf-8?B?bmRNMm5IYkl3L3ZaMHhrTE01VXZ2eS93MG9QZ0dhVCtWR09zQ1FIRENOQlU0?=
 =?utf-8?B?ZkNhWG5IMCsySURFM2NhWjBoTlArVGJtUyt2SU91NVpER3RDd0RVNURTTDVr?=
 =?utf-8?B?WER4aEJwMXNFdUk4YmdPVjdKWVpiN0w5TXhodk1MaWRUSlZzSEJLcUlFS0hI?=
 =?utf-8?B?WkFDeDB5SE1ZM1ZYV0M5RFlid0RBcXd3b2I5RXFnQjNNUmNBYkZ6TjcyRnlp?=
 =?utf-8?B?NCtqODFPbFdad1EwdDJPNFBqaTRZczFrMzh5OE5lU09pQ25mT2FMa0lHVENx?=
 =?utf-8?B?YjYzV05TTTN3Z0s5TnlUVE83SXZJMlVEamtXaHJmRnZxZXFvYzNETkMwQ3Zn?=
 =?utf-8?B?ajYyWFZYR0ZuSG5VYTZUemxoTjh2ZFBJZ0JGNTg2RGR0SGhyMERaYTE4aFJK?=
 =?utf-8?B?KzJjbXBFMzdTNHZtRmRZdzNoODQ2TGxDMCtNbGpkV1c2eWV1dEZBTWNoaHhR?=
 =?utf-8?B?UWxXT2hPcWhlYzNBZE43eTBBdUF1NS9YYk5wZ3MzYUxVUGdPN0VDam0rTVU2?=
 =?utf-8?B?Z2NkVXJrbzQxdFRzU1gzdFljKy9LZlI0WHNQVXVPYzhXVktMd21qNFdCMVAx?=
 =?utf-8?B?YVNueTUxbEg5U3ZWUU1Sd2E1QjU3UlN3dUNWV3NjdHhRdzd5RXplQ1BoQmJt?=
 =?utf-8?B?VHRoUS90YjR6MzhvY0Q2c3c2MllpYXJwTk5LNUIydlpCbGhjRTEzckNMcXRC?=
 =?utf-8?B?RHh0Z2RiaUhIdE5TcW1IeGNCbTF4TjJlQk1xRVMvTmZGSEpsUlY0bHB1SmNr?=
 =?utf-8?B?WmVFWWJXNEhqb3RCM3RZbzQ0d2RXamFUZGg5MGVyRUVtdUpnV2VWZVNiWC9H?=
 =?utf-8?B?ekplaG84NTE5cFp0OUY5VHVNY2ZJMGhFUmREbmwyRzdUVkxZbUdEUHNjaWl6?=
 =?utf-8?B?d0N2aGVjRHkxSnhKc1RTcUxDV053WWNxUEhKLzUzd2FFN1haZ1dwaU9TaVN0?=
 =?utf-8?B?YUJ2dUhucHZ1Tk8xZjVpa1V1MUEzZWl5dk9TRWhrWGxmalpDZDZYZVpZdVBy?=
 =?utf-8?B?RXpScXhicFVGUGRTUlVUakl0ODBBQUpBbktuTjV1bFd3NVByNURsSm1LcHpE?=
 =?utf-8?B?NHRMZkI0Y2JVVm4yc2dhWHgvQTNrd2txQ3ZCazZKZU5VOWZ3Vk5kc1krbUht?=
 =?utf-8?B?dGtENVp4YUNucUtOK0xMYWdPZmZyTGEyd0dSL1hmcUkwaWtLbjRtYSt4dGto?=
 =?utf-8?B?ZlNLRG9abm9ZOXN4Q3NkbGNrU1dCZmkrTjh2a2pjbDdKaVp3NzcwRTdWY1J4?=
 =?utf-8?B?WkdmTnhLbjJQWmxSakpFd0VxdTlxZFVJYmplYmN5d2ZoRU1aQ2hvUG9FVHRy?=
 =?utf-8?B?SlZJZjR4eVpqSHhTZ29KeXkrY1JFVHZCMTBVUDczbCtCa0xwQkRQaUs3UlZR?=
 =?utf-8?B?NWlMaGR4eldzRG04eU1rSlArM3NtMkY5Q2VENVJXT25oc0FZRE93dkdWL3lK?=
 =?utf-8?B?NVNNS2FBZ2tjTE1iTG40L25QYlhndDJhT1E4OFBoOEVRN2hWTFpJaW02a1pk?=
 =?utf-8?B?ZkxUN0tsUUw5QmFpZ1hjNTVTQkZUQnFQSVJqMm5ab1JYOTQxdW9GUmRWQjlm?=
 =?utf-8?B?a1lUZmFYZjRMRG5ET3RXUUcxM1hHL3JuTDRYd3RpUFNKQTZVaEV2TzBiOUdj?=
 =?utf-8?B?Um9EOTZUZWd4QXY4N3pNVXQzNU5BNmtLNC9EWlRjT0Nia1VBZVhJSEhqZE9R?=
 =?utf-8?B?WENtdmUvYkV4SktlMW51M1Y5ZnZIbXJ4MCtsWFlNNFBRWkVVMTIwSWhHTmdH?=
 =?utf-8?B?M0V1ek5tbkVUejd0djhTTnF1Sm9WT29rcVk0MEVyTUduL3g2ekpWbnMrUTNP?=
 =?utf-8?B?dmJTbFpjL3ZXaWdUSnpoYk11UU53Zmc2MkNKanc4djdlMmNjY3IwQnprSEJp?=
 =?utf-8?B?N3BiVEFybkNJWFpqbFM4anNqWmhmT2h2b2gvSThsY2tMZ2cwQ3JvOFhJY0Y2?=
 =?utf-8?B?ZlJlcjVJZHFjSVd4eDBpR3U0N0JxemNnalowQUtNcUEyeVFWUDlYWllKUGxX?=
 =?utf-8?B?Y0lLK3FSMTdyTmpjc2pTZ1FRUVAveXFsMU5JaDFNWHJWRTBiSlZHdWdFUkhL?=
 =?utf-8?B?TVFOVzhueVBtVXloYzFTdlZZZm43Z1ZxWW5mMlNUU1p0Wm1yNWxON3ptejBq?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d2bc519e-5380-4799-c7f3-08dbb3b9ca48
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 17:57:54.9751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nK+jXJFMJhpefsNZpjSf9Z+9iRdRh0f+XMYGt67FDYlLN47B2vz6HsqWlQWN9nY74WaAueWVq+BPZgaYVY9+HV8bFMt800ItS9jPB49akxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4738
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Sep 2023 10:58:29 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email

Hi Babu,

On 9/12/2023 10:39 AM, Moger, Babu wrote:
> On 9/11/23 18:08, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 9/7/2023 4:51 PM, Babu Moger wrote:
>>> In x86, hardware uses RMID to identify a a monitoring group. When a
>>> user creates a monitor group these details are not visible. These details
>>> can help resctrl debugging.
>>>
>>> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
>>> Users can see these details when resctrl is mounted with "-o debug" option.
>>>
>>> Other architectures do not use "RMID". Use the name mon_hw_id to refer
>>> to "RMID" in an effort to keep the naming generic.
>>>
>>> Add the flag RFTYPE_MON_BASE, which contains the files required only
>>> for the MON group.
>>
>> As I mentioned in [1] I believe adding support for files with RFTYPE_MON flag
>> to resctrl needs to be in a separate patch. With the core support added a file
>> with this flag can be introduced separately. 
> 
> Yes. We discussed it. Thought it may not fit as a separate patch on its
> own. So, i combined it.
> 
> Now, I split patch 9 into two. Let me know if it looks ok.
> 
> ==========================================================================
> 
> Author: Babu Moger <babu.moger@amd.com>
> Date:   Thu Sep 7 18:51:28 2023 -0500
> 
>     x86/resctrl: Add RFTYPE_MON_BASE for MON groups
> 
>     Add the flag RFTYPE_MON_BASE, which contains the files required only
>     for the MON group. Files with these flags are only visible when
>     monitoring is enabled.
> 
>     Signed-off-by: Babu Moger <babu.moger@amd.com>
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
> b/arch/x86/kernel/cpu/resctrl/internal.h
> index ccdbed615d41..72988e5c52a7 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -296,6 +296,8 @@ struct rdtgroup {
>   *     --> RFTYPE_BASE (Files common for both MON and CTRL groups)
>   *         Files: cpus, cpus_list, tasks
>   *
> + *             --> RFTYPE_MON (Files only for MON group)
> + *
>   *             --> RFTYPE_CTRL (Files only for CTRL group)
>   *                 Files: mode, schemata, size
>   *

I think it would be ok to add above hunk as part of the patch
that adds mon_hw_id, similar to what you did in patch 8.

> @@ -315,6 +317,7 @@ struct rdtgroup {
>  #define RFTYPE_MON_INFO                        (RFTYPE_INFO | RFTYPE_MON)
>  #define RFTYPE_TOP_INFO                        (RFTYPE_INFO | RFTYPE_TOP)
>  #define RFTYPE_CTRL_BASE               (RFTYPE_BASE | RFTYPE_CTRL)
> +#define RFTYPE_MON_BASE                        (RFTYPE_BASE | RFTYPE_MON)
> 

This hunk may be appropriate for patch 3.

>  /* List of all resource groups */
>  extern struct list_head rdt_all_groups;
> 

This is not how I expected it to look. There is currently an issue
in resctrl where files with RFTYPE_MON are not created for CTRL_MON
groups. This has not actually been a problem because there are
no files with the RFTYPE_MON flag. This series introduces the first
file with RFTYPE_MON flag and thus this resctrl issue needs to be fixed
before this new file can be supported.

Considering this I expected to see the changes in rdt_get_tree()
and mkdir_rdt_prepare() done as a separate patch. This will add
support for RFTYPE_MON files to resctrl. After this change
a separate patch can add the file that has this flag.

Reinette