Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2797824rdb; Tue, 12 Sep 2023 12:21:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGVl9R4WrDavdhjtfB/p3wCPY+j8iURm+9HZWZITSG73875gk6EwhP86Y8rHreEOHm0uGr8 X-Received: by 2002:a17:902:d505:b0:1b8:525a:f685 with SMTP id b5-20020a170902d50500b001b8525af685mr671811plg.37.1694546483432; Tue, 12 Sep 2023 12:21:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694546483; cv=none; d=google.com; s=arc-20160816; b=Xe7A6mPXAh7f+rZ3FNC7XkcxeSCprgTgL12SdICBLVYSul4hfTSgMvHRFStF7/pWei qU2/9sgOavZsJmo8MUn9AElpK30S7hjcH6uXCQE5oCZ48r/GnpbB/1ySwVb4O5Ugp1XA NHHXcK8s+KhGmRSxYZiY/DdQrtY9bIcZiipSgjAwiJBJPnRWcpfkJBmgklPPyNqJpG4T zkEan55kWjLR5ZITBiHTr8BOfKXlRRdxDbOj8lM0w4VXdVG9dsReQnWA0cTRnJzzhpDP 1d160Kxbc8NhVWN7oqEwypf2t/XrizZ0yIdqoqpGCoewwg2QFGKJDm+a9odWr8nlg9PG /sPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2i3I1X+4Fx86xDUOZC46T5gqNZBA/9GqlhFqUY2tgp0=; fh=lp0ld0o1dnZxzl0W1ZfdpM4aDSZxDiT6uFzPyBaBiJw=; b=sg7LxjwgcyqHE4VoDoxU+8fHKnmuuznWgO1iFnLnC8ZHeN41RisrrPeEONjwH1dCLY DcazFIOhj8llz0sBx4hZ6fcbTSj0EmuY7dSePZqr4BHPHHaKvLddfzJq522MjQFho5LE bFUxnuo+xR6mFn9Qc84AgNaQE7wsuNd1EFlln8Z+J5r3d5AjgboMmLLD5WibMPjz1mou FFWHNPRmSWrZix9Teo7rHgxX+Fn7RBtMYnDaQVVTedS53/jXsqEL4kNG0wRJHDauV9jx dW1ZD92HytW0GigR2UQ23cZvTKh3rhxxVgHwunEAaMJBg8htneFIbs1w+9MuZdc2Uw9f 4McQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=MWjR5HVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id d12-20020a170903230c00b001c06b9e10a1si8809782plh.248.2023.09.12.12.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 12:21:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=MWjR5HVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 888C5825024D; Tue, 12 Sep 2023 03:02:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232412AbjILKCu (ORCPT + 99 others); Tue, 12 Sep 2023 06:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231313AbjILKCr (ORCPT ); Tue, 12 Sep 2023 06:02:47 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B3AE64; Tue, 12 Sep 2023 03:02:43 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CD253660731E; Tue, 12 Sep 2023 11:02:40 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694512961; bh=KFTpQC/A7VUsLib15J+EGZdvXTKuNhYXeMQivKrdSI4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MWjR5HVJefu2d4j7QZ0QOiJcsTAnJWDAsEhh96ZUoKmFmE85LCwH4TZiwnt328dGv q3MAI7VoMfghswBvo4j8oz+XvpY1nRW1m5LQI3DKbo3iUSDyR2JR961AFoSWJE5sNs +bQoFCHrGVvtNmcrwlfpPwZ40mT32rRu+yvNJWf+AoDK/0aOHrU2DklbjZIf19O42U Tais/Ygi8W1NYC/qUPa/L/XGSzPSOUOfKIeOxSEy6mPA8uBq/6LptDEH9SY6tRhafY It7g9YntFnTIAULfP29C9jywUuz0+LIvmayOhqjzxf96XWiKgixbI1xMJcOKFxCKWM aDeo2JBarstdw== Message-ID: <250a4a3a-cc70-7541-aa49-ec15b8d3e122@collabora.com> Date: Tue, 12 Sep 2023 12:02:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 5/5] clk: mediatek: clk-mt7629: Add check for mtk_alloc_clk_data Content-Language: en-US To: Jiasheng Jiang , mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org, msp@baylibre.com, amergnat@baylibre.com, frank.li@vivo.com, robh@kernel.org, owen.chen@mediatek.com, mars.cheng@mediatek.com, macpaul.lin@mediatek.com, cw00.choi@samsung.com, u.kleine-koenig@pengutronix.de, wendell.lin@mediatek.com, luca.ceresoli@bootlin.com, kevin-cw.chen@mediatek.com, ryder.lee@mediatek.com, wenzhen.yu@mediatek.com Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230912093407.21505-1-jiasheng@iscas.ac.cn> <20230912093407.21505-5-jiasheng@iscas.ac.cn> From: AngeloGioacchino Del Regno In-Reply-To: <20230912093407.21505-5-jiasheng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 03:02:57 -0700 (PDT) X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Il 12/09/23 11:34, Jiasheng Jiang ha scritto: > Add the check for the return value of mtk_alloc_clk_data() in order to > avoid NULL pointer dereference. > > Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC") > Signed-off-by: Jiasheng Jiang Reviewed-by: AngeloGioacchino Del Regno