Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <000000000000f392a60604a65085@google.com> <ZP/3hgDCXeceE9uU@casper.infradead.org>
 <ZQB76G/6NxVgoE9u@casper.infradead.org> <CAJuCfpGEa504z1pgqR9KtCWQPESTcRcu8xoyxcNOv=6t4R+ong@mail.gmail.com>
In-Reply-To: <CAJuCfpGEa504z1pgqR9KtCWQPESTcRcu8xoyxcNOv=6t4R+ong@mail.gmail.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Tue, 12 Sep 2023 09:00:53 -0700
Message-ID: <CAJuCfpHYNbH0WmfDnpX6eqL3f3Z632iQrcw6oqPXtB0_QjaiiQ@mail.gmail.com>
Subject: Re: [syzbot] [mm?] kernel BUG in vma_replace_policy
To:     Matthew Wilcox <willy@infradead.org>
Cc:     syzbot <syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com>,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 12, 2023 at 8:03=E2=80=AFAM Suren Baghdasaryan <surenb@google.c=
om> wrote:
>
> On Tue, Sep 12, 2023 at 7:55=E2=80=AFAM Matthew Wilcox <willy@infradead.o=
rg> wrote:
> >
> > On Tue, Sep 12, 2023 at 06:30:46AM +0100, Matthew Wilcox wrote:
> > > On Tue, Sep 05, 2023 at 06:03:49PM -0700, syzbot wrote:
> > > > Hello,
> > > >
> > > > syzbot found the following issue on:
> > > >
> > > > HEAD commit:    a47fc304d2b6 Add linux-next specific files for 2023=
0831
> > > > git tree:       linux-next
> > > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D16502dd=
ba80000
> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=3D6ecd2a7=
4f20953b9
> > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3Db591856e0=
f0139f83023
> > > > compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils=
 for Debian) 2.40
> > > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D120e7=
d70680000
> > > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D1523f9c=
0680000
> > > >
> > > > Downloadable assets:
> > > > disk image: https://storage.googleapis.com/syzbot-assets/b2e8f42175=
27/disk-a47fc304.raw.xz
> > > > vmlinux: https://storage.googleapis.com/syzbot-assets/ed6cdcc09339/=
vmlinux-a47fc304.xz
> > > > kernel image: https://storage.googleapis.com/syzbot-assets/bd9b2475=
bf5a/bzImage-a47fc304.xz
> > > >
> > > > IMPORTANT: if you fix the issue, please add the following tag to th=
e commit:
> > > > Reported-by: syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com
> > >
> > > #syz test
> > >
> > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> > > index 42b5567e3773..90ad5fe60824 100644
> > > --- a/mm/mempolicy.c
> > > +++ b/mm/mempolicy.c
> > > @@ -1342,6 +1342,7 @@ static long do_mbind(unsigned long start, unsig=
ned long len,
> > >       vma_iter_init(&vmi, mm, start);
> > >       prev =3D vma_prev(&vmi);
> > >       for_each_vma_range(vmi, vma, end) {
> > > +             vma_start_write(vma);
> > >               err =3D mbind_range(&vmi, vma, &prev, start, end, new);
> > >               if (err)
> > >                       break;
> >
> > Suren, can you take a look at this?  The VMA should be locked by the
> > call to queue_pages_range(), but by the time we get to here, the VMA
> > isn't locked.  I don't see anywhere that we cycle the mmap_lock (which
> > would unlock the VMA), but I could have missed something.  The two
> > VMA walks should walk over the same set of VMAs.  Certainly the VMA
> > being dumped should have been locked by the pagewalk:

Yeah, this looks strange. queue_pages_range() should have locked all
the vmas and the tree can't change since we are holding mmap_lock for
write. I'll try to reproduce later today and see what's going on.

>
> Sure, I'll look into this today. Somehow this report slipped by me
> unnoticed. Thanks!
>
> >
> >  vma ffff888077381a00 start 0000000020c2a000 end 0000000021000000 mm ff=
ff8880258a8980
> >  prot 25 anon_vma 0000000000000000 vm_ops 0000000000000000
> >  pgoff 20c2a file 0000000000000000 private_data 0000000000000000
> >  flags: 0x8100077(read|write|exec|mayread|maywrite|mayexec|account|soft=
dirty)
> >
> >   syscall(__NR_mbind, /*addr=3D*/0x20400000ul, /*len=3D*/0xc00000ul, /*=
mode=3D*/4ul,
> >           /*nodemask=3D*/0ul, /*maxnode=3D*/0ul, /*flags=3D*/3ul);
> >
> > 20400000 + c00000 should overlap 20c2a000-21000000