Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2812029rdb; Tue, 12 Sep 2023 12:51:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHstNMMhcyZq3IjC4/xbmx7jZ8eIYHJfwq15uJhhK2YBQ2TGSWW+s4CLS6kPbNETDdpVPNc X-Received: by 2002:a17:90b:4f4a:b0:268:b66b:d9f6 with SMTP id pj10-20020a17090b4f4a00b00268b66bd9f6mr263765pjb.18.1694548287491; Tue, 12 Sep 2023 12:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694548287; cv=none; d=google.com; s=arc-20160816; b=UeC30+4XJywv5+RWYynmJ9DR4IXbxr0gVLgOJPjmLhNg93grrE4KAyb3c4ssxNlS9n RCpPgTf6N4KVBZNwbutZPGthrWyHkgJrukYwxssUTMoaZcuRCcvzacuua86H2bpVRf3X tHe09KEAzSWUXhTduAtxsoUCMtubJ5ZeeDYg7vUOmE/0E6t28RfQd+wntJRJ6Q4D4xgL FRJYOL6JXR622NBOAZ8HXK9+TlyYaE+LbsgGolf7tXdH5uHCL2+kDwO6NhH3HcnYp1ug 2qSFmg4mdionMqasDIYf29UhQ9uLwAkJgTwyZ++SRv66QJOcxkEl9NJyWKBrYYM1Krf9 YLRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=JVk5eGuDfgVHDM0pGgUJbtkfG29nSNa44eDk7qo/ifQ=; fh=1SP1+g3qsw879Fzd452Sfec6P7r4izxFb3ZqoNJIDB8=; b=j080Gmiaq0+OzDBwl5gy2DGfB4Bhm0qQDTtGv7BBnW+YCfEP1DPAqUcSowHSuSH6GT LlhxABImYkpzV7YV8prWMZl32KGziZNWu+7ymIYyinQ/XHtWOm08cfnD4DrtlZJlUEDw W5gXsekzdNC5/+ZLuEAaH9xJJKS1+vfBwHk/6GUrSQiisJ6svPy3/USuvqsmWGT7FKDh W2pARrIwd3jaHoQ36fnkmg0JGSXZFZr7SZINFC8tP4VgA2bnXgjhlTnT4hv970d+nYo5 hZn3QQydLN/5/YgYQszOfiHbgLLoitMYlcqsxveVYJiZgJPQQo2YicE1qioqNQU/3kWa IJPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=HKuXR3to; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id ch1-20020a17090af40100b002597ed3cc4fsi8256049pjb.189.2023.09.12.12.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 12:51:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=HKuXR3to; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3DE558148BAD; Tue, 12 Sep 2023 08:36:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233996AbjILPgE (ORCPT + 99 others); Tue, 12 Sep 2023 11:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236248AbjILPgD (ORCPT ); Tue, 12 Sep 2023 11:36:03 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE5DE10E5 for ; Tue, 12 Sep 2023 08:35:59 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-34f17290a9cso6838865ab.1 for ; Tue, 12 Sep 2023 08:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1694532959; x=1695137759; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JVk5eGuDfgVHDM0pGgUJbtkfG29nSNa44eDk7qo/ifQ=; b=HKuXR3toS/pSfem9j6rXiya1e1FBp1FCZA0U3zpVBSFohCjZfIvO2ZfeNbuvCd7/QY mskbPJjZ3P49mlprgLQzPk28YHOfyJMvEPPBpBCJPAGhk4kG/FEOImCF5e4QhUqu8xXy He9BG+x2wZd1tQi5KlksrmaHrhs6cWp5us4u8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694532959; x=1695137759; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVk5eGuDfgVHDM0pGgUJbtkfG29nSNa44eDk7qo/ifQ=; b=vs6gihqjfsdn6YjIGtpkn/mUu+wyWyJQUol53nvFYCI+Fre2UWg2QyCJ2/5Ht7ZI0k Pa2P49HHJeXx5zfN9UHxee6y4XrjD72cMSE3eAVAWrGMYQXvdXKKKRfWZCwJETwVV6oN cDVq6lqu7sDXo4VhjCf+Ttg8qJJi5NSfwoD5ZXxvONt4z4KE24u0cHLHQ8Mc5zOOJ8vt bkfYgduOOlgYyFgQ/eMhvFMFDB/hqp0uS7TFz9U8WNJMUYoqrHQ8AxiDOWaqfPn+WR88 Zw9FFFpcpJPMRt+sQrl5Z/BVU2M/gjIBTE+4lzDRfWzbmSax0V7xXurO1COKZrgGV03M HNKA== X-Gm-Message-State: AOJu0Yx7XESieqD6Z6GQbzTKxD2Lq4emZerocUXHpM1PkTNsIERcJGFW qPuvsQqYSBzJFsOHI8kPVbBqJQ== X-Received: by 2002:a92:cc4f:0:b0:34f:2e07:685b with SMTP id t15-20020a92cc4f000000b0034f2e07685bmr13596154ilq.0.1694532959145; Tue, 12 Sep 2023 08:35:59 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id o16-20020a92dad0000000b0034f33615fc6sm3178884ilq.11.2023.09.12.08.35.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Sep 2023 08:35:58 -0700 (PDT) Message-ID: <49f6d44b-b6e8-bfca-1df7-3ab94684902e@linuxfoundation.org> Date: Tue, 12 Sep 2023 09:35:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment To: Steven Rostedt , "Masami Hiramatsu (Google)" Cc: Shuah Khan , Mark Brown , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <169448103881.242465.4589561134225171701.stgit@devnote2> <20230911212453.58b9082a@gandalf.local.home> Content-Language: en-US From: Shuah Khan In-Reply-To: <20230911212453.58b9082a@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 08:36:05 -0700 (PDT) X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email On 9/11/23 19:24, Steven Rostedt wrote: > On Tue, 12 Sep 2023 10:10:39 +0900 > "Masami Hiramatsu (Google)" wrote: > >> From: Masami Hiramatsu (Google) >> >> Fix to unmount the tracefs if the ftracetest mounted it for recovering >> system environment. If the tracefs is already mounted, this does nothing. >> >> Suggested-by: Mark Brown >> Link: https://lore.kernel.org/all/29fce076-746c-4650-8358-b4e0fa215cf7@sirena.org.uk/ >> Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel") >> Signed-off-by: Masami Hiramatsu (Google) >> --- >> Changes in v2: >> - use -n option explictly for testing the string is non-zero. >> --- >> tool > > Reviewed-by: Steven Rostedt (Google) > > -- Steve Thank you all. Applied to linux-kselftest fixes branch for next rc thanks, -- Shuah