Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <4c99c180-3b79-6aef-6ff2-d430e575957d@baylibre.com>
Date:   Tue, 12 Sep 2023 15:10:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Rob Herring <robh@kernel.org>, soc@kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
References: <20230804225813.12493-1-robh@kernel.org>
 <f8759d51-f808-8082-ceaf-6c6dcaebe2d9@collabora.com>
Content-Language: en-US
From:   Alexandre Mergnat <amergnat@baylibre.com>
In-Reply-To: <f8759d51-f808-8082-ceaf-6c6dcaebe2d9@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 12/09/2023 14:54, AngeloGioacchino Del Regno wrote:
> Il 05/08/23 00:58, Rob Herring ha scritto:
>> The defined value for "status" is "disabled", not "disable".
>>
>> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
>> Reviewed-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@collabora.com>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Arnd, Please take this directly I guess. I think Mediatek maintainership
>> needs some help. Maybe AngeloGioacchino should be co-maintainer as
>> that's the only response I seem to be getting.
> 
> Sorry but I've seen this message just now as I've been on holiday in 
> August.
> 
> Thing is, the MediaTek scene is starting to see more and more code, 
> bringing
> an obvious increase in the amount of reviews to be done and in the required
> efforts to maintain the MTK bits - and we will possibly (hopefully) see 
> even
> more of that.
> 
> If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be
> proud to become one.
> 
> Cheers,
> Angelo
> 

I started reviewing MediaTek patches for some months now, so I'm still 
new. From my PoV, I'm agree with Angelo when he say the amount of patch 
is increasing. I support Angelo if he wants to become a co-maintainer 
and continue to do my best to review patches. ;)

>>
>> I think for future .dts patches I will not bother splitting them up by
>> sub-arch because it's a pain to chase down the maintainers to apply
>> stuff in a timely manner. /rant
>>
>>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts 
>> b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> index e4605d23fdc8..86cedb0bf1a9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> @@ -585,11 +585,11 @@ &pwrap {
>>   };
>>   &sata {
>> -    status = "disable";
>> +    status = "disabled";
>>   };
>>   &sata_phy {
>> -    status = "disable";
>> +    status = "disabled";
>>   };
>>   &spi0 {
> 
> 

-- 
Regards,
Alexandre