Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <2c532d4594ca0cacdc0cfc5d1f5d55d5d758dc1b.camel@redhat.com>
Subject: Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG
From:   Paolo Abeni <pabeni@redhat.com>
To:     Shinas Rasheed <srasheed@marvell.com>, horms@kernel.org
Cc:     aayarekar@marvell.com, davem@davemloft.net, edumazet@google.com,
        egallen@redhat.com, hgani@marvell.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, mschmidt@redhat.com,
        netdev@vger.kernel.org, sburla@marvell.com, sedara@marvell.com,
        vburru@marvell.com, vimleshk@marvell.com
Date:   Tue, 12 Sep 2023 10:45:21 +0200
In-Reply-To: <20230912070400.2136431-1-srasheed@marvell.com>
References: <20230911180113.GA113013@kernel.org>
         <20230912070400.2136431-1-srasheed@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-09-12 at 00:04 -0700, Shinas Rasheed wrote:
> This change is required in octep_iq_process_completions, as given in the =
patch,
> since the scatter gather pointer lengths arrive as big-endian in hardware=
.

I guess Simon intended asking about octep_iq_free_pending(), and AFAICT
your reply confirm that the change is required there, too.

Additionally the changelog really need to be expanded. I don't
understand how this change relates to endianess: if the ring format is
big endian I expect some be16_to_cpu(len) instead of complement-to-4 of
indexes.

Please clarify and expand the changelog, thanks!

Paolo