Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 12 Sep 2023 22:38:21 +0200
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
CC:     Fabien Parent <fparent@baylibre.com>,
        Amjad Ouled-Ameur <aouledameur@baylibre.com>,
        Daniel Golle <daniel@makrotopia.org>,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Alex Riabchenko <d3adme4t@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Subject: =?US-ASCII?Q?Re=3A_regression_with_33140e668b10_thermal/driv?= =?US-ASCII?Q?ers/mediatek=3A_Control_buffer_enablement_tweaks?=
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <20230912134617.jwonuolt56nofifz@blmsp>
References: <trinity-6713557b-fe0a-4dae-84aa-1aa86f7619fa-1693473911557@3c-app-gmx-bs12> <trinity-f3e7d8e0-2e93-4e84-a489-3993c819d2c3-1693488871086@3c-app-gmx-bs12> <07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org> <20230912134617.jwonuolt56nofifz@blmsp>
Message-ID: <B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:VPrnAZmP0ik=;VULxiDso5UE0QCU2TeetDf3PdzQ
 tkpZWPGMVbtyqTXztpQsFJb7u+WpZDIpgzJ2M7AE78vWisERmtONJNiX7eJSeHEt7knn/UQ/s
 IvGW9SSBStGsuLgy8yhmUDO4qPCxrgJroWGUltJJbCcmzsMg/v2NdMjZltRBN/u1B7Gr5lCnK
 unpfU4IFqQhfa+5tPogjg41soATo//4d7q3fLotuE4/0l+f1OhwMAH8+mU8iB5e6tP6EyeJeV
 V+rPlc6K0NuNrkYsFHOuW8OvDdKD7e4RbTOCzSBEEJQjqUzEEZ4nSLSvToKVGrElde36iEWwz
 uDtlbNKkDrs5VUeF8X0dI7sC7ZbaSSRxKyTMSyp4SioTqx4xTe+D39dk1L5YsOymeBH4a1vXo
 QU/98YzRAeP/JBncwREPN7PQTJGd0pe5RP4UpuASKA1y288q/im6KiUa1oxXjKrLEAzZ/WvtR
 Y6TBSp3TQkE4cjYHikcXFMQgvzYs1h1F/Lvb6S5IF9LtBFqqcC0ZGdxhp6+r/sbTHlxUPpJp9
 YrU0aMhhB7sP1ZVD6VKbpxKX1K59xOJUQPCdPmNpxsrdxc0+Q5+N3gWkQ2htiHHz4/Rsz1xWG
 ekl4hO+zTpsax51MAqn/ghycG0SPm0y/E49dTNdPwY4T9LfC+fERiCukGjhtF3P96N4wmPkma
 WUAEeIHKUtmOgmhqkJKLYDn1SF+Xpv2vJZQNWcz2vBKZR+KSCRO2z3mxwGhH2EwkXYrvGewO6
 OIesC5UIMj17DdsLbBppQqZT5oAcXN3CFfYgSbqLlV9HHdQgVjHCzvvXQClr/6pkr8vwo0WYA
 jEmQVznHGU2TYlD8JwnkV3yIGGiHafMu+OhSbBuJKlW5JJnRVWj9bssW1bszFK1X5YA7Kl6/i
 PXQWVj9mQ7JQtG7AmzkMgOJYukoC+jjlJP4c6oB2ERRNhHzsXrhNXnh/4bWlCB1ibMMYIvoxN
 mdtlp181luHyp0qbnatRMokPcVU=
Precedence: bulk

Am 12=2E September 2023 15:46:17 MESZ schrieb Markus Schneider-Pargmann <ms=
p@baylibre=2Ecom>:
>Hi Frank and Daniel,
>
>On Tue, Sep 12, 2023 at 02:57:45PM +0200, Daniel Lezcano wrote:
>>=20
>> Hi Frank,
>>=20
>> thanks for reporting and investigating the issue=2E
>>=20
>>=20
>> On 31/08/2023 15:34, Frank Wunderlich wrote:
>> > Hi,
>> >=20
>> > looked a bit deeper into it and it looks like i only need to add the =
fields in the mtk_thermal_data struct
>> >=20
>> > --- a/drivers/thermal/mediatek/auxadc_thermal=2Ec
>> > +++ b/drivers/thermal/mediatek/auxadc_thermal=2Ec
>> > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_therm=
al_data =3D {
>> >          =2Eadcpnp =3D mt7986_adcpnp,
>> >          =2Esensor_mux_values =3D mt7986_mux_values,
>> >          =2Eversion =3D MTK_THERMAL_V3,
>> > +       =2Eapmixed_buffer_ctl_reg =3D APMIXED_SYS_TS_CON1,
>> > +       =2Eapmixed_buffer_ctl_mask =3D GENMASK(31, 6) | BIT(3),
>> > +       =2Eapmixed_buffer_ctl_set =3D BIT(0),
>> >   };
>> >=20
>> > in my quick test the temprature can be read again and i'm near room t=
emperature=2E=2E=2Ei though it was a bit higher before, but as far as i und=
erstand the code, the values were fixed before and only made it configurabl=
e=2E
>> >=20
>> > if someone can confirm that i'm right, i can send official patch=2E
>
>Sorry for the delay, this was in my inbox but somehow not on my todo
>list=2E
>
>The patch looks correct=2E I think I simply missed adding the fields for
>MTK_THERMAL_V3 chips=2E Sorry!
>
>>=20
>> At the first glance, it seems the proposed change is correct and could =
be
>> proposed as a hot fix=2E
>>=20
>> However, the conditions with the version and the apmixed_buffer_ctl_reg
>> looks a bit fuzzy=2E
>>=20
>> Markus, can you revisit this part of code and consolidate the configura=
ble
>> approach ?
>
>Yes, it indeed looks like I broke another condition there=2E I will give
>it another close look and send a fix=2E
>
>Best,
>Markus

Hi

I already sent the Patch below

https://patchwork=2Ekernel=2Eorg/project/linux-mediatek/patch/202309071120=
18=2E52811-1-linux@fw-web=2Ede/

If it is correct (handled the same way as mt7622 before) you have not to s=
end a patch=2E

But you should maybe check condition !=3DV2 is correct when loocking on v3=
=2E

https://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/torvalds/linux=2Egit/c=
ommit/drivers/thermal/mediatek/auxadc_thermal=2Ec?id=3D33140e668b10200b7757=
79f302b143b32e6ae7ca

Regards Frank