Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 12 Sep 2023 23:52:09 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>
CC:     Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC Patch 1/3] mm/slub: increase the maximum slab order to 4
 for big systems
Message-ID: <ZQCJKUz37HTnPTtT@feng-clx>
References: <20230905141348.32946-1-feng.tang@intel.com>
 <20230905141348.32946-2-feng.tang@intel.com>
 <CAB=+i9SP2j=VEDi52ga0WgPWSeDzdmTYisA4PAnR26Natp3swA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAB=+i9SP2j=VEDi52ga0WgPWSeDzdmTYisA4PAnR26Natp3swA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUhReWlyQUZ6NmN1QThnSFlPOXhZKzd1ZnR5c3dadDhJVkdpY1JYQU1rR1dR?=
 =?utf-8?B?dFIzM3FiSkx2cG01bmN3UU1SYWtOVjNXdkorM01JaTNpQW5XWHJrU1B5Rjhh?=
 =?utf-8?B?Q1Z4RTBaM2xnWHRpdW81MlFZb0pkKzhuNHVOc0hoUnRvaW9TZzNEcGJnbHhB?=
 =?utf-8?B?MFhPbC9HUzdZS1J1R1cvTWkvZkpleHhKYTBYR0lkOCtCUzhsOUZYTWNlcXZu?=
 =?utf-8?B?TXFjL1J2Z1p6ajdrc0xHQ1hTeGNFWUp0WmR6LzJZTnBJd1RtZzZ5cFFKemRK?=
 =?utf-8?B?cE1FUW9uSStlSkU2NXdvbHdMbzYwNWh5b3JITnJPRHdhZ0tYeSs0N25vWTJD?=
 =?utf-8?B?NFdRUi8vT3h4QjhCYi8xeEpnYnRVVUxub0xVbHhPUDRuTVUxdGo0dUs1dUN4?=
 =?utf-8?B?VnJMWkQzSTBsaU1iWjNKOXBaaWdORERCbTRrcGtjUDdZaWlOS0RvN1ZjQWpV?=
 =?utf-8?B?QUs2aXB2MitYMGtzeVREOGNySVZCNUl6c0QzeTU3ZFhXVVdoclBFb0RsUFdo?=
 =?utf-8?B?SURzVHNxbGtwNVNxTGl1d0NYUHRrRHRRNWV3WWJzQXBhMFovUEcwcHZrTHVU?=
 =?utf-8?B?SHBzMytMcGs1d0k4bGdseEM2VWpYS2JQUFh0UmZ3ZlNybngremZWOUlFa3hv?=
 =?utf-8?B?bkQydTFwbTJnVlQ3Nm51RUNRdVkvcnVWTmVOWjFBTXVTazZWVUZwQkxRWDFk?=
 =?utf-8?B?a2hwcG9sQWhvWjBnTldkL24rcU9SSnA4dFdUU0NSQmozQnJIWU1mcEx4cU1l?=
 =?utf-8?B?alYyYTd4aGpGRkFRTVlsRGZnR2NEbnp2Vlk4UGZDRlRhaGpWekxpQ1VHUDJQ?=
 =?utf-8?B?b3VkYzg0d3FNa2pwRmF0UjJsa08wSVRjT0MyMUNWMTZteVM0WHp1dXhTeGYw?=
 =?utf-8?B?cVVhZ1ljQ2xMMnZxWFpHWFdXUUdKcGVtc0szVzdPYmo0UDdpWW1kWjBnTDJJ?=
 =?utf-8?B?UjBScVF1UHY0TDcyMVd5dW9TL3l0ZE8vOXVPWGtBNVllTEhlRFQ5RFJYSVJX?=
 =?utf-8?B?YldQaStRY21kYm9wNzRPdVhtREhjeWpUTzB0WGQvd3pMNEFEZnpwM3laa0d4?=
 =?utf-8?B?QjVWSEo5cDAydkYxWkY3NDB3SXEyZ0ZYbkZ0d3F0V21KUnl4eGRtY2Jrei9R?=
 =?utf-8?B?RzArNkdjR1ArTXJ0aHFsa2NoK2Q3TXNaSkZFOHIyYytla0FYYzRrdGFlanha?=
 =?utf-8?B?NWNUcmluWkpsTzk1YlJkV3VPWk1SMXBTTkxoWVcyNk9rWDRGaDNFeUNHb3M5?=
 =?utf-8?B?T1I0RzhhSisrajVPVFdYajQzT1N5ZnpYRzNMQThGb3FtNEtJQ0g0YlJ0RUxX?=
 =?utf-8?B?bDcybHFIU29VcWhpTWM5QnplbFpINzdjOGgwc0RnQXZsY0ViOWZQM25QQUo0?=
 =?utf-8?B?OW1QR2xGOVlEbk5MS3I4R0xHV3BtRDhscVFYbGJFVjhmUEV4WXZzS3dhRGxo?=
 =?utf-8?B?TUVGR0NxdUtHUllscE5DNWJ1TlFZNFR0L001eW9jOUZFeG9KVXdiV0krMDd1?=
 =?utf-8?B?YU40eG1LWjBYUGx4K2YvNmxCRnBVdis3K29kRVJHMG0xY0xHS2dsQVJTbElm?=
 =?utf-8?B?WC9lak5kbjc4aDRqRHgrbFoxS0dPdkplbFV2VzNvajIvZit6QkNBTDBzd3pp?=
 =?utf-8?B?Z0VFdmN4R2xQSU9lcXo1dDBQQVBPdnlvUzBNUVdyTTlZY0NpMHY5WVJCdWdT?=
 =?utf-8?B?ZnA5ZHJNeXRield2UTBCZnAxVjY2alN3emQ1OHNRMktCNTJrUU9hSCs1bHh5?=
 =?utf-8?B?K3ZGallwcHQ2VXcxV1ZNWndPbmQ1cDJwYklHSWZ0bjFSUE5mVjRSQ1I1YTZX?=
 =?utf-8?B?UVAxdVBvUEZCYnpvY2d0dUo2VFhuMnVObVZIOW1RSE1paXczY1FZUis0THZv?=
 =?utf-8?B?R2o3dlNsaGFpU29SVUllaUpNNHpGQkxsUkw4WDNCSUEwbkcrYnR5ZTJXenRk?=
 =?utf-8?B?SGJDR0ttd1IrTWNJOEdFNnMrL0k5RkFhK1VPQk9KQWUxNG82OTdWWThYUkNG?=
 =?utf-8?B?eUJnaE1xVnNRZTR3eEwvdTVPQTF6bVlpbmJ0YTVIb1Vzay9FWE10aWZTeFB5?=
 =?utf-8?B?aFZyL0hpL0Fya1pwWUEwYkdTZUF1SFdvV2pDaEhQS2hsdzlqQ3lCWTBEeUR0?=
 =?utf-8?Q?OM0boFe5FFBOR21mjuwXXwfgW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 233ea5e0-ae82-4201-e819-08dbb3a98dfb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 16:01:41.9085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y1k6cajq2V0vYDGPeFK5L3g1ubTLyD34MCj88mfioPR944yrtIT5z3DqDijap0k5sAoRIBPc7jP5hO3ljfOuwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6234
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 09:05:04 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

Hi Hyeonggon,

Many thanks for the review!

On Tue, Sep 12, 2023 at 01:52:19PM +0900, Hyeonggon Yoo wrote:
> On Tue, Sep 5, 2023 at 11:07 PM Feng Tang <feng.tang@intel.com> wrote:
> >
> > There are reports about severe lock contention for slub's per-node
> > 'list_lock' in 'hackbench' test, [1][2], on server systems. And
> > similar contention is also seen when running 'mmap1' case of
> > will-it-scale on big systems. As the trend is one processor (socket)
> > will have more and more CPUs (100+, 200+), the contention could be
> > much more severe and becomes a scalability issue.
> >
> > One way to help reducing the contention is to increase the maximum
> > slab order from 3 to 4, for big systems.
> 
> Hello Feng,
> 
> Increasing order with a higher number of CPUs (and so with more
> memory) makes sense to me.
> IIUC the contention here becomes worse when the number of slabs
> increases, so it makes sense to
> decrease the number of slabs by increasing order.
> 
> By the way, my silly question here is:
> In the first place, is it worth taking 1/2 of s->cpu_partial_slabs in
> the slowpath when slab is frequently used?
> wouldn't the cpu partial slab list be re-filled again by free if free
> operations are frequently performed?

My understanding is the contention is related to the number of
objects for each cpu (the current slab and on the per-cpu partial
list), if it's easier to be used up, then the per-node lock will be
contended.

This patch increase the order (I should have also considered the
CPU number), while keeping the per-cpu partial numbers unchanged,
as it doubles the 'nr_objects' in set_cpu_partial().

But the 2/3 patch only increases the per-cpu partial number, and
keeps the order unchanged. From the performance data in cover
letter, 1/3 and 2/3 can individually reduce the contention for
will-it-scale/mmap1, as they both increase the available per-cpu
object numbers. 

> 
> > Unconditionally increasing the order could  bring trouble to client
> > devices with very limited size of memory, which may care more about
> > memory footprint, also allocating order 4 page could be harder under
> > memory pressure. So the increase will only be done for big systems
> > like servers, which usually are equipped with plenty of memory and
> > easier to hit lock contention issues.
> 
> Also, does it make sense not to increase the order when PAGE_SIZE > 4096?

Good point! Some other discussion  on mm list earlier this week
also reminded me that there are ARCHs supporting bigger pages like
64KB, and these patches needs to consider more about it.

> > Following is some performance data:
> >
> > will-it-scale/mmap1
> > -------------------
> > Run will-it-scale benchmark's 'mmap1' test case on a 2 socket Sapphire
> > Rapids server (112 cores / 224 threads) with 256 GB DRAM, run 3
> > configurations with parallel test threads of 25%, 50% and 100% of
> > number of CPUs, and the data is (base is vanilla v6.5 kernel):
> >
> >                      base                      base+patch
> > wis-mmap1-25%       223670           +33.3%     298205        per_process_ops
> > wis-mmap1-50%       186020           +51.8%     282383        per_process_ops
> > wis-mmap1-100%       89200           +65.0%     147139        per_process_ops
> >
> > Take the perf-profile comparasion of 50% test case, the lock contention
> > is greatly reduced:
> >
> >       43.80           -30.8       13.04       pp.self.native_queued_spin_lock_slowpath
> >       0.85            -0.2        0.65        pp.self.___slab_alloc
> >       0.41            -0.1        0.27        pp.self.__unfreeze_partials
> >       0.20 ±  2%      -0.1        0.12 ±  4%  pp.self.get_any_partial
> >
> > hackbench
> > ---------
> >
> > Run same hackbench testcase  mentioned in [1], use same HW/SW as will-it-scale:
> >
> >                      base                      base+patch
> > hackbench           759951           +10.5%     839601        hackbench.throughput
> >
> > perf-profile diff:
> >      22.20 ±  3%     -15.2        7.05        pp.self.native_queued_spin_lock_slowpath
> >       0.82            -0.2        0.59        pp.self.___slab_alloc
> >       0.33            -0.2        0.13        pp.self.__unfreeze_partials
> >
> > [1]. https://lore.kernel.org/all/202307172140.3b34825a-oliver.sang@intel.com/
> > [2]. ttps://lore.kernel.org/lkml/ZORaUsd+So+tnyMV@chenyu5-mobl2/
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> 
> > ---
> >  mm/slub.c | 51 ++++++++++++++++++++++++++++++++++++++-------------
> >  1 file changed, 38 insertions(+), 13 deletions(-)
> >
> > diff --git a/mm/slub.c b/mm/slub.c
> > index f7940048138c..09ae1ed642b7 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -4081,7 +4081,7 @@ EXPORT_SYMBOL(kmem_cache_alloc_bulk);
> >   */
> >  static unsigned int slub_min_order;
> >  static unsigned int slub_max_order =
> > -       IS_ENABLED(CONFIG_SLUB_TINY) ? 1 : PAGE_ALLOC_COSTLY_ORDER;
> > +       IS_ENABLED(CONFIG_SLUB_TINY) ? 1 : 4;
> >  static unsigned int slub_min_objects;
> >
> >  /*
> > @@ -4134,6 +4134,26 @@ static inline unsigned int calc_slab_order(unsigned int size,
> >         return order;
> >  }
>