Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Zi Yan <ziy@nvidia.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        "\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
        Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Kemeng Shi <shikemeng@huaweicloud.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Rohan Puri <rohan.puri15@gmail.com>,
        Mcgrof Chamberlain <mcgrof@kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        John Hubbard <jhubbard@nvidia.com>
Subject: Re: [RFC PATCH 1/4] mm/compaction: add support for >0 order folio
 memory compaction.
Date:   Tue, 12 Sep 2023 13:38:01 -0400
Message-ID: <6CE0050A-96A4-4AAB-8B59-52D079857AF2@nvidia.com>
In-Reply-To: <20230912173238.GB34089@cmpxchg.org>
References: <20230912162815.440749-1-zi.yan@sent.com>
 <20230912162815.440749-2-zi.yan@sent.com>
 <20230912173238.GB34089@cmpxchg.org>
Content-Type: multipart/signed;
 boundary="=_MailMate_B7E36759-7373-4F14-AD47-F738FBF4BB43_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q667gpLUSMd+J53c51jbwoxnwhKq+/rznkNCb0WVBwjE4tsZZc6mHd/9DEOM?=
 =?us-ascii?Q?jipmtJn9CxaGtCUjVZfbjoluBrNwTOBKfABoThowQ656IiHHeKnAUO6m3GOw?=
 =?us-ascii?Q?NqI2RksoHMt7J9OD/JBw0jV0LLtubKd9NMEKVFuiGKY1u4QyJ87JufXPY4+8?=
 =?us-ascii?Q?Cukmh3jmrqy6XLmUjqGCgL+IVjtgmYRDfo09RsaWBd/nFTx5EzDT0mCswyA4?=
 =?us-ascii?Q?jHt9em9xNjJzryOphE++WnOrAF5ZX5yu8uglcb2Fhzk4owAuv+YhoCWLpRNM?=
 =?us-ascii?Q?M4zFTJN+2dkeyOHZHlsoNAMhanudx/JL3FpEs1+Wnb5rIymhAJG9D+E8vCFy?=
 =?us-ascii?Q?uPBh8MzxLMPo1M4JgQ+s6koChs1r5J7CzmDAAbEgkWzo/Yg/1cZh7ijF8Er5?=
 =?us-ascii?Q?jtSg1wedd9PgJwDiGZGuNu92fqskGOMQW/2GvNJa0f/Lrhp5VGO8zS9FTz47?=
 =?us-ascii?Q?k4pMIuY3acrEEGIfe8FFH8e440j+xJC3cA/WiiJ5VfM9vw4FVCwZhvNBCNqv?=
 =?us-ascii?Q?YPUUAN5Suw10VLTgxZv/83eehas9pGDUHZRUKBhuVquntQVFEGZOPxqiZj3s?=
 =?us-ascii?Q?mZq2YjhEovg2XsCZto5N/Qj2/UG45qE6wV5f35tmKAoyQNRJh8scCdxElT8d?=
 =?us-ascii?Q?deuh5Q4pEoSFzYBaefxIzfGCP3f85YefPE4NbNCH+OdfqrMvUj34kjsjfwAG?=
 =?us-ascii?Q?zgewSqmRbR2bZ+1G3b9ogTW2RXdYhoyc4UrEZd48sUJyEz+A2FuqMuK4O48N?=
 =?us-ascii?Q?sGVLqfEB9ukq1gtjW7nQSZT9RWGl/Ib5Y5pFecnjNYtEemfQ3fTe1JYJI+6D?=
 =?us-ascii?Q?ra4xTRZ0RZh7+fNQj4v2VoHULvIZsUAHoldBdLKEAeumDGgJLAP93L35XCaD?=
 =?us-ascii?Q?j2xK/R9wkjpQPIk/zQkVUpLH45CB5jT9I6bijOjGZIQA6WPqdte0+GQAkWxU?=
 =?us-ascii?Q?lyO7EK0A4yMx34Qr/ogWxfHqhdx29WgIS6pEzo/Fen9vClU7rO86htNxfZZz?=
 =?us-ascii?Q?nGIGJ/OjPRZb6U7rPNV275jnLvfOa9uaD1JkKZz0HQp5FXhU4qnDS0g9UTkj?=
 =?us-ascii?Q?bLuOEU98TP/w812jbpyFq9qO8gYf2CQtqATwiVMgvs4noxWtUPovkunswJwl?=
 =?us-ascii?Q?Ei9aFj9PrveSJZUU+IXrLiZkuUTI825mA/+cXYfb8E9pTyXjuqFGnPLfemo9?=
 =?us-ascii?Q?D80AoPJ3zO87mPIgILXKpY73BIOAuE74OXLgbLqHLxUR549rKVM46OF9YsXa?=
 =?us-ascii?Q?070gVV2NztT/uRDC244ZEZGr640vBg+tk+ZtkxOQKZ/e4AOAVFNvSaGtp/Yv?=
 =?us-ascii?Q?nTDBbA5a3XlSUS00WeiFojpCnTvRtdC7I0l1TSdO7YXt6bxATZoUPVwciQA4?=
 =?us-ascii?Q?U4OsqsOIsu/zuOinhOVg+lrNfm7LKAoOb0Eflfz+J5PEW4pXmTcBkH7yb+tP?=
 =?us-ascii?Q?Z38kGdLDQ82avZ/hupzPot8xNoE0Bgx402v8GCjYFnRacCPKo71T/TsG9rY5?=
 =?us-ascii?Q?0x13ZihKfguJa52wKYtBvAgkCQa8/m4QsXtqLfc/EZxls00BMAQRbGGA7WTN?=
 =?us-ascii?Q?G8FVia2EJ9f1kjJB9yI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3460e67-c1af-4c7d-e16e-08dbb3b704de
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 17:38:04.6865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: alovku3c/DqYv7bZvmW3MvTmuACXn4DQocV+7YVLMT72KrDSga03C118lGbbFjfN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4277
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 10:38:25 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

--=_MailMate_B7E36759-7373-4F14-AD47-F738FBF4BB43_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 12 Sep 2023, at 13:32, Johannes Weiner wrote:

> On Tue, Sep 12, 2023 at 12:28:12PM -0400, Zi Yan wrote:
>> @@ -1439,7 +1478,8 @@ fast_isolate_around(struct compact_control *cc, =
unsigned long pfn)
>>  	if (!page)
>>  		return;
>>
>> -	isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, =
false);
>> +	isolate_freepages_block(cc, &start_pfn, end_pfn, &freelist, 1, false=
);
>> +	sort_free_pages(&freelist, cc->freepages);
>
> Can you make isolate_freepages_block() put the pages directly into a
> sorted struct free_list?
>
> AFAICS, the only place that doesn't technically need it is
> isolate_freepages_range(). But that's then also the sole caller of
> split_map_pages(), which can be made to work on struct free_list too
> without notable overhead.

Sure. Will do that in the next version.

--
Best Regards,
Yan, Zi

--=_MailMate_B7E36759-7373-4F14-AD47-F738FBF4BB43_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmUAofkPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUdNcP/0rJ09JTQPKlMfy8z01ocXab1YcmVOivHzui
ddpV/HsgpL4TGNB3jrqRfcSoBdMkG/0MwQEakUXgjWqxUjA/j3hInRO2K6XG2ln2
fqwByvUyzLKhAkGCnt5R7cUq+EVq+DdWg8QzfF/PXfhFRxuE8oWSV9fdGiF6CmdB
IwvTXGg5hF72MUCsX6POGOxttNP8LO/nFpPcZXCTW3NY96QqMY6ynzIicuw/F3ER
r6INaLOP1KcJR9RbKc8m+nb/M/EdJNRt8kySJc1h5BopxufW1ZcDz9cAM0tPnbvI
sF+AEHaq7vO4v52fBX0dcEFkQlTUkuRcM5S8e6rfOnVRy62/iJz/alQ9xXIr4vwi
mVc/luW4UGefEFfJt7CMNudRppqrZxkIuY0ZR1TnBVvlxFM6FxHqzJpQIKzehnQq
MV0bkveHaeXXHNOoQuIKTrw5HizpzNBOQLQGKPJzLg17KKc4UnKwniXnrZdMC0oF
PqtPqTyqXS4XZ9C//ir12TNh7pXlCafg+BDmewxRM21HLf7xUWxHB1xHx1noYNHG
Sou7OtEXtP0/yHt0FhiJjOscEfpL0OoKU/bGshKN5LdDgXXTwRuIHzNYyfVwn/il
iyv6m3CEO6wSRYfXxiAgedHwGL+f5HEf49skBJxpvWrd9wBMoObkdq/sIo7sSJQ2
uZE+WH13
=jp7u
-----END PGP SIGNATURE-----

--=_MailMate_B7E36759-7373-4F14-AD47-F738FBF4BB43_=--