Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <1d2d927d-6506-86fb-fc42-038d2d70c853@linux.intel.com>
Date:   Tue, 12 Sep 2023 13:39:56 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH 0/4] ASoC: cs35l56: Use PCI SSID to select specific
 firmware
Content-Language: en-US
To:     Richard Fitzgerald <rf@opensource.cirrus.com>, broonie@kernel.org,
        yung-chuan.liao@linux.intel.com, kai.vehmanen@linux.intel.com,
        peter.ujfalusi@linux.intel.com
Cc:     alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
        linux-kernel@vger.kernel.org
References: <20230912163207.3498161-1-rf@opensource.cirrus.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20230912163207.3498161-1-rf@opensource.cirrus.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/12/23 12:32, Richard Fitzgerald wrote:
> The PCI device registers contain a subsystem ID (SSID), that is
> separate from the silicon ID. The PCI specification defines it thus:
> 
> "They provide a mechanism for board vendors to distiguish their
>  boards from one another even thought the boards may have the same
>  PCI controller on them."
> 
> This allows the driver for the silicon part to apply board-speficic
> settings based on this SSID.
> 
> The CS35L56 driver uses this to select the correct firmware file for
> the board. The actual ID is part of the PCI register set of the
> host audio interface so this set of patches includes extracting the
> SSID from the Intel audio controller and passing it to the machine
> driver and then to ASoC components. Other PCI audio controllers
> will have the same SSID registers, so can use the same mechanism to
> pass the SSID.
> 
> Richard Fitzgerald (4):
>   ASoC: soc-card: Add storage for PCI SSID
>   ASoC: SOF: Pass PCI SSID to machine driver
>   ASoC: Intel: sof_sdw: Copy PCI SSID to struct snd_soc_card
>   ASoC: cs35l56: Use PCI SSID as the firmware UID

for the series

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>


> 
>  include/sound/soc-acpi.h         |  7 ++++++
>  include/sound/soc-card.h         | 37 ++++++++++++++++++++++++++++++++
>  include/sound/soc.h              | 11 ++++++++++
>  include/sound/sof.h              |  8 +++++++
>  sound/soc/codecs/cs35l56.c       | 11 ++++++++++
>  sound/soc/intel/boards/sof_sdw.c |  6 ++++++
>  sound/soc/sof/sof-audio.c        |  7 ++++++
>  sound/soc/sof/sof-pci-dev.c      |  8 +++++++
>  8 files changed, 95 insertions(+)
>