Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <a7f0dfb9-c841-b240-fca9-b908517a44d0@intel.com>
Date:   Tue, 12 Sep 2023 09:00:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH RESEND v3 1/2] selftests/resctrl: Fix schemata write error
 check
Content-Language: en-US
To:     =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
References: <cover.1693575451.git.maciej.wieczor-retman@intel.com>
 <960b5302cee8e5bb0e83dcf20cd2ef4d353b7b0b.1693575451.git.maciej.wieczor-retman@intel.com>
 <99eabc5c-f5e3-27dd-0a29-ad0cdb7b4239@intel.com>
 <sr6ana6d7ebtuxbhjuo6kcnhnn2zzvg3ivve6mndqeb3nxrzo7@mrfmtzlxlwdh>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <sr6ana6d7ebtuxbhjuo6kcnhnn2zzvg3ivve6mndqeb3nxrzo7@mrfmtzlxlwdh>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEFobTFMVHVrU2twVUsyczh0T1g4RUN1ZGdrTmdNQVB6UlJidmphVEdJeGU1?=
 =?utf-8?B?MmYrNGhSUW14MzJZUGcyby9WV2ptTEVjOE1YMUpnTUtmbnQ4VnF0ZFhkWUZU?=
 =?utf-8?B?Y1RBWjZMdGxOOU5jM2c4b21QdjBkM3JUbGl5TVEvL0wrRVZEQWlMMGowSW8r?=
 =?utf-8?B?VnAwNndhRFRVWnhnczNuL09BaFRsdGUvdnVmdDF6cmV5VXVjMlE4c1dkZith?=
 =?utf-8?B?ZkE2Rm9Ra0J6bmZneThESGlsVTc3SzBpUkVBYmx3ZW9KMUpjS1IySDZPSTJR?=
 =?utf-8?B?Z1NhajBUOElqMXY3ZkhZZ2NkWjVscEJQTi8xQkY0Q0lpQmhMTnM0WHF6ME1U?=
 =?utf-8?B?MnFzS0cxZjBIdFByMDJ0U2diMXYxZXJ0WkJoTkl6ZWVDZWdiWVBTS0pjSEZx?=
 =?utf-8?B?dDNxSXN2Qk5mOWRNbkhheUxnY1BsWXVaRXJheDIvbHZManU3Qmh6YXlYRzZW?=
 =?utf-8?B?a1VhSlpyc2JsVXlTYktsYXZ6ZUhsQnFXUk1YY0twUGc0S1ljRFVLS2M0YTV4?=
 =?utf-8?B?eFpsdDIwek1GN2N3SUlzd2RobjR0eDNDZGRUMkxhTHFlV0RpWDQ1QVhqWmFy?=
 =?utf-8?B?LzlnbVMrYlhBS0VFTDdDYk45VXpDWXV3VzdJNU5QdXJVeUM4Q21ad1Z2T3pi?=
 =?utf-8?B?VVpjeXV6bjMzQVpHSGs3OW5DUHhmRWVsWnlFdml5UlhTOGl2SDhKUmZxWGFE?=
 =?utf-8?B?S0todGRtYUZ1TEdOcld0b1M3QXpxRDh0VFEzYVY1SmpScFJPQzdWZFFYNEdo?=
 =?utf-8?B?NEZwR1hGMit3UFdLQkFzc2J0VmRmZ3dyczBaM0VNMmpJckRZVDJ5TmZuMXFx?=
 =?utf-8?B?UHJZUE9vOEVKaEIvS0pvQ1ZRYXpGL1VCUDY5TlVBMkErdm5PRnA2TjV6Uzg2?=
 =?utf-8?B?b3VCUW9EOVRObGRuNDRyMklDUTgvREw2SmlTelZCTTU0azEwazZwU0dmWjd1?=
 =?utf-8?B?WmdQQlhJVGR1L1hoSWlCQ21hcFcrMHdkdm1yZ2xLZ3dHdWhDSHVpem1OdVhj?=
 =?utf-8?B?WWV4K0c4cktqTWpob2RNMjh6YW1WTXRINlRqM3RpeWRSMkZkMHRValR3am5G?=
 =?utf-8?B?NVQwNFRsQXlBMExyU2dCcGd6ZUk0RTBHamo1eTBMcnFNVXRRVjgxL2dKTi9x?=
 =?utf-8?B?OEttNnZ5T0lKaE9jdVl1VGVDdzMzeGhCSVFzdDlIWjVZUXoyNGIxSUQrT05F?=
 =?utf-8?B?MzdqUnAwYmR5TE04WG85c25velhDVmZRVDR2VDl5THk0MHFUejZpM212REU4?=
 =?utf-8?B?eFRxUkxGMVV5RU5mK1dhSjdPUDhYMythc2hndnQxVUY0dktuNllqai8yZzBC?=
 =?utf-8?B?YU1OZDlpTTlCSHVyc0hpS2lZUXEzMktYZEpJcGNtemhBaDExL3RMNlZRSXFy?=
 =?utf-8?B?MzNma3FtV2NJZG92QlJMSm52dkVGWVl3WHBGKzBLUmZXNnhObllsS3VQN1Ji?=
 =?utf-8?B?VmdFa0ZEY2pmb0tWWmFSVmdKWEFFV3FJd1h5SmpJbkw3UGIyd1NtWHVOSG9m?=
 =?utf-8?B?djRidHFjRWZETFIvdjU1YjNVMWZBSityaW1OU3pIKzNsMkwzbURFQ3k5TS94?=
 =?utf-8?B?NUplZ0hWWSt1bmtRZzVWcnQvL3IxZC8rUlBQR05JdE5UOEtCWnJiTWJNYnl4?=
 =?utf-8?B?dWVNcG1NVzFPTW1XUTFIUmduVi9wZmc5UnRmQ0NJS29KOWJtN2dxMEZuNnFP?=
 =?utf-8?B?SzljekV4aXJJaU45NnFMdW0zazBMUEI1YzFhaURzUUtCTGFyT3kxSG5FSFpO?=
 =?utf-8?B?dVV3M3BoK2xLZ3ovR3J5OXFwTmg1NWJlUkxkbzdIWDNtbExNS1A5MWRaR2Nm?=
 =?utf-8?B?WFkyV0ZSMTMxZ0xqd3o5ckErdTVBNGVVWE53NS9rSlZlQ2NDQWcxREJKd1Nu?=
 =?utf-8?B?VnIvYk14WW5qN2VlUW1DYjVYd0IvdEltbzZYS05FOExBUkF3ZjZhRURnck4x?=
 =?utf-8?B?enJuMnJDdHhSbk1NUE1ZNHFLVitvb0paYkpsV01KWWFjOXB1ZUlwSEl5TDQ3?=
 =?utf-8?B?Z0lRamRwdjM4QmJSZkozUUgwY09tQTVWdTlKQmlsOVZRaVR1Mm5JZWVSTGpI?=
 =?utf-8?B?ZGhwbXRPY3RkbUc3QVFBeWRZOEpxamVpc3luekhveXhWYmtDRFpKZSt1aUdP?=
 =?utf-8?B?L1lHckphWDVWbG43NHduTUJySktQQXRyOVZVS3hqaS9WeElBRnZOL3MyVzdH?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 51730321-09bc-43e1-5e78-08dbb3a963d3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 16:00:31.0105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u0N/tp0eGWUJ/gIkk9W1Azec8M/nMFMdnz3+6UUj5Ge8bqD57QTycPAJTyLAPKbOtfvPt1+1+itbfENZny7kAL0+Ow4IzFjpx145aK31i4o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6084
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 09:04:36 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

Hi Maciej,

On 9/11/2023 11:32 PM, Maciej Wieczór-Retman wrote:
> On 2023-09-11 at 09:59:06 -0700, Reinette Chatre wrote:
>> Hi Maciej,
>> When I build the tests with this applied I encounter the following:
>>
>> resctrlfs.c: In function ‘write_schemata’:
>> resctrlfs.c:475:14: warning: implicit declaration of function ‘open’; did you mean ‘popen’? [-Wimplicit-function-declaration]
>>  475 |         fd = open(controlgroup, O_WRONLY);
>>      |              ^~~~
>>      |              popen
>> resctrlfs.c:475:33: error: ‘O_WRONLY’ undeclared (first use in this function)
>>  475 |         fd = open(controlgroup, O_WRONLY);
>>      |                                 ^~~~~~~~
>> resctrlfs.c:475:33: note: each undeclared identifier is reported only once for each function it appears in
> 
> Hmm, that's odd. How do you build the tests?

I applied this series on top of kselftest repo's "next" branch.

I use a separate build directory and first ran "make headers". After that,
$ make O=<build dir> -C tools/testing/selftests/resctrl

> I use "make -C tools/testing/selftests/resctrl" while in the root kernel
> source directory. I tried to get the same error you experienced by
> compiling some dummy test program with "open" and "O_WRONLY". From the
> experiment I found that the "resctrl.h" header provides the declarations
> that are causing your errors.

From what I can tell resctrl.h does not include fcntl.h that provides
what is needed.

Reinette