Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request()
Date:   Tue, 12 Sep 2023 17:52:35 +0200
Message-ID: <7566964.EvYhyI6sBW@jernej-laptop>
In-Reply-To: <CACRpkdbTZYnehWiWFgY3KJLFdS47RpxOp-Cct4BDqgYCYtd2vw@mail.gmail.com>
References: <20230909063613.2867-1-jernej.skrabec@gmail.com>
 <20230909063613.2867-3-jernej.skrabec@gmail.com>
 <CACRpkdbTZYnehWiWFgY3KJLFdS47RpxOp-Cct4BDqgYCYtd2vw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dne torek, 12. september 2023 ob 10:15:31 CEST je Linus Walleij napisal(a):
> Hi Jenej,
>=20
> thanks for your patch!
>=20
> On Sat, Sep 9, 2023 at 8:36=E2=80=AFAM Jernej Skrabec <jernej.skrabec@gma=
il.com>=20
wrote:
> > Use dev_err_probe() when printing error message in pin_request() since
> > it may fail with -EPROBE_DEFER.
> >=20
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>=20
> (...)
>=20
> >         if (status)
> >=20
> > -               dev_err(pctldev->dev, "pin-%d (%s) status %d\n",
> > -                       pin, owner, status);
> > +               dev_err_probe(pctldev->dev, "pin-%d (%s) status %d\n",
> > +                             pin, owner, status);
> >=20
> >         return status;
>=20
> That's not how you use dev_err_probe()
>=20
> Just replace all of the lines above with return dev_err_probe(...)

I already send v2 of this patch soon after I got report from kernel test=20
robot.

Best regards,
Jernej

>=20
> Yours,
> Linus Walleij