Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 12 Sep 2023 08:34:21 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH RESEND v3 2/2] selftests/resctrl: Move run_benchmark() to
 a more fitting file
Message-ID: <gjyv2lwrrw3n5n3olcedjjvhbyqqikic5fvuquc74srybgylq5@uxpvgadeuhhp>
References: <cover.1693575451.git.maciej.wieczor-retman@intel.com>
 <7026d06ce116c4c5b5454c814cda69387c54e2a0.1693575451.git.maciej.wieczor-retman@intel.com>
 <e0fa9375-0b50-af89-81d3-eaaecf19a788@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e0fa9375-0b50-af89-81d3-eaaecf19a788@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?YtWFAVrY9OjB5B1fX6M+frCYAwf2joUI6WwpcLhGZ9rN9yR71agBCK2mb0?=
 =?iso-8859-1?Q?OEJdBcuXNXYx8RENRvd0wgkUWAoCpYYS8QGwxBgSmRLEsFF506Ie7O9Rud?=
 =?iso-8859-1?Q?FjzdVVKadC53DGFDDQgaWG4sp1OQGAVekkEGTcGd6sYtx0/MReyKl7YIDw?=
 =?iso-8859-1?Q?8d3JvZRCPtZNygMYYIs6MroETtD2bG1sMBABTPZY9heZsihqqNvVsyEpI5?=
 =?iso-8859-1?Q?ANRQqKb8fdBwvA71DBVSG0xuugo7oaN9LbtkavFYcaGMaSxSXHyj79bI11?=
 =?iso-8859-1?Q?1RvFKve68oDcHfQEaW+zNLyHj7s5dYlQcXCayVFmzqrbfU80xeLMXXaMjY?=
 =?iso-8859-1?Q?/oO4EipaDgPlAj1ERoQUVJB+jfgL9aguQl5gQf4vOMRb8X/DehhRBjMIXb?=
 =?iso-8859-1?Q?7C9ffGqWXe2qDQisDxrrb/tXjxCwO/aZjcrMMFCtzarOw6vxH439Tx/nn7?=
 =?iso-8859-1?Q?RTCxYfvjarW9jNDi6sv21+tjBAsZ2kCllzvA0hUMHyfcnJL5KFkNKSH8tZ?=
 =?iso-8859-1?Q?K2ofvxcJeOyS/Q7YIcDTPau8c19fFP06BlYFGoeFnxD2r3L6C966Q7WIme?=
 =?iso-8859-1?Q?UDWbQryGqA2BXr4Vb/aYmF3eiLi45aEvMIDxCEuw+6W2AVSwB7mZa5fwXC?=
 =?iso-8859-1?Q?SW8ZWeaFcEWQedwYhI1sBP9s5J+K8UGunHMi1JBOKcdKvazhNmI690bEZG?=
 =?iso-8859-1?Q?UtYsUoTgjRHNAxgjAD55cQ3LYcjW5RTRzKMP8uWCt5jJFzKLWZoxQd65yT?=
 =?iso-8859-1?Q?+aqOisQPVNlxJGg4UoK3qq5PkQNOXxZGXxaihr5BEBioJPAh9TVIy4qNv8?=
 =?iso-8859-1?Q?KhnJG1l7Lwj5q/qJy9RkJYon399spivzWkQabTeVwO+iuAxhhUVvy7eYhA?=
 =?iso-8859-1?Q?hLMoNpRfyzQiq37J2K2lfMdKm1VZ7C+HCowbB4XiyY/FAW6lP1oKfswyAZ?=
 =?iso-8859-1?Q?fEOnsajOK85w+dEIqtAYYlkNNN4ZDXY3txM7ZXzWrcq7OLZocjkUI0XQQs?=
 =?iso-8859-1?Q?ePKd51cTaFf7AjmpLjMCNFSZUvczmsqfQvXsYJ7lyDcURNSOpZBX7+KYF7?=
 =?iso-8859-1?Q?1u5RipqmeROztm220Z2PfSvs2H4/bkTlkQ4VyIerHIK6vHaOdtU8nSCi/1?=
 =?iso-8859-1?Q?duiurGjq/LYIW4MMlzXZQvyKI3/VZr9JrBjM4DGcnnpTC9bTZg6+jKTQXf?=
 =?iso-8859-1?Q?+PvjPqw1jn4rdSzdNSn1F2lvxSELnfn0kMFKGjbZ/DrR2NifSvsZAeBcxn?=
 =?iso-8859-1?Q?8qpSGAEq8nyw0uTuqe8QqT7DiewpCbkbm2Hp94ytsYoEYjmTyU3LwRWsXe?=
 =?iso-8859-1?Q?Yi4bXSchYPQIS9grXnvm/294xLhOQ16hYOHFkoo2JEMqjDxS7bFIdD/5mW?=
 =?iso-8859-1?Q?UVe5rlBKM91HcwGZ8joH/t0v6QJGV+nOjYeACZR3DNa2trrlltHDh4CuhF?=
 =?iso-8859-1?Q?l4wg0udcgihWTGXk+WAP6dzGz48O2uOiDY4RetElE2Y4jWKYpNabCKBqbi?=
 =?iso-8859-1?Q?U3Ev3abL1wL0Wv2aaGtgLw5UCXKZDCmuaSeYut4wJDcfvlo5o4WaksIPcP?=
 =?iso-8859-1?Q?Dzucsuo8TJvlvydOu6kawaZWLSIx0dCcRVb2GBaSUrvlJZqoEeeeqCqFqW?=
 =?iso-8859-1?Q?t+PaQTlARBGOhbdDDdERO/vFmfRwALcB8RbF3DZ+29lizJuctt09leyKBI?=
 =?iso-8859-1?Q?ogQxuvTkCSfQI0ojplk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b644a9f5-b27d-4a8b-4fe8-08dbb35a5324
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 06:34:32.7248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NN55S6kumbCz1ZgAkzfBNMaRmX52uc7nKEC3iTm3z4gOQGI74VCb4vCXxdRNWGMHCrlmkuMKLCTcRV/54+hrH35Dgdl5LmDfQxGkeaiy7yU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7802
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Sep 2023 23:34:48 -0700 (PDT)

Hi,

On 2023-09-11 at 09:59:31 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote:
>> resctrlfs.c file contains mostly functions that interact in some way
>
>This can just be "resctrlfs.c contains ..." (no need for "file")

Right, sorry, I'll correct this and the one below.

>> with resctrl FS entries while functions inside resctrl_val.c deal with
>> measurements and benchmarking.
>> 
>> run_benchmark() is located in resctrlfs.c file even though it's
>
>same here
>
>> purpose is not interacting with the resctrl FS but to execute cache
>> checking logic.
>> 
>> Move run_benchmark() to resctrl_val.c just before resctrl_val() that
>> makes use of run_benchmark(). Make run_benchmark() static since it's
>> not used between multiple files anymore.
>> 
>> Remove return comment from kernel-doc since the function is type void.
>> 
>> Signed-off-by: Wieczor-Retman Maciej <maciej.wieczor-retman@intel.com>
>> Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>
>Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
>Reinette

Thank you for the review!

-- 
Kind regards
Maciej Wiecz?r-Retman