Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755197AbXKFPa3 (ORCPT ); Tue, 6 Nov 2007 10:30:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753496AbXKFPaW (ORCPT ); Tue, 6 Nov 2007 10:30:22 -0500 Received: from mtagate2.uk.ibm.com ([195.212.29.135]:23911 "EHLO mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359AbXKFPaT (ORCPT ); Tue, 6 Nov 2007 10:30:19 -0500 Date: Tue, 6 Nov 2007 16:29:39 +0100 From: Cornelia Huck To: Kamalesh Babulal Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, Andy Whitcroft , Greg K-H Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails Message-ID: <20071106162939.41c4bd36@gondolin.boeblingen.de.ibm.com> In-Reply-To: <473083CA.9060607@linux.vnet.ibm.com> References: <200711061033.lA6AXrhT018804@imap1.linux-foundation.org> <473083CA.9060607@linux.vnet.ibm.com> Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.1.0-rc1 (GTK+ 2.12.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8942 Lines: 113 On Tue, 06 Nov 2007 20:40:02 +0530, Kamalesh Babulal wrote: > Hi Andrew, > > The build fails on the S390x with > > CC drivers/s390/char/sclp_cpi_sys.o > drivers/s390/char/sclp_cpi_sys.c:242: error: variable `system_name_attr' has initializer but incomplete type > drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `attr' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:243: error: extra brace group at end of initializer > drivers/s390/char/sclp_cpi_sys.c:243: error: (near initialization for `system_name_attr') > drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr') > drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `show' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr') > drivers/s390/char/sclp_cpi_sys.c:243: error: unknown field `store' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:243: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:243: warning: (near initialization for `system_name_attr') > drivers/s390/char/sclp_cpi_sys.c:264: error: variable `sysplex_name_attr' has initializer but incomplete type > drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `attr' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:265: error: extra brace group at end of initializer > drivers/s390/char/sclp_cpi_sys.c:265: error: (near initialization for `sysplex_name_attr') > drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr') > drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `show' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr') > drivers/s390/char/sclp_cpi_sys.c:265: error: unknown field `store' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:265: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:265: warning: (near initialization for `sysplex_name_attr') > drivers/s390/char/sclp_cpi_sys.c:287: error: variable `system_type_attr' has initializer but incomplete type > drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `attr' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:288: error: extra brace group at end of initializer > drivers/s390/char/sclp_cpi_sys.c:288: error: (near initialization for `system_type_attr') > drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr') > drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `show' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr') > drivers/s390/char/sclp_cpi_sys.c:288: error: unknown field `store' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:288: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:288: warning: (near initialization for `system_type_attr') > drivers/s390/char/sclp_cpi_sys.c:317: error: variable `system_level_attr' has initializer but incomplete type > drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `attr' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:318: error: extra brace group at end of initializer > drivers/s390/char/sclp_cpi_sys.c:318: error: (near initialization for `system_level_attr') > drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr') > drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `show' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr') > drivers/s390/char/sclp_cpi_sys.c:318: error: unknown field `store' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:318: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:318: warning: (near initialization for `system_level_attr') > drivers/s390/char/sclp_cpi_sys.c:333: error: variable `set_attr' has initializer but incomplete type > drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `attr' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:334: error: extra brace group at end of initializer > drivers/s390/char/sclp_cpi_sys.c:334: error: (near initialization for `set_attr') > drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr') > drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `show' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr') > drivers/s390/char/sclp_cpi_sys.c:334: error: unknown field `store' specified in initializer > drivers/s390/char/sclp_cpi_sys.c:334: warning: excess elements in struct initializer > drivers/s390/char/sclp_cpi_sys.c:334: warning: (near initialization for `set_attr') > drivers/s390/char/sclp_cpi_sys.c:337: error: invalid use of undefined type `struct subsys_attribute' > drivers/s390/char/sclp_cpi_sys.c:337: error: initializer element is not constant > drivers/s390/char/sclp_cpi_sys.c:337: error: (near initialization for `cpi_attrs[0]') > drivers/s390/char/sclp_cpi_sys.c:338: error: invalid use of undefined type `struct subsys_attribute' > drivers/s390/char/sclp_cpi_sys.c:338: error: initializer element is not constant > drivers/s390/char/sclp_cpi_sys.c:338: error: (near initialization for `cpi_attrs[1]') > drivers/s390/char/sclp_cpi_sys.c:339: error: invalid use of undefined type `struct subsys_attribute' > drivers/s390/char/sclp_cpi_sys.c:339: error: initializer element is not constant > drivers/s390/char/sclp_cpi_sys.c:339: error: (near initialization for `cpi_attrs[2]') > drivers/s390/char/sclp_cpi_sys.c:340: error: invalid use of undefined type `struct subsys_attribute' > drivers/s390/char/sclp_cpi_sys.c:340: error: initializer element is not constant > drivers/s390/char/sclp_cpi_sys.c:340: error: (near initialization for `cpi_attrs[3]') > drivers/s390/char/sclp_cpi_sys.c:341: error: invalid use of undefined type `struct subsys_attribute' > drivers/s390/char/sclp_cpi_sys.c:341: error: initializer element is not constant > drivers/s390/char/sclp_cpi_sys.c:341: error: (near initialization for `cpi_attrs[4]') > drivers/s390/char/sclp_cpi_sys.c:349: error: syntax error before '(' token > drivers/s390/char/sclp_cpi_sys.c: In function `cpi_init': > drivers/s390/char/sclp_cpi_sys.c:379: error: implicit declaration of function `firmware_register' > drivers/s390/char/sclp_cpi_sys.c:379: error: `cpi_subsys' undeclared (first use in this function) > drivers/s390/char/sclp_cpi_sys.c:379: error: (Each undeclared identifier is reported only once > drivers/s390/char/sclp_cpi_sys.c:379: error: for each function it appears in.) > drivers/s390/char/sclp_cpi_sys.c:385: error: implicit declaration of function `firmware_unregister' > drivers/s390/char/sclp_cpi_sys.c: At top level: > drivers/s390/char/sclp_cpi_sys.c:242: error: storage size of `system_name_attr' isn't known > drivers/s390/char/sclp_cpi_sys.c:264: error: storage size of `sysplex_name_attr' isn't known > drivers/s390/char/sclp_cpi_sys.c:287: error: storage size of `system_type_attr' isn't known > drivers/s390/char/sclp_cpi_sys.c:317: error: storage size of `system_level_attr' isn't known > drivers/s390/char/sclp_cpi_sys.c:333: error: storage size of `set_attr' isn't known > make[2]: *** [drivers/s390/char/sclp_cpi_sys.o] Error 1 > make[1]: *** [drivers/s390/char] Error 2 > make: *** [drivers/s390] Error 2 > > The patch git-s390.patch is causing this failure. That's a clash between git-s390 and the recent kset cleanup. sclp_cpi_sys.c needs to be converted from firmware_register() to the new dynamic kset allocation (kset_create_and_register()) and the subsys_attributes to kobj_attributes (I may look at it later if I find some time). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/