Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <440ad7c8-35f7-5b15-5de6-f220cae2cde0@amd.com>
Date:   Tue, 12 Sep 2023 15:45:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 1/3] PCI: pciehp: Add support for async hotplug with
 native AER and DPC/EDR
Content-Language: en-US
To:     Lukas Wunner <lukas@wunner.de>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20230815212043.114913-1-Smita.KoralahalliChannabasappa@amd.com>
 <20230815212043.114913-2-Smita.KoralahalliChannabasappa@amd.com>
 <20230828073542.GA12658@wunner.de>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <20230828073542.GA12658@wunner.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU5YcHBqcEUyeDN1ZlRNb280b3hlSThRWjFUUmRVNXIxdnRkakJnK2dmTXFm?=
 =?utf-8?B?RldhTFl3cGZhSVVxM3RkVlo0WE1QSXJjWGI4d1pZTUlmV1VzeGhaQjVaZ0I4?=
 =?utf-8?B?M01PcTdWRHlQZTg3LzFGVGoxZjV4SEFNTGJHZmhmVmVoL0xyY3REV1crR3NU?=
 =?utf-8?B?R1UwM2t4SzI4UFpBRFBQdGVRUVRGSGRIMHZxd3p5OHlSVXMyS3JLMTVFNVhX?=
 =?utf-8?B?REFXb1Y3TmRWUTN2NlJCNE5TOFg3aS9TQUo3Y2tOSnlhaEsxVHhzTS9QV2xv?=
 =?utf-8?B?QVphLy9WYytBUUpBYzA3VklzcFM4S21mN0VIeE1hdzVPUFRjbEFBYUk0MVk1?=
 =?utf-8?B?S3JUTTRSMElBWEdTK1RtRngwTE43enBCWUxTMWVtREd4ME5wR1NENnBEdmFt?=
 =?utf-8?B?dWg2NS90MW45dTl3MVFLNXFFOFlEbHZhR1cyOE00aStQWHFvc2RidllxOGYx?=
 =?utf-8?B?ZTlxQXBubnBCdm1iMHkrNlA1czFjdWpPeDV5Uk9lMDFrTmJLbEF5MmtuYk1w?=
 =?utf-8?B?Z1k3TUlNZmZ1VUM4Zk5aL2p1ZCtnZ0hSdEl2OTh1QjU3TElyNGgyVVpleXIx?=
 =?utf-8?B?R2FSVHNIc3dnTUpyNWZlUzdVa29UY3pJdnBtMDlRMStnNUlCNzUrS3lCc0pl?=
 =?utf-8?B?MC9hUFgrYlltR2U5Y0VkMmdrVWR1VGE1bEZhalNQNjJnbkRPT012UjFoU1dz?=
 =?utf-8?B?b0U1ZEdpbC92eGVOREFKUGNjKy9HUmhEYmgyalZxK25pRkk1R0IvS2VNblMw?=
 =?utf-8?B?Y3hVSi9SQ2R1Q01Xek80WDJzVkQ4UUxxYTZtbE9vVTBpOFVJSitmUk4rVW9a?=
 =?utf-8?B?ZVVPbkxoZ216NkhXZzVkcjZFaTB1bVZIVkdSUURhWXNhS3JpQjBiZ2xEZGpu?=
 =?utf-8?B?T0pDd1VuOGZSa1FEdnFCMHdqQUE1bUFVd1BCd2haK1llK2d4SnZsUGM4TzVy?=
 =?utf-8?B?WjFXNHVRWEZJRlM2UUZMa2o3ek9iTjhWTTdXbUkvSktuM2NYeFptREpmT1Nz?=
 =?utf-8?B?S1dvUy85RE9RdGtObUNuRXowTmUwYTAxdTltd1NhV2xYM0VYSDhCTUVMWG5Y?=
 =?utf-8?B?bitFN2c4SVFtK2VLWThoOUVEU3NpZEFjUXVCc0MvcTk3NlpRdTlxaUVaWjdU?=
 =?utf-8?B?bHlwTjZqNUdqYUdLdUYyRVl5MXZMcEduZjIxbUs0Z0t0WFIxNGh2dlZ6ZXEw?=
 =?utf-8?B?cGsxeW5MTC95TlBXYjZ3ZzhvSHNLbGFQc1VZckpIMkx5dmRsZnVXWUZQb2Mw?=
 =?utf-8?B?SWxQTVhhcFZ6eVFDMEtZemo3RURuMFV1VDhWdG4rUGYvekJ6WG1XNU5mUFUx?=
 =?utf-8?B?bW9UdnI1MnV6VmZoNjIwY2ZrVWNHMHAzRWRRSnJueDRRR1dTdkw2OXZGNHVW?=
 =?utf-8?B?bU9DdXRvbHIwZ0xaSE5LOWI2Vy9LUGdWWEdIVXYreXp6QVZNTEZXU1hZb2FR?=
 =?utf-8?B?TUxyTTh4akpZaTZjQmFMMkUrL3cyd2xvTzcrU3BBQ2J6dGFXSlBNS0RsKzkz?=
 =?utf-8?B?VS9PaDR4TlEyMHBiUkIwQ0FkbVpDam4xcVNQRVFCcnhRem40bUlZK0JPcEZq?=
 =?utf-8?B?c09VOUZzV1ljck03bU5obURGaHpKSmlyTlJaNy9hMHZsZVBEcWFoQzlNdm1D?=
 =?utf-8?B?cGRoTmZnRHlRb08yN2NxZUp6MTAyRE9RYlZQaHhYY2IxWDRYQXIzTnVzZXNw?=
 =?utf-8?B?VGM2UUN6N2ZzQjdLUk1RMGJPbldXR2U1a0dBUHJJYTFKMDdLYXZ4VVFIekJL?=
 =?utf-8?B?Qzlyam95NTVybENkSTlHZG0vVm45Q0lxMWRCZkZDRy9wLzlDclBKZHpYcjlS?=
 =?utf-8?B?V0VUWHZxTG42c1BZL1dMYTh6dnB5eWJmK3BuTkxzcUdmVW1pSm5RY0F3dGI3?=
 =?utf-8?B?aThUZERoU3paY0RtajdaVE4ybnZVb2IxU01IeXorZDU1TmRKTFZZNDBvaU1x?=
 =?utf-8?B?UkI3eDJMRVFTdnNrNFlqaDU3YVpoNUVKd3lHOHRmVWJKMU1lc2tKNThqQ3ND?=
 =?utf-8?B?OFdadjlJOWtTUmNrZC8rTU8vTkZXNDhJYmZUT2dEeWl2ZXU0NGQ1VThRTHZk?=
 =?utf-8?B?bmhQWitNWHByWGlVdFplcjVkVEZYVVBFSlcrZG1tWFJBZGNxeFRpd1lPVmhv?=
 =?utf-8?Q?Zx5O2D5vPetNz8WDvAZMuV9Tn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd5b1b2-c94e-47c7-3a9c-08dbb3e1fb3a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 22:45:36.8620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RJrjkvjzCt2y4AFHQJiz2ruoY1ZFjggY6NHRT0P4K9iW6r62/TI9WoxGHo8tS8WQl+/HL1GDMTiqoo4SREv1WQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4386
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Sep 2023 15:45:52 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email

On 8/28/2023 12:35 AM, Lukas Wunner wrote:
> On Tue, Aug 15, 2023 at 09:20:41PM +0000, Smita Koralahalli wrote:
>> According to PCIe r6.0 sec 6.7.6 [1], async removal with DPC may result in
>> surprise down error. This error is expected and is just a side-effect of
>> async remove.
>>
>> Add support to handle the surprise down error generated as a side-effect
>> of async remove. Typically, this error is benign as the pciehp handler
>> invoked by PDC or/and DLLSC alongside DPC, de-enumerates and brings down
>> the device appropriately. But the error messages might confuse users. Get
>> rid of these irritating log messages with a 1s delay while pciehp waits
>> for dpc recovery.
> [...]
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> 
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> 
> The subject is slightly inaccurate as this doesn't touch pciehp source
> files, although it is *related* to pciehp.
> 
> As an example, a perhaps more accurate subject might be something like...
> 
>    PCI/DPC: Ignore Surprise Down errors on hot removal
> 
> ...but I don't think it's necessary to respin just for that as Bjorn is
> probably able to adjust the subject to his liking when applying the patch.
> 
> Thanks a lot for patiently pursuing this issue, good to see it fixed.
> 
> Five years ago there was an attempt to solve it through masking Surprise
> Down errors, which you've verified to not be a viable approach:
> 
> https://patchwork.kernel.org/project/linux-pci/patch/20180818065126.77912-2-okaya@kernel.org/
> 
> Lukas

Thanks for the review. Would it be possible to consider this patch as a 
standalone while I work on 10-bit tags enumeration? I can do v5 for this 
patch with $SUBJECT changes and also include clearing Atomic Ops and 
10-bit tags unconditionally on hot-remove if that works..

Thanks,
Smita