Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <2f5cd2a6-4f1f-c841-2a5f-862a0cc5d96d@amd.com>
Date:   Tue, 12 Sep 2023 14:45:23 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v9 9/9] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20230907235128.19120-1-babu.moger@amd.com>
 <20230907235128.19120-10-babu.moger@amd.com>
 <fbf1f7e5-1a82-303c-3802-2f246505c8a4@intel.com>
 <1b6d1121-00a8-5f30-26fd-d5137fe9d9c1@amd.com>
 <902ae38f-fbd5-2686-0467-ca440e9a7a50@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <902ae38f-fbd5-2686-0467-ca440e9a7a50@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUZib1l6LzVGd3ljeWhRT0orZjJVeFhxUzRCVlZjekpQVHRDMUVrOTZ4eGlt?=
 =?utf-8?B?V2hZeWdjOUVKZVlXWGppMDdQRWdZRUl1UHQ4Q296aitCQnVLZStTOTBDdyta?=
 =?utf-8?B?L2M5L2xlVmhjUWMwZy9NeXluc1hkMVRSQXNFb0RXeFovTTExRXk3MldvOGZC?=
 =?utf-8?B?SExKZUhNU2Y5R0dGRHhIZXhheWN0SjFzaUhEZTZMaytBaWZFclk4bU9rQTR0?=
 =?utf-8?B?T2lkSzBRSm44eFJiQThEejhDd3plYiswN1dtOEw2aHFyTVYyQkoremVkckFM?=
 =?utf-8?B?ai85VEp1dmxOeEdGY1FzRGRCZE1hYzdCWGQrekV5WHo2eWdkNGlVTUgzWisy?=
 =?utf-8?B?M3FvR0ZkekcrZTFkWmdJTXZJWmVxYUo5TUNPeG82N0ZBZWE2V083S1Nua29v?=
 =?utf-8?B?YW91dDJTanIwR1pWS2RMRTlLOEdNNjFsdmpkR20ycDFNOEo2Z2g0NXNZYlhG?=
 =?utf-8?B?d2ZXN2JOZlhpUTVjd2J3Wm1mQ296TEo2UVZSbXc2d3QxaVluV1ZhSGxtUlpp?=
 =?utf-8?B?dWM3cXNsYVdiL1R0bUd3SEtrdURzSjBnUE5TQUdvS01COGNjQStxeHdlYUdU?=
 =?utf-8?B?MDNibWcrMVMvSkJOTUVpdnpndXBYR0xaVUgyMzdYYUFlaDdkZktrb3RSa0l3?=
 =?utf-8?B?aWhOdW1FbzBUeCtZdGpFcWcwZGRMUGltbTFYK3QrZ1YwcWViY1pEZmxQaWdV?=
 =?utf-8?B?RnFZcXQxZ3N1UkdrNi9ZbUN3K1gwMEtHZVl3Ymg1TXRKVldwNDdOUVZhR2dJ?=
 =?utf-8?B?Qkw3UEpZVktrUE5Ic0pWWTI3RWErKy9MNTJkYmVDYkdEZFlNVmFtUmJCYWky?=
 =?utf-8?B?SzVHMXVuUWVobEVkWEpKei9TTWMyakxoWjFGYUFhdytqdzBtSURPNFZDY0Mw?=
 =?utf-8?B?YkhKWkg4aDRIMGhLQXdIcEZsL2hPMmdOdDAvbzVkTG56dVVTUnNWQ0YrL1Nv?=
 =?utf-8?B?UGJFZnlLdlA1bi9Qb3lzN0svcU8yT0tuemFyMmtSdHVHQ3RxVUFLT0p5Y1o1?=
 =?utf-8?B?aFVFNW1tejdhYjY2Q3RZaWJnWFNnZnpOU00wTEsydTR4SG56SXA1YnJJWTlC?=
 =?utf-8?B?SXZMT0kyNEhDcktKdnJlb0Y5QmxPUUh5Ykk4WkdFT2U2RGpMQlNNenVpY0xy?=
 =?utf-8?B?akpPazNkMGR3Slo1dERUK1lOM0ZXRENwejloOTV1Qkt3TVV2c3dzaFdJMDJu?=
 =?utf-8?B?eDhwVW5YN0J1dW15a2VaZ0NBOGkvTjdaclZMeW9YSjB5TFNSS3lCekhDT2ht?=
 =?utf-8?B?Y3NRbzBTR2VhbHJ4WEwxOWs4OXVTZVJWWU4yZlN5OGxRVTkzYjlsdERacVRp?=
 =?utf-8?B?d09vVEUvQzIyRFVZMGxvUW04bTVndnNaLzhrUXZKV1hEYlF6aDdTcHVZUWFI?=
 =?utf-8?B?blovbGVHSGYyTFdTWXp0WlBLNlVaSFBCYVdublZvc3o5ckJRc2svclNLWjJD?=
 =?utf-8?B?SStXa1BJTnEzZzFKTUxjMXladFVpUzUrM08vZ0kvbkFBSWUzdVp6VS9aenRk?=
 =?utf-8?B?RmR3KzdKOFdLMnZSZldiS2crazNrZDk3S2E0MnZWangvSzBITHpCbXN5WnNi?=
 =?utf-8?B?WklXeXlLNGMvdVFKRk1QNlhIMk9EZWFlUzBVSzRodWc3VlllQjZYZG82elBU?=
 =?utf-8?B?VFVZVnIxcDNjcDhxYUdsU1NDTUFYT2ErQm9JQzBqWmxrYStkZ0dsL21ObEdW?=
 =?utf-8?B?U2I3eFBZNlNjbllKb1U4dUJkZnFNM29CWlFYaGQzd0NTaStjbWRIS1o4Q3lH?=
 =?utf-8?B?cGYyUWZPWjlvTDZCZU1WQW0zUjdrelBsQmtPSytyQ0xtRDlHd25vUUM5NXNI?=
 =?utf-8?B?ME8wTXlBZ0t3WG5mTnRiVDIyVzV5MUJzNnNTRW53VFVoYitZTkd0S0k4QnZB?=
 =?utf-8?B?R2l6VFBwVDNjV083cUFESVltWmpyNis0NWhIMWZVSUdad2dBaDFOMGt1d1l4?=
 =?utf-8?B?b0NwL2FUVktiVVpKZkFucFhJRmZPTDFaYWJsMUpEMEQ1QU9uK1FMNzhHTkxt?=
 =?utf-8?B?OTM5VkpkOUQrMENyek1jSHFmbllUdDErTFRrUmRQdFd5d3A2TVl6VXBqeWps?=
 =?utf-8?B?cVRONXpYRmtMdllhbWVXL2dONVowME5zZU5vbE9wMHN5R1BuMDhteFBXOXNC?=
 =?utf-8?Q?bKwI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f9868b3-bfb3-4273-35f5-08dbb3c8d0c1
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 19:45:28.2468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rhLuYaTNYCEd+T6YkZSNNcU+GusAMe69uCuoZQk0nAKzsrANuIrPFJCWLNoqhB28
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8013
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 12:45:54 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

Hi Reinette,

On 9/12/23 12:57, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/12/2023 10:39 AM, Moger, Babu wrote:
>> On 9/11/23 18:08, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 9/7/2023 4:51 PM, Babu Moger wrote:
>>>> In x86, hardware uses RMID to identify a a monitoring group. When a
>>>> user creates a monitor group these details are not visible. These details
>>>> can help resctrl debugging.
>>>>
>>>> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
>>>> Users can see these details when resctrl is mounted with "-o debug" option.
>>>>
>>>> Other architectures do not use "RMID". Use the name mon_hw_id to refer
>>>> to "RMID" in an effort to keep the naming generic.
>>>>
>>>> Add the flag RFTYPE_MON_BASE, which contains the files required only
>>>> for the MON group.
>>>
>>> As I mentioned in [1] I believe adding support for files with RFTYPE_MON flag
>>> to resctrl needs to be in a separate patch. With the core support added a file
>>> with this flag can be introduced separately. 
>>
>> Yes. We discussed it. Thought it may not fit as a separate patch on its
>> own. So, i combined it.
>>
>> Now, I split patch 9 into two. Let me know if it looks ok.
>>
>> ==========================================================================
>>
>> Author: Babu Moger <babu.moger@amd.com>
>> Date:   Thu Sep 7 18:51:28 2023 -0500
>>
>>     x86/resctrl: Add RFTYPE_MON_BASE for MON groups
>>
>>     Add the flag RFTYPE_MON_BASE, which contains the files required only
>>     for the MON group. Files with these flags are only visible when
>>     monitoring is enabled.
>>
>>     Signed-off-by: Babu Moger <babu.moger@amd.com>
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
>> b/arch/x86/kernel/cpu/resctrl/internal.h
>> index ccdbed615d41..72988e5c52a7 100644
>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -296,6 +296,8 @@ struct rdtgroup {
>>   *     --> RFTYPE_BASE (Files common for both MON and CTRL groups)
>>   *         Files: cpus, cpus_list, tasks
>>   *
>> + *             --> RFTYPE_MON (Files only for MON group)
>> + *
>>   *             --> RFTYPE_CTRL (Files only for CTRL group)
>>   *                 Files: mode, schemata, size
>>   *
> 
> I think it would be ok to add above hunk as part of the patch
> that adds mon_hw_id, similar to what you did in patch 8.

Ok. Sure.
> 
>> @@ -315,6 +317,7 @@ struct rdtgroup {
>>  #define RFTYPE_MON_INFO                        (RFTYPE_INFO | RFTYPE_MON)
>>  #define RFTYPE_TOP_INFO                        (RFTYPE_INFO | RFTYPE_TOP)
>>  #define RFTYPE_CTRL_BASE               (RFTYPE_BASE | RFTYPE_CTRL)
>> +#define RFTYPE_MON_BASE                        (RFTYPE_BASE | RFTYPE_MON)
>>
> 
> This hunk may be appropriate for patch 3.

Sure.

> 
>>  /* List of all resource groups */
>>  extern struct list_head rdt_all_groups;
>>
> 
> This is not how I expected it to look. There is currently an issue
> in resctrl where files with RFTYPE_MON are not created for CTRL_MON
> groups. This has not actually been a problem because there are
> no files with the RFTYPE_MON flag. This series introduces the first
> file with RFTYPE_MON flag and thus this resctrl issue needs to be fixed
> before this new file can be supported.
Yes.
> 
> Considering this I expected to see the changes in rdt_get_tree()
> and mkdir_rdt_prepare() done as a separate patch. This will add
> support for RFTYPE_MON files to resctrl. After this change
> a separate patch can add the file that has this flag.
> 
Sure. Got it.
Thanks
Babu Moger