Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2959229rdb; Tue, 12 Sep 2023 18:55:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUU+gRMCiE7P2ivuTE6pBNm/+22ZZ7PB5w1UWdDif6F+4CLejrxMzZV5EZb0gqeXU0UjmP X-Received: by 2002:a05:6a20:918f:b0:156:6bdd:2305 with SMTP id v15-20020a056a20918f00b001566bdd2305mr1197626pzd.45.1694570135315; Tue, 12 Sep 2023 18:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694570135; cv=none; d=google.com; s=arc-20160816; b=DwQVlEzC845mD2AgE6I+k//NTb2qgzi4Q7jbPC0aJGlWYvBuB1YPuCtz5UrRxX+9Uk gElOOayXK3/gyMSAB3+S67mx27nZGhDSKcUNqI22XwleEVZRxHFJDMoAQUv/3FocGw22 9NvzP0Xk2RrkZ93kpG7FLdc9xpBH/KeV65lU57KhrEL6RAYrKgNKTeT+aZ4WJUe2JgYp ekPpx0NESx8RO9Hq9MeL31azzCZmooZ3fcYRBKotmVCIcdj68yy6862RSnKqthfa5lPq Y2UQf1dk/LUN5p4Z4hFJobHDJ+AbwXpz86Nl/e4AbPdj9ukAAIwpjPNLThuObef0meit DX6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2i3I1X+4Fx86xDUOZC46T5gqNZBA/9GqlhFqUY2tgp0=; fh=lp0ld0o1dnZxzl0W1ZfdpM4aDSZxDiT6uFzPyBaBiJw=; b=ncK2IXuRc0lp15U30oeWpGFyKe5vvK+6DGa2wKT1LBNPkbh5F/lh7Nd+bt2neU7oHX G1Zu/kP/IA8SdxFaAqBnnTSF3uXsX8RaTlS4+yalpKAEdrnFSSGMVA0U3j74+3HSalyl +nM/IaH1T1oyzmM6qqs+8m6j1bmR5bg5BNa4EmKlxBMOSYHDnvfNyWdiNh3npvddJCcZ CItr1aliidoK/r1ZJUlYm+m7/0wI+K+lAngGJMzEYem+ux1A8vsVzojcgj6rSIaCpgMA xCf4xWDYkzRC9YOfV5HClk3VWwv0aVVD3rCT7Vps8YMeTcQHmb/x6FCBQiP7cMKpc+iE 0usA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7lQ+rcy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id pi10-20020a17090b1e4a00b00261326aa56esi587135pjb.5.2023.09.12.18.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 18:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7lQ+rcy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C2DD881829D3; Tue, 12 Sep 2023 03:03:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233451AbjILKC5 (ORCPT + 99 others); Tue, 12 Sep 2023 06:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233331AbjILKCx (ORCPT ); Tue, 12 Sep 2023 06:02:53 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D180FE6B; Tue, 12 Sep 2023 03:02:49 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9404D6607320; Tue, 12 Sep 2023 11:02:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694512968; bh=KFTpQC/A7VUsLib15J+EGZdvXTKuNhYXeMQivKrdSI4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=f7lQ+rcyz1WTNWJSyX9xaVR2Svj4OKgMcYb3LA7VfhJ9aeVtWS/v2TdbfyqX2tqPl LuuS5QZGx8DMh7e52XLiMDQedv1dGOBTLSa+5TEmTnlhH01gRt1fBMmkHvoXEGV2ll W44qPWb1U7nE1tzd6w+Ni68URPxJOU+3oYcBDBYqC+MSy+0ZMF71HDT46mXuk8IKsi kWunlPSBN7I5f/IElZBVIJBQ86q0I3e+9JdtGC378XbsMNaQngc1DyLdNoUxrMuYgg k+KCk71MVIA5XEJ866e6+zlVZIuRlXIzlJXhBmhftm68h+K8K74Ttc/J74heAfk6Tg 45g98LuUy0Ipg== Message-ID: Date: Tue, 12 Sep 2023 12:02:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 4/5] clk: mediatek: clk-mt7629-eth: Add check for mtk_alloc_clk_data Content-Language: en-US To: Jiasheng Jiang , mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org, msp@baylibre.com, amergnat@baylibre.com, frank.li@vivo.com, robh@kernel.org, owen.chen@mediatek.com, mars.cheng@mediatek.com, macpaul.lin@mediatek.com, cw00.choi@samsung.com, u.kleine-koenig@pengutronix.de, wendell.lin@mediatek.com, luca.ceresoli@bootlin.com, kevin-cw.chen@mediatek.com, ryder.lee@mediatek.com, wenzhen.yu@mediatek.com Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230912093407.21505-1-jiasheng@iscas.ac.cn> <20230912093407.21505-4-jiasheng@iscas.ac.cn> From: AngeloGioacchino Del Regno In-Reply-To: <20230912093407.21505-4-jiasheng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 03:03:04 -0700 (PDT) X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Il 12/09/23 11:34, Jiasheng Jiang ha scritto: > Add the check for the return value of mtk_alloc_clk_data() in order to > avoid NULL pointer dereference. > > Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC") > Signed-off-by: Jiasheng Jiang Reviewed-by: AngeloGioacchino Del Regno