Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 12 Sep 2023 23:00:51 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Saranya Gopal <saranya.gopal@intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: typec: ucsi: Release debugfs only if it has been
 allocated
Message-ID: <ZQB9Izz0t8RcGHuX@chenyu5-mobl2.ccr.corp.intel.com>
References: <20230911162706.2856910-1-yu.c.chen@intel.com>
 <2023091112-elevation-immature-8f9f@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2023091112-elevation-immature-8f9f@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mTrK/MLXSV90BS48ZXrPLDO0hiO66JNOpjQiVrPZAfXjlUNoHQXt2zglIWPQ?=
 =?us-ascii?Q?p+er7Zaz0Ao5J/3EHQG48YK+a6HTs2FZFlRcrFjyucr9QItCEXUmt2iagXWl?=
 =?us-ascii?Q?QMy7awc+2gtWIFu1DB95qO8Fiaq7oO2D8pPOtF1Y0XDtublSLZEirDMPjEMv?=
 =?us-ascii?Q?OHd4WRpS4lZ1OXudMA9q6+FP1QOucdE9sigfKtA0HlAoqQcYPA+t07hFqv1Q?=
 =?us-ascii?Q?yR2WU+j9vmhWRodB0usJjCZoEwvMk1YbwQpfVN4oJp6pg68v8VocOBigAADf?=
 =?us-ascii?Q?v2EeEPuGuHGpLTlVCcRaDYRfdrH2spnO9x2UQLpkP4PrLSPM54OAcgNjF+fY?=
 =?us-ascii?Q?7c37+eFCUDRPkI1cXkgw7w0W+6PvmA6j9cJtLkhtEmqcfdJ5iVdZexjm4tQB?=
 =?us-ascii?Q?LIAHTNB93PG3BbL9I7RJ0VWtUhRFm79Qk9VgQLl6jZY0jC8JEBAkh2S8tXa4?=
 =?us-ascii?Q?zqZcs9JzKf1blj69XTzOUsMQg7PCDDWbQTGpUpr52BTSx6t8kdV6Ci1Sm90Z?=
 =?us-ascii?Q?AFPfznSZyiSpzP2g+YEX8kvgX7SUEraI11XkqXEPiNm/5vSUJQNLQ/d67LFs?=
 =?us-ascii?Q?0Su5OX6T+E3Z6Dm7oQHIOPvUhEo8wsLksfFGZ6FoufRSsnuiGmt5sSeYe8Lt?=
 =?us-ascii?Q?PgXVN6ziPBYxGWWNTjBmVCeWpxY1AmRZ05LdecVq/HJTuakBYrh2yfMo/6+t?=
 =?us-ascii?Q?/90e0kl/RlKHeVYNNTudM5uHiHzhZ1dp2RDlU1ha9Vu+uvz0FE9L6G28aERW?=
 =?us-ascii?Q?3bZM5rmdo8rHClHl4ajUC3JgG5g3m6KRj4hIuLpJF0wcfLlS8TLVMmjiMAX0?=
 =?us-ascii?Q?l+nSAy4HCHBUMEU9YncYKjnU18QTiV8T16hfdlRYJKY4Thg+2XA1dLOgaEbS?=
 =?us-ascii?Q?xTKnKxiQWwoKc/HfaxF0CbtkkfUaIulZDctTGZDz1skSboc0GxIUwZC3aLS8?=
 =?us-ascii?Q?ziwr9EulDmzvg3TPMBa8KiKihtIBB47Vwd01R8iLuPdXQW6UyJ9RuhvlGITO?=
 =?us-ascii?Q?qqtObANrxy39O1OkuVtJI01Q+CUiCQAmZyASHgMIxBraQL0s1p3auXfM+vzm?=
 =?us-ascii?Q?1iZtmxRAm4JVokYG9uwI/XvZHFAR/1o3rA1uVX9MFnjXiRD7olw26E5wn2tv?=
 =?us-ascii?Q?cRnn0bjIE3IF5eOLo9ZrMBowB0x8BZDHBuG8mtQVANRa8SN0C8Ia9XLyYiNu?=
 =?us-ascii?Q?0fudG9v6R//7eSoGYkTRjX+m01Z45SOwZTkCxBBz8w8dpVRcIlgrlEUHMZoh?=
 =?us-ascii?Q?HoRJ1TNzP7Lq1jFLGeQ+Ftbbu2xlzwNnT24U7r7FBebCXJLGW4d9E3qB5G1n?=
 =?us-ascii?Q?r5MeTT/USdne2RyvtKe+PxwCnYGwacVClcnOJRDjCto5LaEex4cZHUd1b+vp?=
 =?us-ascii?Q?wwbaDb9SRZ7ReyicDbsW+3T8fZ/lXe2cwabsJwC+3JnqiKu/G81Umo51nUk7?=
 =?us-ascii?Q?P2rN9Y/kluiKTCYmepG7+QtBJM2lcv3OPQy2M1y0tgdvtgZvGaov0ALG8A7N?=
 =?us-ascii?Q?t8d5mh40aG9CbUg+3cE9kjqg7J+5d/nlf6hrB1uRIYgctGQ0o6hACQiIsSOE?=
 =?us-ascii?Q?QyZ4bNTRrCoe8KJdlLRZC9pyYbQg5VSWEGsZ4rYt?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9baedbdf-525c-4fac-eef3-08dbb3a114e4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 15:01:02.6291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MH+vdc+n3sOxzvB7UnCWSTK4u3rL4VzCQ0V8htN2fawo2Dom/9IQJiMTohEV0G+Vz/CQxes8qzjfZbp58kkNlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Sep 2023 08:02:53 -0700 (PDT)

Hi Greg,

thanks for your time,

On 2023-09-11 at 20:59:18 +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 12, 2023 at 12:27:06AM +0800, Chen Yu wrote:
> > The following NULL pointer exception was found during boot up:
> > 
> >  calling  ucsi_acpi_platform_driver_init+0x0/0xff0 [ucsi_acpi] @ 394
> >  initcall mac_hid_init+0x0/0xff0 [mac_hid] returned 0 after 5 usecs
> >  BUG: kernel NULL pointer dereference, address: 0000000000000020
> >  Call Trace:
> >   ? ucsi_debugfs_unregister+0x15/0x30 [typec_ucsi]
> >   ucsi_destroy+0x17/0x30 [typec_ucsi]
> >   ucsi_acpi_probe+0x1d5/0x230 [ucsi_acpi]
> > 
> > It is possible that ucsi_acpi_probe() fails to install the notifier,
> > and calls ucsi_destroy() to release the resource. However at that
> > moment the debugfs has not been registered yet, thus the NULL pointer
> > exception is triggered. Add the check for debugfs pointer.
> > 
> > Fixes: Commit df0383ffad64 ("usb: typec: ucsi: Add debugfs for ucsi commands")
> 
> Incorrect format :(
>

Ah, the 'Commit' was incorrectly added.

> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > ---
> >  drivers/usb/typec/ucsi/debugfs.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/typec/ucsi/debugfs.c b/drivers/usb/typec/ucsi/debugfs.c
> > index 0c7bf88d4a7f..55533dc3d539 100644
> > --- a/drivers/usb/typec/ucsi/debugfs.c
> > +++ b/drivers/usb/typec/ucsi/debugfs.c
> > @@ -84,7 +84,8 @@ void ucsi_debugfs_register(struct ucsi *ucsi)
> >  
> >  void ucsi_debugfs_unregister(struct ucsi *ucsi)
> >  {
> > -	debugfs_remove_recursive(ucsi->debugfs->dentry);
> > +	if (ucsi->debugfs)
> > +		debugfs_remove_recursive(ucsi->debugfs->dentry);
> >  	kfree(ucsi->debugfs);
> >  }
> 
> What's wrong with this patch instead:
> 	https://lore.kernel.org/all/20230906084842.1922052-1-heikki.krogerus@linux.intel.com/
>

Thanks for this link, I'll patch my kernel using above version.

thanks,
Chenyu