Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <42522712-b739-3db4-9111-a4b378a65809@axis.com>
Date:   Tue, 12 Sep 2023 09:44:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH net-next] qmi_wwan: Add rawip module param
Content-Language: sv-FI
To:     =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@axis.com>
References: <20230912-qmiraw-v1-1-21bc812fa0cf@axis.com>
 <87a5tramab.fsf@miraculix.mork.no>
From:   Stefan x Nilsson <stefan.x.nilsson@axis.com>
In-Reply-To: <87a5tramab.fsf@miraculix.mork.no>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDZNczBvUGJ6K1BuWGRYTHdmaGdhSVJISWpZN1R4ZUVEQzNxS0tjeGpqSk9p?=
 =?utf-8?B?dnZnamVNSHRFanB3eTAxQ1lzdGxDSG1iZlYxbklTOTIyWFlpZGlWTVpXeXdT?=
 =?utf-8?B?QjJxblVkbGFUelExalNBUUFLUEszVC9EaFZyb1hteFRLNTdobk1ueUxMdFhZ?=
 =?utf-8?B?WS9JL1RkSWFTTzhLckpNUlBjOHJSdXY2b2VTczN0cnIvdXNpZEZKVHl1Y0Zn?=
 =?utf-8?B?YXJHR3ZEdXpUQU5jZE5aMFdpZFVrOEpxR3o2aHNWSmRJVU1zYll4L091REhY?=
 =?utf-8?B?MDhyVzZ2d3lOa1JKL0pnWDVWL2MyM1RSaXljZ2ZIenY1c3htaHpBQWVtT2Ni?=
 =?utf-8?B?QTc5ZnJueFRDU2dsL014K1M0R2NBZGo2T1psRFJ2WHo0TVBGZDZnb1ZoN3R5?=
 =?utf-8?B?cGhPc0tMSTJIUW80cm8rKzJ1bGlPV1lDRE5WRy9VWWdhdnJrT3l5YlJ2MFVu?=
 =?utf-8?B?WGVmRlJPYkVYUGs0eG5Kc1lwelJTaVVMY2VDb3pQdnNsV1k4c1JmRDREbWo2?=
 =?utf-8?B?ZTBVYnlWdk8yRCtCRmJPYTR1Z0ZnS3dYZGFha080RW51MUYwNlZDY05pUUx0?=
 =?utf-8?B?TTlFSFVMYXZrMG5sNmVMTUtYUWF2N0ZoN1NZaVdpSms4R1VwMXI2d0IwR0Vn?=
 =?utf-8?B?TXhTQVNHWjE1Rm42c2QraUd5djdpank0Qk5rYVJ2TWRDVW5CZ3pOaDhkMlF4?=
 =?utf-8?B?NUhBSm5RWmRUY1hYL3V4L3R5Nm1Hdm91QTVSZlZFYkxtSE1DaHlLamYvanFD?=
 =?utf-8?B?WTlCbXl4VUFyYXU2Y1E5WUJudWV0T2p3LzJzTlp5alJzakNlWjFRQktYSS9s?=
 =?utf-8?B?RW1KdXViekh1Qzg4L1RsWkJSeUw3MnFESGRPOXpLMGR1NVJSLzIxSUM4cURZ?=
 =?utf-8?B?NzJKVHY4ejZqTTVTeDNkZm9CMm5QV0d5RSsralAzY3IrN1dGckxLRk1GY0d0?=
 =?utf-8?B?UTlkMnZ1WDhTeFpuUTFqTVJxcjljVjluY0FWUXZBVks4d2tmMHlWOE9xRzFw?=
 =?utf-8?B?YWRJRkVISEVVTVpoanBsazdndXFvdVc4S2swZXRwclY5SDRFdDRaeGZDNWFU?=
 =?utf-8?B?cEZmMWpJMC9sQVp5bkFOTWUzQ21qWjRkNGhOR3ZUZW5TcURwbHFOZGpWOHpX?=
 =?utf-8?B?OGhWUW9EeEJkS1dYaHBseGkvQmt2bEFDYWJKYW50TGJLSmR6S05VTmpvZDdN?=
 =?utf-8?B?NC93ck1MTWRiSm9vVWhKZUtUcHlHMmxWSEpDYWVHTGRMZ1lTUFp3Nzd4RDBz?=
 =?utf-8?B?My9kVTNDbDRXbTdhMFRuOXRML3NFa0I0bk1EVzJYYys1RHN5dVZZMEdiTmZC?=
 =?utf-8?B?V3diUXB2RnV5cU9sQVZOWHltUDkzOG5UZjhLWUZDb3VOejZIR09lZERxZnIv?=
 =?utf-8?B?S1hZS3A1OWMwcEM4WnpUNTQ3S1pkQUJ6cFFLbEdSSWxVcWNEQzFNeGxYSm9I?=
 =?utf-8?B?MGliNVgwbzNDZDhnZDF4eFhuZ09oN25WcFNEUVVuamNxSUd2bGpoU01Qb2Nx?=
 =?utf-8?B?dTJCZnpkWFpFWDB1eTRQMUYwWXk4akpicldac0lueHBKUzhhd0RMT1QwWkxp?=
 =?utf-8?B?cE9lTHVQRlZEWmlBT2Q5WExoc3BYb1JyYjBRTXNTR0EwT1RiM09xa29Zek1G?=
 =?utf-8?B?MU16Z1l1S2wyQko3M0hmbzBEK0cvNHRxQ3RSa3N3bE43eU1YTHF3N0FWbXdo?=
 =?utf-8?B?bEliQU90RkxFeWY0WFZwSDBDTWZheE9FOEVnd1lualQra09oZG5HTE9uMHpB?=
 =?utf-8?B?WW5KTHRVck5haHRkdlVTMngxUlgxSko4amNqckdzNVVZa01ydW1JOXVMS0xC?=
 =?utf-8?B?WkpBRXd3UzhxUGZzWUViZFRCQzd3MW5xaUNvdU5laElZRklROFQ5bms2ZFp2?=
 =?utf-8?B?SkRvKzIzbVhsWlVsZnJEbE1LR0lkSVc2angxNmNDMFlLMzVMc1JDTVBHNjcv?=
 =?utf-8?B?eDR1MHduOWRpVFEyc0M0am8zVDVseGRrTDdCSklHVU5LSFBPZkVOK2svZmY1?=
 =?utf-8?B?MlpHOGNWTSt3SkN3ZnM5QS9hM0V1UmtPSDMvNHROWTc4eEFkS1lUUDJRUjc5?=
 =?utf-8?B?VU1TM3FML1RPaEtFMjNxWmJiUUYwUGVUT3o0eVQ1TU9wM3hBbmhFVkJXc2c3?=
 =?utf-8?Q?67z/cPVVPvC8UBmiKDeX1RKg3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cf8dc042-de61-43b5-5120-08dbb36417fc
X-MS-Exchange-CrossTenant-AuthSource: DB5PR02MB10072.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 07:44:28.4816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cdec9SfJuucQ9pk7qDovwOarjpQQI9EHOFQBNaHb6PQesqZTUmYsZtZuBYO3zCSQLm6NgjnX5ADcWa2oMeJccA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB7923
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:44:46 -0700 (PDT)

On 9/12/23 09:22, Bjørn Mork wrote:
> Stefan x Nilsson <stefan.x.nilsson@axis.com> writes:
> 
>> Certain QMI modems will start communicating in rawip mode after
>> bootup, and will not work properly if communication starts off in
>> ethernet mode. So add a module parameter, rawip_as_default, that
>> can be used to load the qmi driver in rawip mode.
>>
>> The advantage compared to changing rawip at a later point using
>> sysfs is that the os will not detect the device and start talking
>> to it while the driver is still in incorrect mode.
>>
>> Signed-off-by: Stefan x Nilsson <stefan.x.nilsson@axis.com>
>> ---
>>   drivers/net/usb/qmi_wwan.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index 344af3c5c836..968c60ececf8 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -46,6 +46,10 @@
>>    * commands on a serial interface
>>    */
>>   
>> +/* Module parameters */
>> +static bool rawip_as_default;
>> +module_param(rawip_as_default, bool, 0644);
>> +
>>   /* driver specific data */
>>   struct qmi_wwan_state {
>>   	struct usb_driver *subdriver;
>> @@ -843,6 +847,13 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
>>   	}
>>   	dev->net->netdev_ops = &qmi_wwan_netdev_ops;
>>   	dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group;
>> +
>> +	/* Set the driver into rawip mode if requested by module param */
>> +	if (rawip_as_default) {
>> +		info->flags |= QMI_WWAN_FLAG_RAWIP;
>> +		qmi_wwan_netdev_setup(dev->net);
>> +	}
>> +
>>   err:
>>   	return status;
>>   }
>>
> 
> NAK
> 
> There is no reason to start communicating with the device before
> changing the framing, using the existing sysfs interface.
> 
> This seems to be a workaround for some userspace bug.  I don't think we
> yet another userspace knob for that.  And certainly not one that applies
> to every device.
> 
> 
> 
> Bjørn

Right, got the message and I see your point. Thanks for the review.

Would a quirk on the affected modem be an better/acceptable solution?

Best Regards
Stefan x Nilsson