Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <c6405ce1-7f93-f30e-7d00-a85890e80214@linux.alibaba.com>
Date:   Wed, 13 Sep 2023 10:02:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.14.0
Subject: Re: [PATCH v8 3/8] perf vendor events: Supplement the omitted
 EventCode
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>
References: <1694087913-46144-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1694087913-46144-4-git-send-email-renyu.zj@linux.alibaba.com>
 <CAP-5=fUyj_Xkkbx5W2Kr88BwZLF1QQ9XcBsbnumnHZM_P+0t2g@mail.gmail.com>
 <01eecef3-a918-a6d0-6f9f-d3b99c9680a8@linux.alibaba.com>
 <ZQDLbBqWY6foLgB+@kernel.org>
From:   Jing Zhang <renyu.zj@linux.alibaba.com>
In-Reply-To: <ZQDLbBqWY6foLgB+@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/9/13 上午4:34, Arnaldo Carvalho de Melo 写道:
> Em Mon, Sep 11, 2023 at 10:41:16AM +0800, Jing Zhang escreveu:
>>
>> 在 2023/9/9 上午5:18, Ian Rogers 写道:
>>> On Thu, Sep 7, 2023 at 4:58 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote:
>>>> If there is an "event=0" in the event description, the EventCode can
>>>> be omitted in the JSON file, and jevent.py will automatically fill in
>>>> "event=0" during parsing.
>>>>
>>>> However, for some events where EventCode and ConfigCode are missing,
>>>> it is not necessary to automatically fill in "event=0", such as the
>>>> CMN event description which is typically "type=xxx, eventid=xxx".
>>>>
>>>> Therefore, before modifying jevent.py to prevent it from automatically
>>>> adding "event=0" by default, it is necessary to fill in all omitted
>>>> EventCodes first.
>>>>
>>>> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
>>> I thought you were going to change the behavior in jevents.py so this
>>> change would be unnecessary. The next time the json is generated by
>>> the script:
>>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
>>> then this will break. It seems easier to workaround the issue in jevents.py.
>>>
>> Okay, I will workaround the issue in jevents.py. Thank you!
> So this means you will resubmit the whole 8-patches long series or
> should we merge this one and then get a followup patch?
> 

Please wait for v9 as there are still some unresolved issues in this series.

Thanks,
Jing

> - Arnaldo
>  
>>> Thanks,
>>> Ian