Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2981914rdb; Tue, 12 Sep 2023 20:04:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlD8TYcGtX1HGt09mFvQ1+gnQyZ8vtHT35QrmEIKesibLxoE9jcT/L9qymFLPXZziivPgD X-Received: by 2002:a05:6a21:78a8:b0:14c:d494:77d1 with SMTP id bf40-20020a056a2178a800b0014cd49477d1mr1467882pzc.10.1694574259874; Tue, 12 Sep 2023 20:04:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694574259; cv=none; d=google.com; s=arc-20160816; b=OPUcW+qFdN1Ear7fc9CfPBHOiV4ZYJZPqlBDGOpQltv1FbG6SU6IuY6mwge0sMzPxX CPNE1wTtsb+zAnCd9n23T9x0QonxGAoHLdy8uIFtPwOGOob2FCo6S4zfYA4bRrraFWO+ lg/WfrCl/uWS7lGY63kiGlKSZKZQ0GoBmX8bZSdgHtrrr21+Ai0OZejxozg4q/GWBgdp vYw78lc37cYF7RTqtYD9lFDg5TSLD1N2ZrcYgv5hfJhDCAPySpvYT2D3reNI62Sr/54k wfaKzDiC1IECwvBb1LAbzEco0JzWQwJq0fIBDO0liyxZUs0hRVT2lsdqWSUcXNp5eNQz RuWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=b49Pqh+sXH4NZ80lnMjFaFKAxs+LlRjGILb+h+cUzpo=; fh=WoCKewePN9634iUES3+NeP28ilixV0mtuYDwzorM59Q=; b=rlUT9gLdHLUq69ujtCNfU8D7gEem7P3AmWRIC99/5xB8zmtZsJknUnpN5iM1QPqtQS icOHj4BhhBpa43Lhr25FmlakssT0Bg5+/qwDd1vxkb0PKX6QiIb+b+JzriqZhoeCsy4r HUsz7NU5AKc5VeKQMzIN9Db4Xud5fzvWPbZb24RcLMdOBrEUuCmzmWTxU2tpNCEjTC6E hhhnkVBD2l7LHYCYo8n+G7HTays4439MHbm2bU6rYpilrIlgT5I+h9SXQIXwy3Cuh849 oNeQz4A2Jp/V20OYoehny8YUuqW7IQAlp1zgoY217QOYzQpcW4wUYBPLJdn9ngm5YJ30 3CPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m1hRhxVs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id fr7-20020a17090ae2c700b0027367e0c931si610234pjb.129.2023.09.12.20.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 20:04:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m1hRhxVs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 91C6F801BABC; Tue, 12 Sep 2023 20:01:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235893AbjIMDBm (ORCPT + 99 others); Tue, 12 Sep 2023 23:01:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjIMDBl (ORCPT ); Tue, 12 Sep 2023 23:01:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8958D10F7; Tue, 12 Sep 2023 20:01:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5101C433C8; Wed, 13 Sep 2023 03:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694574097; bh=F8bl2DbCzDBsTUKDv3rVr02AaeyY+56PVhs05mU6/Fc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m1hRhxVsP2lXowGgNWYqy5n/3zpFidVnI994D3uYOqaGmWqZ3X8dJFB94N8VwRvWx neiX1MUUEzRfGmvKxt8GRh6I1PraPYN7+q54jAcMfmNoeEaFazxvPymM1H6Hd6LdU4 mo2Ptyii4gutVZ5UO8whxjzgngyvHykqhfOo9kiHKToiR62v4Tk0gTfpojyo+OuX1E 0n7ehzCTsMbdgCFBs292Z/tl+kzBthBwbpuZEpnIOTVBbcYhvVEVacwNU4O+noD0Bn dVWDvi0PcCHOZ64zgKYASsnnPKUBxd7TrwGdgJ9HHeTcvjMy4Y/kJx1/77W14BSJJK fNLvWUZdijWtw== Date: Wed, 13 Sep 2023 12:01:34 +0900 From: Masami Hiramatsu (Google) To: Shuah Khan Cc: Steven Rostedt , Shuah Khan , Mark Brown , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment Message-Id: <20230913120134.ebe446942ad5d3b883c3e9a6@kernel.org> In-Reply-To: <49f6d44b-b6e8-bfca-1df7-3ab94684902e@linuxfoundation.org> References: <169448103881.242465.4589561134225171701.stgit@devnote2> <20230911212453.58b9082a@gandalf.local.home> <49f6d44b-b6e8-bfca-1df7-3ab94684902e@linuxfoundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Sep 2023 20:01:45 -0700 (PDT) X-Spam-Status: No, score=-2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email On Tue, 12 Sep 2023 09:35:58 -0600 Shuah Khan wrote: > On 9/11/23 19:24, Steven Rostedt wrote: > > On Tue, 12 Sep 2023 10:10:39 +0900 > > "Masami Hiramatsu (Google)" wrote: > > > >> From: Masami Hiramatsu (Google) > >> > >> Fix to unmount the tracefs if the ftracetest mounted it for recovering > >> system environment. If the tracefs is already mounted, this does nothing. > >> > >> Suggested-by: Mark Brown > >> Link: https://lore.kernel.org/all/29fce076-746c-4650-8358-b4e0fa215cf7@sirena.org.uk/ > >> Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel") > >> Signed-off-by: Masami Hiramatsu (Google) > >> --- > >> Changes in v2: > >> - use -n option explictly for testing the string is non-zero. > >> --- > >> tool > > > > Reviewed-by: Steven Rostedt (Google) > > > > -- Steve > > Thank you all. Applied to linux-kselftest fixes branch for next rc > Thanks Shuah! > thanks, > -- Shuah -- Masami Hiramatsu (Google)