Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <32a8715a63b686aa0ac19fdae22b5d605d47ae35.camel@redhat.com>
Subject: Re: [PATCH net-next v1 2/2] net: core: Sort headers alphabetically
From:   Paolo Abeni <pabeni@redhat.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Simon Horman <horms@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
Date:   Tue, 12 Sep 2023 19:25:48 +0200
In-Reply-To: <ZQCaMHBHp/Ha29ao@smile.fi.intel.com>
References: <20230911154534.4174265-1-andriy.shevchenko@linux.intel.com>
         <20230911154534.4174265-2-andriy.shevchenko@linux.intel.com>
         <20230912152031.GI401982@kernel.org> <ZQCTXkZcJLvzNL4F@smile.fi.intel.com>
         <20f57b1309b6df60b08ce71f2d7711fa3d6b6b44.camel@redhat.com>
         <ZQCaMHBHp/Ha29ao@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-09-12 at 20:04 +0300, Andy Shevchenko wrote:
> On Tue, Sep 12, 2023 at 06:53:23PM +0200, Paolo Abeni wrote:
> > On Tue, 2023-09-12 at 19:35 +0300, Andy Shevchenko wrote:
> > > On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> > > > On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> > > > > It's rather a gigantic list of heards that is very hard to follow=
.
> > > > > Sorting helps to see what's already included and what's not.
> > > > > It improves a maintainability in a long term.
> > > > >=20
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com=
>
> > > >=20
> > > > Hi Andy,
> > > >=20
> > > > At the risk of bike shedding, the sort function of Vim, when operat=
ing
> > > > with the C locale, gives a slightly different order, as experssed b=
y
> > > > this incremental diff.
> > > >=20
> > > > I have no objections to your oder, but I'm slightly curious as
> > > > to how it came about.
> > >=20
> > > !sort which is external command.
> > >=20
> > > $ locale -k LC_COLLATE
> > > collate-nrules=3D4
> > > collate-rulesets=3D""
> > > collate-symb-hash-sizemb=3D1303
> > > collate-codeset=3D"UTF-8"
> >=20
> > I'm unsure this change is worthy. It will make any later fix touching
> > the header list more difficult to backport, and I don't see a great
> > direct advantage.
>=20
> As Rasmus put it here
> https://lore.kernel.org/lkml/5eca0ab5-84be-2d8f-e0b3-c9fdfa961826@rasmusv=
illemoes.dk/
> In short term you can argue that it's not beneficial, but in long term it=
's given
> less conflicts.
>=20
> > Please repost the first patch standalone.
>=20
> Why to repost, what did I miss? It's available via lore, just run
>=20
>   b4 am -slt -P _ 20230911154534.4174265-1-andriy.shevchenko@linux.intel.=
com
>=20
> to get it :-)

It's fairly better if actions (changes) on patches are taken by the
submitter: it scales way better, and if the other path take places we
can be easily flooded with small (but likely increasingly less smaller)
requests that will soon prevent any other activity from being taken.

Please, repost the single patch, it would be easier to me.

Thanks!

Paolo