DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=JYvfuas/IQf76knDIPwQIpkD8wGAdfq5LNxOKEZW8HWWRj5O4if0jReGHkMyBQRe3QJwYdReQSs5TKsFrvj58ySmQZ/WEUVr2LE0nNvfK/zVPVlSVLhcYxh1b/rI2dcl8aK7smZHIvcZC3KTErMYo9iGIdIbylAhXPrncfVXQi0=
Message-ID: <661de9470711060903w73f6eca4r83a9bdd777bd5366@mail.gmail.com>
Date: Tue, 6 Nov 2007 22:33:51 +0530
From: "Balbir Singh" <balbir@linux.vnet.ibm.com>
To: "Jonathan Corbet" <corbet@lwn.net>
Subject: Re: Patch tags [was writeout stalls in current -git]
Cc: "Andrew Morton" <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
In-Reply-To: <28448.1194366312@lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20071105155749.73e0e38e.akpm@linux-foundation.org>
	 <28448.1194366312@lwn.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1716
Lines: 42

> This seems like as good an opportunity as any to toss my patch tags
> document out there one more time.  I still think it's a good idea to
> codify some sort of consensus on what these tags mean...
>
> jon
>

[snip]

> +By offering my Reviewed-by: tag, I state that:
> +
> + (a) I have carried out a technical review of this patch to evaluate its
> +     appropriateness and readiness for inclusion into the mainline kernel.
> +
> + (b) Any problems, concerns, or questions relating to the patch have been
> +     communicated back to the submitter.  I am satisfied with the
> +     submitter's response to my comments.
> +
> + (c) While there may be things that could be improved with this submission,
> +     I believe that it is, at this time, (1) a worthwhile modification to
> +     the kernel, and (2) free of known issues which would argue against its
> +     inclusion.
> +
> + (d) While I have reviewed the patch and believe it to be sound, I do not
> +     (unless explicitly stated elsewhere) make any warranties or guarantees
> +     that it will achieve its stated purpose or function properly in any
> +     given situation.

How about adding a Commented-on-by?

Initial version(s) that are not suitable or still shaping up are
commented-on by several people. A person who comments on one version
might not do a thorough review of the entire code, but through a
series of comments has contributed by pushing the developer in the
correct direction.

Balbir
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/