Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 12 Sep 2023 14:13:20 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     <alison.schofield@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "Len Brown" <lenb@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Borislav Petkov" <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Mike Rapoport <rppt@kernel.org>
CC:     Alison Schofield <alison.schofield@intel.com>, <x86@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Derick Marks <derick.w.marks@intel.com>
Subject: RE: [PATCH v4 2/2] ACPI: NUMA: Apply SRAT proximity domain to entire
 CFMWS window
Message-ID: <6500d470d363f_19f612942b@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1689018477.git.alison.schofield@intel.com>
 <eaa0b7cffb0951a126223eef3cbe7b55b8300ad9.1689018477.git.alison.schofield@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <eaa0b7cffb0951a126223eef3cbe7b55b8300ad9.1689018477.git.alison.schofield@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xrU+HRLZkLs9drv/NoKmWmawtS5fq2mG19qUQKQUBh4Yi8NRwxGpnbrSPMoM?=
 =?us-ascii?Q?mXKE1IaDWFmuiAJxG0kkG3G+5K7TOH4VyT/L94Vbw+jfPSQh6q/ZNr7RPkqH?=
 =?us-ascii?Q?E33gwyUPD2bTY0HQPEXc8N38YzlwHibRWZv5JaHO7/ZLWTtuZCFKcaf4qwaF?=
 =?us-ascii?Q?i/2ove0kKF3TZ31VMebjGh8Z1ncznVx0E0ZHL1cDdxBskjXVD92aGJn5hAvx?=
 =?us-ascii?Q?89VCYE14rUDDo03kR1PqwzHMwc4/LKXzqNJJOUiUWbB6e2c/GMYdFATo4TsD?=
 =?us-ascii?Q?OnJwVpujSHV0jzNORbxUvlWyb2chZYKRFPlCcKRWu4+b1vvyYc9TFJ/g9PxL?=
 =?us-ascii?Q?Ps+i/IyGgTB1MQ77ZXN1P9edPMv736iv+TRewywpc//cKVABWyuTsESjg1yR?=
 =?us-ascii?Q?MRfR5RPoqhg5hlycs7W3DI7VDAZ1qD0s4dO+KuRiYHULeIo12KPdaZpYiJ30?=
 =?us-ascii?Q?w3DE0nRBVuSsB1QS6isX93Yk/CbykiE4+gVe31bVcvKidQQArNLvRviYLt4u?=
 =?us-ascii?Q?V80U7WePUpl4p6GxNfE022X5T+Ik7FytrT+v9Xi/atPFD4sM7t4EwpRSzZsa?=
 =?us-ascii?Q?/Bkyer122FIJdAKAaMWgZcNcVTwovMJO10pru/4bDSmDmwQsWoBEQgtaj+ST?=
 =?us-ascii?Q?QChaq5APfsicCLBOnuwyyKKvTcz2rVk9VDfWBNGHiUOy9U05f0X3SEGKZNfB?=
 =?us-ascii?Q?IY1Sisk1z3XAev/lWRsxvCRaXVmUYvE5pbtncikZTonOIzEFXDv4EFAQsBfE?=
 =?us-ascii?Q?8u5L4LNh+2bRLU6/6Sm1QPYnmcJG9ig1YuSvReuG70EMS4CK5ijtDtjEniio?=
 =?us-ascii?Q?IANvAq/cZlsrCbXBdTxQae1JfF941GBTxHIZQVUMnfPzpqG1CcR/cx1kvcQW?=
 =?us-ascii?Q?ZJEr74qOn8udzdbl2EHS24lxANflAYHZhTjN3Y69J0cUMccH4pIGAJywdLD4?=
 =?us-ascii?Q?8Xab+iDlipkVvt/rLotM4saaNGsilTuPoC1OmLZI9y5Ug5UbP27nv2+7hbJQ?=
 =?us-ascii?Q?7n1fhssgHf22pnYplx7CxgpCuMepgVLUMmYS0PZ8HuKQ3q5J1xIyZleE5KWL?=
 =?us-ascii?Q?nG2xplVzcHrNtBcq0d38we0SiCSJtZLeGTbchtINbrMS+yiyZOszjgdn4A3G?=
 =?us-ascii?Q?vVquh/yTsTtfH5YActYyxqqrurAWc0HMLwkykits5vYAIj+hyimEEII6tv7j?=
 =?us-ascii?Q?7gDyUYir6aN8sqCFvwocckiR6l6woqUwmN/I/I0WorTQ9nUvpoolTNcjcvY3?=
 =?us-ascii?Q?iC7scWPGpstNGiHtE+lz/5DIuKRteSqglZplEe5+XPw05BfPSzHLZuXmYasf?=
 =?us-ascii?Q?0SGgRQLzaMniWZVFkcEPZXfJqnZr0sPSjNeZDaoMyRdAmEH1iy+Fk36TMs9X?=
 =?us-ascii?Q?X2ku2kXH0s7bvDFmhNy/kh5K0jrE2k5vmQvgI/syLQokqshrdfAzmumCDKjO?=
 =?us-ascii?Q?wre2xi3K9qVjkexpwTFITpqo6tPH3dlNhTcYp3oRoKmRWRzy/ziOqy0r0PBn?=
 =?us-ascii?Q?bOlivUE7xk83GMpEMXqbmzOl20Ci79V0sd4pIrYddPTNRXSlNh3gTb91A8GL?=
 =?us-ascii?Q?k1Dnwq0JFGaKHqBHz2axlT8EvOzQhPNTLETu3XIAAVWr6g5aGH0XlSvLmimu?=
 =?us-ascii?Q?Kw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff25f85-e23b-4a5c-11b2-08dbb3d51958
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 21:13:23.9672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KJhOCTPk9YzB+vQfqW68IXdQJ6Nv8Dm2vqLhNmEU+Dp1YJAuIBfaeUrO8E0isQVnUoTeWO+8j4ucKtkbJ9zr+ueE2g6PjdJD9il77TmwbPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7042
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Sep 2023 14:13:40 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email

alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> Commit fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each
> CFMWS not in SRAT") did not account for the case where the BIOS
> only partially describes a CFMWS Window in the SRAT. That means
> the omitted address ranges, of a partially described CFMWS Window,
> do not get assigned to a NUMA node.
> 
> Replace the call to phys_to_target_node() with numa_add_memblks().
> Numa_add_memblks() searches an HPA range for existing memblk(s)
> and extends those memblk(s) to fill the entire CFMWS Window.
> 
> Extending the existing memblks is a simple strategy that reuses
> SRAT defined proximity domains from part of a window to fill out
> the entire window, based on the knowledge* that all of a CFMWS
> window is of a similar performance class.
> 
> *Note that this heuristic will evolve when CFMWS Windows present
> a wider range of characteristics. The extension of the proximity
> domain, implemented here, is likely a step in developing a more
> sophisticated performance profile in the future.
> 
> There is no change in behavior when the SRAT does not describe
> the CFMWS Window at all. In that case, a new NUMA node with a
> single memblk covering the entire CFMWS Window is created.
> 
> Fixes: fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT")
> Reported-by: Derick Marks <derick.w.marks@intel.com>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Tested-by: Derick Marks <derick.w.marks@intel.com>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>